From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 6CD1C3857C58 for ; Thu, 16 Jul 2020 19:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6CD1C3857C58 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurelien@aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=P7bAOzFwD6MQLVFm+lzLPtywGiGRSodbNUArQjrVgyk=; b=WGu2iAk7MtxPJK+gZ0yYZ52y2v 3Jrdzi1eVJNI2G7lJots/5k1SZAjuT5Ad8vRm2RV9l7EWwIUouMWCBD+jJlMUAxAZ2hG0F3dqR3m+ MDp8sv+f8zqmsO432gezUmRwHb2L9v0GfNcjXb8g5OhQyuyAAFKm8033BHGbFLY/+v0tjvh3bO+MU TEtsuS29huJnMXeWK6NeLlT0iTlE97WmwTuBLq+eGhErF7UPceeoWllczTnPp8taHEmHmvOKyCW8g /UpAYMZhWoEsRCOdGqcr+ahX0xN8rsmwVy/L3I61iOF3GclsILZX8ncul5mHxHNZjcnw88bdF9FJJ Uniw4wzQ==; Received: from [2a01:e35:2fdd:a4e1:fe91:fc89:bc43:b814] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw9hv-0004oW-4C; Thu, 16 Jul 2020 21:38:15 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.94) (envelope-from ) id 1jw9hu-00DTo2-IE; Thu, 16 Jul 2020 21:38:14 +0200 Date: Thu, 16 Jul 2020 21:38:14 +0200 From: Aurelien Jarno To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248] Message-ID: <20200716193814.GB8268@aurel32.net> Mail-Followup-To: Florian Weimer , "H.J. Lu via Libc-alpha" References: <20200716112651.2257283-1-hjl.tools@gmail.com> <87o8ofy8e7.fsf@oldenburg2.str.redhat.com> <87d04vxxk6.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d04vxxk6.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.14.0 (2020-05-02) X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 19:38:17 -0000 On 2020-07-16 17:57, Florian Weimer via Libc-alpha wrote: > * H. J. Lu via Libc-alpha: > > >> Isn't it sufficient to change the type of id to unsigned long int[3]? > >> The UID arguments are unsigned on the kernel side, so no sign extension > >> is required. > > > > It works. Here is the updated patch. OK for master? > > Does the test work if the list of supplementary groups is empty? It depends how you defined "work". It doesn't fail wrongly when it happens, so there is no risk of a failed test on other architectures. OTOH it doesn't catch the issue on x32 as setgroups(0, bad_pointer) just return successfully. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net