Re: [PATCH] Disable warnings due to deprecated libselinux symbols used by nss and nscd

[Arjun Shankar <arjun.is@lostca.se>]

On Wed, Jul 22, 2020 at 11:47:41AM -0700, H.J. Lu wrote:

> > +/* security_context_t and sidput (along with several other symbols) were marked
> > +   as deprecated by the SELinux API starting from version 3.1.  We use them
> > +   here, but should eventually switch to the newer API.  */
> > +DIAG_PUSH_NEEDS_COMMENT
> > +DIAG_IGNORE_NEEDS_COMMENT (10, "-Wdeprecated-declarations");
> >
> >  /* Check the permission from the caller (via getpeercon) to nscd.
> >     Returns 0 if access is allowed, 1 if denied, and -1 on error.
> > @@ -411,6 +425,7 @@ nscd_request_avc_has_perm (int fd, request_type req)
> >    rc = avc_has_perm (ssid, tsid, sc_nscd, perm, &aeref, NULL) < 0;
> >
> >  out:
> > +
> 
> Why this?

Thanks for catching that. It is a stray newline and needs to go.

I originally wanted to restrict the pragma to just the target of the "out:"
label, but then I moved away from that idea (there were other deprecated
symbols used in this function), and forgot to delete the newline I had added.

If this patch gets accepted without further changes, I'll remove the newline
before I commit.