From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arjun.is@lostca.se>
Received: from aloka.lostca.se (aloka.lostca.se [IPv6:2a01:4f8:120:624c::2])
 by sourceware.org (Postfix) with ESMTPS id 205343858D38
 for <libc-alpha@sourceware.org>; Wed, 22 Jul 2020 21:07:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 205343858D38
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=lostca.se
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=arjun.is@lostca.se
Received: from aloka.lostca.se (aloka [127.0.0.1])
 by aloka.lostca.se (Postfix) with ESMTP id CAC449AB5;
 Wed, 22 Jul 2020 21:07:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=lostca.se; h=date:from:to
 :cc:subject:message-id:references:mime-version:content-type
 :in-reply-to; s=howrah; bh=94+/l9VV6QwlesVItw7yJJEKlY4=; b=ylh6Y
 4+DQH4Tccepn8IuW9BZJpyLDRCRqIHZDW/0Mz90YlTT8bWZE8iWpxH0u52Rm7vdZ
 hJyF450XrbVP05wdhInvKopk59F/5vq+X2iWT8Lx6FMdBvmLYDto7uicbt3NASwc
 CQrz/3L5SzMPs+3RNEii6mNEx4wg2KmxZzT1J4=
Received: from localhost (unknown [IPv6:2a01:4f8:120:624c::25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by aloka.lostca.se (Postfix) with ESMTPSA id 8C0E29AB4;
 Wed, 22 Jul 2020 21:07:17 +0000 (UTC)
Date: Wed, 22 Jul 2020 21:07:16 +0000
From: Arjun Shankar <arjun.is@lostca.se>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
 Carlos O'Donell <carlos@redhat.com>,
 Joseph Myers <joseph@codesourcery.com>,
 Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] Disable warnings due to deprecated libselinux symbols
 used by nss and nscd
Message-ID: <20200722210716.GA76423@aloka.lostca.se>
References: <20200722183849.GA74546@aloka.lostca.se>
 <CAMe9rOpvRi5zFW2yNW1eODFywznE9Kn0dhyy0xuKgUy6TH86Dw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMe9rOpvRi5zFW2yNW1eODFywznE9Kn0dhyy0xuKgUy6TH86Dw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 21:07:20 -0000

On Wed, Jul 22, 2020 at 11:47:41AM -0700, H.J. Lu wrote:

> > +/* security_context_t and sidput (along with several other symbols) were marked
> > +   as deprecated by the SELinux API starting from version 3.1.  We use them
> > +   here, but should eventually switch to the newer API.  */
> > +DIAG_PUSH_NEEDS_COMMENT
> > +DIAG_IGNORE_NEEDS_COMMENT (10, "-Wdeprecated-declarations");
> >
> >  /* Check the permission from the caller (via getpeercon) to nscd.
> >     Returns 0 if access is allowed, 1 if denied, and -1 on error.
> > @@ -411,6 +425,7 @@ nscd_request_avc_has_perm (int fd, request_type req)
> >    rc = avc_has_perm (ssid, tsid, sc_nscd, perm, &aeref, NULL) < 0;
> >
> >  out:
> > +
> 
> Why this?

Thanks for catching that. It is a stray newline and needs to go.

I originally wanted to restrict the pragma to just the target of the "out:"
label, but then I moved away from that idea (there were other deprecated
symbols used in this function), and forgot to delete the newline I had added.

If this patch gets accepted without further changes, I'll remove the newline
before I commit.