* [hurd,commited] hurd: Implement basic sched_get/setscheduler
@ 2020-08-05 21:47 Samuel Thibault
2020-08-06 18:01 ` Joseph Myers
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2020-08-05 21:47 UTC (permalink / raw)
To: libc-alpha; +Cc: Samuel Thibault, commit-hurd
* sysdeps/mach/hurd/sched_gets.c: New file.
* sysdeps/mach/hurd/sched_sets.c: New file.
---
sysdeps/mach/hurd/sched_gets.c | 30 +++++++++++++++++++++++
sysdeps/mach/hurd/sched_sets.c | 45 ++++++++++++++++++++++++++++++++++
2 files changed, 75 insertions(+)
create mode 100644 sysdeps/mach/hurd/sched_gets.c
create mode 100644 sysdeps/mach/hurd/sched_sets.c
diff --git a/sysdeps/mach/hurd/sched_gets.c b/sysdeps/mach/hurd/sched_gets.c
new file mode 100644
index 0000000000..9fe31ce79e
--- /dev/null
+++ b/sysdeps/mach/hurd/sched_gets.c
@@ -0,0 +1,30 @@
+/* Copyright (C) 2020 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <errno.h>
+#include <sched.h>
+#include <sys/types.h>
+#include <hurd.h>
+
+
+/* Retrieve scheduling algorithm for a particular purpose. */
+int
+__sched_getscheduler (pid_t pid)
+{
+ return SCHED_OTHER;
+}
+weak_alias (__sched_getscheduler, sched_getscheduler)
diff --git a/sysdeps/mach/hurd/sched_sets.c b/sysdeps/mach/hurd/sched_sets.c
new file mode 100644
index 0000000000..54d368abf5
--- /dev/null
+++ b/sysdeps/mach/hurd/sched_sets.c
@@ -0,0 +1,45 @@
+/* Copyright (C) 1996-2020 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <errno.h>
+#include <sched.h>
+#include <sys/types.h>
+#include <hurd.h>
+
+
+/* Set scheduling algorithm and/or parameters for a process. */
+int
+__sched_setscheduler (pid_t pid, int policy, const struct sched_param *param)
+{
+ switch (policy)
+ {
+ case SCHED_OTHER:
+ if (param->sched_priority != 0)
+ return __hurd_fail (EINVAL);
+ break;
+
+ case SCHED_FIFO:
+ case SCHED_RR:
+ return __hurd_fail (ENOTSUP);
+
+ default:
+ return EINVAL;
+ }
+ return 0;
+}
+libc_hidden_def (__sched_setscheduler)
+weak_alias (__sched_setscheduler, sched_setscheduler)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [hurd,commited] hurd: Implement basic sched_get/setscheduler
2020-08-05 21:47 [hurd,commited] hurd: Implement basic sched_get/setscheduler Samuel Thibault
@ 2020-08-06 18:01 ` Joseph Myers
2020-08-06 18:16 ` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2020-08-06 18:01 UTC (permalink / raw)
To: Samuel Thibault; +Cc: libc-alpha, commit-hurd
On Wed, 5 Aug 2020, Samuel Thibault wrote:
> +/* Retrieve scheduling algorithm for a particular purpose. */
> +int
> +__sched_getscheduler (pid_t pid)
> +{
> + return SCHED_OTHER;
> +}
> +weak_alias (__sched_getscheduler, sched_getscheduler)
I'm seeing build failures:
../sysdeps/mach/hurd/sched_gets.c:30:35: error: 'sched_getscheduler' aliased to undefined symbol '__sched_getscheduler'
Missing libc_hidden_def, since there is libc_hidden_proto
(__sched_getscheduler) in include/sched.h?
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [hurd,commited] hurd: Implement basic sched_get/setscheduler
2020-08-06 18:01 ` Joseph Myers
@ 2020-08-06 18:16 ` Samuel Thibault
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Thibault @ 2020-08-06 18:16 UTC (permalink / raw)
To: bug-hurd; +Cc: commit-hurd, libc-alpha
Joseph Myers, le jeu. 06 août 2020 18:01:44 +0000, a ecrit:
> On Wed, 5 Aug 2020, Samuel Thibault wrote:
>
> > +/* Retrieve scheduling algorithm for a particular purpose. */
> > +int
> > +__sched_getscheduler (pid_t pid)
> > +{
> > + return SCHED_OTHER;
> > +}
> > +weak_alias (__sched_getscheduler, sched_getscheduler)
>
> I'm seeing build failures:
>
> ../sysdeps/mach/hurd/sched_gets.c:30:35: error: 'sched_getscheduler' aliased to undefined symbol '__sched_getscheduler'
>
> Missing libc_hidden_def, since there is libc_hidden_proto
> (__sched_getscheduler) in include/sched.h?
Oh, sorry, there was indeed a difference there between my previous test
build tree and the current master. Pushed the fix.
Thanks,
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-06 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 21:47 [hurd,commited] hurd: Implement basic sched_get/setscheduler Samuel Thibault
2020-08-06 18:01 ` Joseph Myers
2020-08-06 18:16 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).