From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@gnu.org>
Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1])
 by sourceware.org (Postfix) with ESMTPS id 26E523857023
 for <libc-alpha@sourceware.org>; Thu,  6 Aug 2020 18:16:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 26E523857023
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org;
 spf=fail smtp.mailfrom=samuel.thibault@gnu.org
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 5BBDFC359;
 Thu,  6 Aug 2020 20:16:05 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id KIws6klgiXEB; Thu,  6 Aug 2020 20:16:04 +0200 (CEST)
Received: from function.home (unknown
 [IPv6:2a01:cb19:956:1b00:9eb6:d0ff:fe88:c3c7])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 8606ABF75;
 Thu,  6 Aug 2020 20:16:04 +0200 (CEST)
Received: from samy by function.home with local (Exim 4.94)
 (envelope-from <samuel.thibault@gnu.org>)
 id 1k3kQt-003bQ4-Od; Thu, 06 Aug 2020 20:16:03 +0200
Date: Thu, 6 Aug 2020 20:16:03 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
To: bug-hurd@gnu.org
Cc: commit-hurd@gnu.org, libc-alpha@sourceware.org
Subject: Re: [hurd,commited] hurd: Implement basic sched_get/setscheduler
Message-ID: <20200806181603.jhjecfen6rgq3wyv@function>
Mail-Followup-To: bug-hurd@gnu.org, commit-hurd@gnu.org,
 libc-alpha@sourceware.org
References: <20200805214736.386404-1-samuel.thibault@ens-lyon.org>
 <alpine.DEB.2.21.2008061800230.2071@digraph.polyomino.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.21.2008061800230.2071@digraph.polyomino.org.uk>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_SOFTFAIL,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2020 18:16:08 -0000

Joseph Myers, le jeu. 06 août 2020 18:01:44 +0000, a ecrit:
> On Wed, 5 Aug 2020, Samuel Thibault wrote:
> 
> > +/* Retrieve scheduling algorithm for a particular purpose.  */
> > +int
> > +__sched_getscheduler (pid_t pid)
> > +{
> > +  return SCHED_OTHER;
> > +}
> > +weak_alias (__sched_getscheduler, sched_getscheduler)
> 
> I'm seeing build failures:
> 
> ../sysdeps/mach/hurd/sched_gets.c:30:35: error: 'sched_getscheduler' aliased to undefined symbol '__sched_getscheduler'
> 
> Missing libc_hidden_def, since there is libc_hidden_proto 
> (__sched_getscheduler) in include/sched.h?

Oh, sorry, there was indeed a difference there between my previous test
build tree and the current master. Pushed the fix.

Thanks,
Samuel