* Autogenerating ChangeLog for glibc did not work as intended.
@ 2020-08-19 20:34 Carlos O'Donell
2020-08-19 22:14 ` Paul Eggert
0 siblings, 1 reply; 3+ messages in thread
From: Carlos O'Donell @ 2020-08-19 20:34 UTC (permalink / raw)
To: libc-alpha, Paul Eggert, Siddhesh Poyarekar
Paul, Siddhesh,
I want to note that this commit in gnulib:
commit 19e3bce44f042e274892cbee4936afc5f0fabc86
Author: Siddhesh Poyarekar <siddhesh@gotplt.org>
Date: Mon May 18 19:16:03 2020 +0530
vcs-to-changelog: Rename vcs_to_changelog.py to use hyphens.
This was needed earlier because modules had to import the main script,
but that is no longer true. Rename the script so that it is
consistent with all other scripts in gnulib and uses hyphens.
* build-aux/vcs_to_changelog.py: Rename to...
* build-aux/vcs-to-changelog.py: ... this.
* doc/vcs-to-changelog.texi (VCS To ChangeLog): Update reference.
* modules/vcs-to-changelog: Likewise.
Breaks using glibc's ChangeLog generator script.
You cannot import a module with dashes.
To make the glibc 2.32 release I had to revert this commit.
What should we be doing in glibc's scripts/vcstocl_quirks.py to make this work?
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Autogenerating ChangeLog for glibc did not work as intended.
2020-08-19 20:34 Autogenerating ChangeLog for glibc did not work as intended Carlos O'Donell
@ 2020-08-19 22:14 ` Paul Eggert
2020-08-20 3:22 ` [PATCH] [vcstocl] Import ProjectQuirks from its own file Siddhesh Poyarekar
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2020-08-19 22:14 UTC (permalink / raw)
To: Carlos O'Donell, libc-alpha, Siddhesh Poyarekar
On 8/19/20 1:34 PM, Carlos O'Donell wrote:
> What should we be doing in glibc's scripts/vcstocl_quirks.py to make this work?
Most likely just remove its "from vcs_to_changelog import ProjectQuirks" line.
But I haven't tested this, and Siddhesh is the real expert here.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [vcstocl] Import ProjectQuirks from its own file
2020-08-19 22:14 ` Paul Eggert
@ 2020-08-20 3:22 ` Siddhesh Poyarekar
0 siblings, 0 replies; 3+ messages in thread
From: Siddhesh Poyarekar @ 2020-08-20 3:22 UTC (permalink / raw)
To: libc-alpha
ProjectQuirks moved into its own file in gnulib because one cannot
import modules with hyphens in them. Adjust the quirks file to
reflect this reality.
[1] https://lists.gnu.org/archive/html/bug-gnulib/2020-08/msg00177.html
[2] https://lists.gnu.org/archive/html/bug-gnulib/2020-08/msg00178.html
---
Sorry, I missed the quirks file dependency when I renamed
vcs-to-changelog in gnulib. I have posted patches[1][2] to split the
ProjectQuirks class out into its own file since that is a cleaner
solution. I'll commit this once the changes to gnulib are accepted.
scripts/vcstocl_quirks.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/vcstocl_quirks.py b/scripts/vcstocl_quirks.py
index d73a586317..b79b5d954e 100644
--- a/scripts/vcstocl_quirks.py
+++ b/scripts/vcstocl_quirks.py
@@ -17,7 +17,7 @@
# <http://www.gnu.org/licenses/>.
from frontend_c import Frontend
-from vcs_to_changelog import ProjectQuirks
+from projectquirks import ProjectQuirks
import re
class GlibcProjectQuirks(ProjectQuirks):
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-20 3:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 20:34 Autogenerating ChangeLog for glibc did not work as intended Carlos O'Donell
2020-08-19 22:14 ` Paul Eggert
2020-08-20 3:22 ` [PATCH] [vcstocl] Import ProjectQuirks from its own file Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).