From: Lukasz Majewski <lukma@denx.de>
To: Florian Weimer <fweimer@redhat.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Andreas Schwab <schwab@suse.de>, Zack Weinberg <zackw@panix.com>,
Jeff Law <law@redhat.com>,
libc-help@sourceware.org
Subject: Re: [PATCH] [RFC] y2038: nptl: Convert pthread_cond_{clock|timed}wait to support 64 bit time
Date: Mon, 24 Aug 2020 19:50:59 +0200 [thread overview]
Message-ID: <20200824195059.5b125e5e@jawa> (raw)
In-Reply-To: <875z98dkxw.fsf@oldenburg2.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Hi Florian,
> * Lukasz Majewski:
>
> > I'm a bit puzzled here. It is a warning in fact despite I've guarded
> > the function in question with:
> > libpthread_hidden_{proto|def} (futex_abstimed_wait_cancelable64)
>
> I think the linknamespace test attempts to descend into
> futex_abstimed_wait_cancelable64 because it its name is in the public
> (non-implementation) namespace.
>
> Try naming it __futex_abstimed_wait_cancelable64.
Indeed, adding the "__" prefix fixed the issue.
And this "__" prefix is not needed in futex-internal.h functions as
those are "pasted" into source code by C preprocessor ....
Thanks Florian for help :-)
>
> Thanks,
> Florian
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-24 17:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 16:40 Lukasz Majewski
2020-08-24 16:59 ` Lukasz Majewski
2020-08-24 17:15 ` Florian Weimer
2020-08-24 17:50 ` Lukasz Majewski [this message]
2020-08-25 8:08 ` Andreas Schwab
2020-08-25 10:03 ` Lukasz Majewski
2020-08-25 10:34 ` Andreas Schwab
2020-08-25 14:29 ` Adhemerval Zanella
2020-08-25 14:30 ` Lukasz Majewski
2020-08-25 14:47 ` Andreas Schwab
2020-08-25 14:53 ` Adhemerval Zanella
2020-08-25 15:26 ` Andreas Schwab
2020-08-25 15:31 ` Adhemerval Zanella
2020-08-25 15:36 ` Adhemerval Zanella
2020-08-25 14:43 ` Adhemerval Zanella
2020-08-26 17:59 ` Lukasz Majewski
2020-08-26 18:06 ` Florian Weimer
2020-08-26 19:38 ` Adhemerval Zanella
2020-08-27 6:20 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824195059.5b125e5e@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-help@sourceware.org \
--cc=schwab@suse.de \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).