From: Lukasz Majewski <lukma@denx.de>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Alistair Francis <alistair.francis@wdc.com>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] [RFC] y2038: nptl: Convert pthread_cond_{clock|timed}wait to support 64 bit time
Date: Tue, 25 Aug 2020 16:30:15 +0200 [thread overview]
Message-ID: <20200825163015.62e1cedd@jawa> (raw)
In-Reply-To: <871rjvxbd6.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
Hi Andreas,
> On Aug 25 2020, Lukasz Majewski wrote:
>
> > Hi Andreas,
> >
> >> On Aug 24 2020, Lukasz Majewski wrote:
> >>
> >> > diff --git a/sysdeps/unix/sysv/linux/m68k/Makefile
> >> > b/sysdeps/unix/sysv/linux/m68k/Makefile index
> >> > be40fae68a..f19c8c825d 100644 ---
> >> > a/sysdeps/unix/sysv/linux/m68k/Makefile +++
> >> > b/sysdeps/unix/sysv/linux/m68k/Makefile @@ -21,3 +21,8 @@
> >> > sysdep-dl-routines += dl-static sysdep-others += lddlibc4
> >> > install-bin += lddlibc4
> >> > endif
> >> > +
> >> > +ifeq ($(subdir),nptl)
> >> > +libpthread-sysdep_routines += futex-helpers
> >>
> >> Why do you need that twice?
> >
> > This is to fix following issue:
> > https://marc.info/?l=glibc-alpha&m=159730587416436&w=2
>
> But why *twice*?
Ok. So the following snippet:
+ ifeq ($(subdir),nptl) [*]
+ libpthread-sysdep_routines += futex-helpers
Is not needed as it is already placed in /npt/Makefile. Am I correct?
>
> >>
> >> > +CFLAGS-futex-helpers.c += -fno-inline
So, only this modified (without ifeq above [*]) CFLAGS for
futex-helper.c compilation is needed?
> >>
> >> Why do you need that?
> >
> > This solves problem with small number general purpose registers on
> > m68k when inlining this patch.
>
> What do you mean with "inlining this patch"?
When I put futex_abstimed_wait_cancelable64() as static __always_inline
to futex-internals.h then the aforementioned problem on m68k emerge.
>
> Andreas.
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-25 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 16:40 Lukasz Majewski
2020-08-24 16:59 ` Lukasz Majewski
2020-08-24 17:15 ` Florian Weimer
2020-08-24 17:50 ` Lukasz Majewski
2020-08-25 8:08 ` Andreas Schwab
2020-08-25 10:03 ` Lukasz Majewski
2020-08-25 10:34 ` Andreas Schwab
2020-08-25 14:29 ` Adhemerval Zanella
2020-08-25 14:30 ` Lukasz Majewski [this message]
2020-08-25 14:47 ` Andreas Schwab
2020-08-25 14:53 ` Adhemerval Zanella
2020-08-25 15:26 ` Andreas Schwab
2020-08-25 15:31 ` Adhemerval Zanella
2020-08-25 15:36 ` Adhemerval Zanella
2020-08-25 14:43 ` Adhemerval Zanella
2020-08-26 17:59 ` Lukasz Majewski
2020-08-26 18:06 ` Florian Weimer
2020-08-26 19:38 ` Adhemerval Zanella
2020-08-27 6:20 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825163015.62e1cedd@jawa \
--to=lukma@denx.de \
--cc=alistair.francis@wdc.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=stepan@golosunov.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).