Hi Andreas,

> On Aug 25 2020, Lukasz Majewski wrote:
> 
> > Hi Andreas,
> >  
> >> On Aug 24 2020, Lukasz Majewski wrote:
> >>   
> >> > diff --git a/sysdeps/unix/sysv/linux/m68k/Makefile
> >> > b/sysdeps/unix/sysv/linux/m68k/Makefile index
> >> > be40fae68a..f19c8c825d 100644 ---
> >> > a/sysdeps/unix/sysv/linux/m68k/Makefile +++
> >> > b/sysdeps/unix/sysv/linux/m68k/Makefile @@ -21,3 +21,8 @@
> >> > sysdep-dl-routines += dl-static sysdep-others += lddlibc4
> >> >  install-bin += lddlibc4
> >> >  endif
> >> > +
> >> > +ifeq ($(subdir),nptl)
> >> > +libpthread-sysdep_routines += futex-helpers    
> >> 
> >> Why do you need that twice?  
> >
> > This is to fix following issue:
> > https://marc.info/?l=glibc-alpha&m=159730587416436&w=2  
> 
> But why *twice*?

Ok. So the following snippet:

+ ifeq ($(subdir),nptl)  [*]
+   libpthread-sysdep_routines += futex-helpers

Is not needed as it is already placed in /npt/Makefile. Am I correct?

> 
> >>   
> >> > +CFLAGS-futex-helpers.c += -fno-inline 

So, only this modified (without ifeq above [*]) CFLAGS for
futex-helper.c compilation is needed?

> >> 
> >> Why do you need that?  
> >
> > This solves problem with small number general purpose registers on
> > m68k when inlining this patch.  
> 
> What do you mean with "inlining this patch"?

When I put futex_abstimed_wait_cancelable64() as static __always_inline
to futex-internals.h then the aforementioned problem on m68k emerge.

> 
> Andreas.
> 


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de