From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 6BD7C3851C01 for ; Tue, 25 Aug 2020 14:30:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6BD7C3851C01 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BbWcC4JWtz1rwbJ; Tue, 25 Aug 2020 16:30:19 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BbWcC18zMz1r11v; Tue, 25 Aug 2020 16:30:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id PXkls1QKlTTy; Tue, 25 Aug 2020 16:30:17 +0200 (CEST) X-Auth-Info: kUiFsf80sF5jOYtDXyXjgy1aXqRWvA2LNRlRUZS9RAM= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 25 Aug 2020 16:30:17 +0200 (CEST) Date: Tue, 25 Aug 2020 16:30:15 +0200 From: Lukasz Majewski To: Andreas Schwab Cc: Florian Weimer , GNU C Library , Stepan Golosunov , Alistair Francis , Joseph Myers Subject: Re: [PATCH] [RFC] y2038: nptl: Convert pthread_cond_{clock|timed}wait to support 64 bit time Message-ID: <20200825163015.62e1cedd@jawa> In-Reply-To: <871rjvxbd6.fsf@igel.home> References: <20200824164000.1619-1-lukma@denx.de> <20200825120324.74c9ad99@jawa> <871rjvxbd6.fsf@igel.home> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/TWAQXPdRKO8Pf7D4fQK=csC"; protocol="application/pgp-signature" X-Spam-Status: No, score=-17.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 14:30:23 -0000 --Sig_/TWAQXPdRKO8Pf7D4fQK=csC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andreas, > On Aug 25 2020, Lukasz Majewski wrote: >=20 > > Hi Andreas, > > =20 > >> On Aug 24 2020, Lukasz Majewski wrote: > >> =20 > >> > diff --git a/sysdeps/unix/sysv/linux/m68k/Makefile > >> > b/sysdeps/unix/sysv/linux/m68k/Makefile index > >> > be40fae68a..f19c8c825d 100644 --- > >> > a/sysdeps/unix/sysv/linux/m68k/Makefile +++ > >> > b/sysdeps/unix/sysv/linux/m68k/Makefile @@ -21,3 +21,8 @@ > >> > sysdep-dl-routines +=3D dl-static sysdep-others +=3D lddlibc4 > >> > install-bin +=3D lddlibc4 > >> > endif > >> > + > >> > +ifeq ($(subdir),nptl) > >> > +libpthread-sysdep_routines +=3D futex-helpers =20 > >>=20 > >> Why do you need that twice? =20 > > > > This is to fix following issue: > > https://marc.info/?l=3Dglibc-alpha&m=3D159730587416436&w=3D2 =20 >=20 > But why *twice*? Ok. So the following snippet: + ifeq ($(subdir),nptl) [*] + libpthread-sysdep_routines +=3D futex-helpers Is not needed as it is already placed in /npt/Makefile. Am I correct? >=20 > >> =20 > >> > +CFLAGS-futex-helpers.c +=3D -fno-inline=20 So, only this modified (without ifeq above [*]) CFLAGS for futex-helper.c compilation is needed? > >>=20 > >> Why do you need that? =20 > > > > This solves problem with small number general purpose registers on > > m68k when inlining this patch. =20 >=20 > What do you mean with "inlining this patch"? When I put futex_abstimed_wait_cancelable64() as static __always_inline to futex-internals.h then the aforementioned problem on m68k emerge. >=20 > Andreas. >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/TWAQXPdRKO8Pf7D4fQK=csC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl9FIHcACgkQAR8vZIA0 zr3EGAf8DtiAxtPEPr0yMAMVjlz5KLvydRO8ab3N3f0yJ+7XgC9W+3oFlB9fBaCK mYne8CsRowBgpiE3lIDAEmpx1YQE04nMJLUQeK04Xt7WzbG2z4p9d3dQNUNQzplb Wd8XzIFIEx0wO+PSIMRW//SYpg/vLJJ5cDQfNJQbFoOmKke/JjWVTRGmLYzJ3eT5 zQkAm9+dcCFgvY6kEz7lwawlKqbxVEJ5WYORDx9vYwdQIwPR3LyzF3csJqPFlk2S zbwnco73ZxSyk0W7Mrp/PBv5mA49riij0fbmjj8nvB1fzefiZ3zb8BvAUXJm451k RGMYNu8G9CtHBtYbrTRa5IahgfXTDA== =5nRu -----END PGP SIGNATURE----- --Sig_/TWAQXPdRKO8Pf7D4fQK=csC--