public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Ben Woodard via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix runtime linker auditing on aarch64
Date: Wed, 23 Sep 2020 13:48:49 +0100	[thread overview]
Message-ID: <20200923124848.GE16385@arm.com> (raw)
In-Reply-To: <87d02cr8bp.fsf@oldenburg2.str.redhat.com>

The 09/23/2020 14:22, Florian Weimer via Libc-alpha wrote:
> * Ben Woodard via Libc-alpha:
> 
> > To fix this
> >   * The La_aarch64_regs structure was expanded to include x8 and the full
> >     sized NEON V registers that are required to be preserved by the ABI.
> 
> Off-list, you said that the audit interface was completely broken on
> AArch64.  But it seems to be working enough for sotruss.  So I do wonder
> if we have to do a proper ABI transition here after all (bumping
> LAV_CURRENT and all the consequences of that).

i think plt hooks currently don't work for functions
that take neon vector arguments because the save/restore
logic clobbers the top bits (but such extern calls are
not common since they need to use non-portable types)

but i agree if it's not too intrusive to bump the audit
abi then we should do so and then the incompatibility
can be detected at least.

  reply	other threads:[~2020-09-23 12:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  1:16 Ben Woodard
2020-09-23 12:22 ` Florian Weimer
2020-09-23 12:48   ` Szabolcs Nagy [this message]
2020-09-23 12:56     ` Florian Weimer
2020-09-23 13:18       ` Szabolcs Nagy
2020-09-24 11:10         ` Florian Weimer
2020-09-23 12:34 ` Szabolcs Nagy
2020-09-23 15:10   ` Ben Coyote Woodard
2020-09-23 16:19     ` Szabolcs Nagy
2020-09-23 18:12       ` Ben Coyote Woodard
2020-09-23 18:00   ` Ben Coyote Woodard
2020-09-24  0:30 ` Carlos O'Donell
2020-09-24  3:14   ` Ben Coyote Woodard
2020-09-24  8:04     ` Szabolcs Nagy
2020-09-24  9:58     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923124848.GE16385@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).