From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Andreas Schwab <schwab@suse.de>, Zack Weinberg <zackw@panix.com>,
Jeff Law <law@redhat.com>
Subject: Re: [PATCH v2 1/3] nptl: futex: Move __NR_futex_time64 alias to beginning of futex-internal.h
Date: Tue, 29 Sep 2020 18:55:22 +0200 [thread overview]
Message-ID: <20200929185522.07a92cbf@jawa> (raw)
In-Reply-To: <20200919130759.31916-1-lukma@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]
Dear Community,
> This alias macro shall be moved to the beginning of the
> futex-internal.h to be easily reused by other functions, which would
> support 64 bit time.
>
Do we have more comments regarding this patch? Or shall I pull it to
-master?
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
> ---
> Changes for v2:
> - None
> ---
> sysdeps/nptl/futex-internal.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sysdeps/nptl/futex-internal.h
> b/sysdeps/nptl/futex-internal.h index 84ab3f3853..7f3910ad98 100644
> --- a/sysdeps/nptl/futex-internal.h
> +++ b/sysdeps/nptl/futex-internal.h
> @@ -74,6 +74,10 @@
> # error FUTEX_PRIVATE must be equal to 0
> #endif
>
> +#ifndef __NR_futex_time64
> +# define __NR_futex_time64 __NR_futex
> +#endif
> +
> /* Calls __libc_fatal with an error message. Convenience function
> for concrete implementations of the futex interface. */
> static __always_inline __attribute__ ((__noreturn__)) void
> @@ -467,10 +471,6 @@ futex_unlock_pi (unsigned int *futex_word, int
> private) }
> }
>
> -#ifndef __NR_futex_time64
> -# define __NR_futex_time64 __NR_futex
> -#endif
> -
> static __always_inline int
> futex_timed_wait_cancel64 (pid_t *tidp, pid_t tid,
> const struct __timespec64 *timeout, int
> private)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-29 16:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 13:07 Lukasz Majewski
2020-09-19 13:07 ` [PATCH v2 2/3] Y2038: nptl: Provide futex_abstimed_wait64 supporting 64 bit time Lukasz Majewski
2020-09-21 17:00 ` Alistair Francis
2020-09-29 16:55 ` Lukasz Majewski
2020-09-30 11:52 ` Adhemerval Zanella
2020-09-30 12:47 ` Lukasz Majewski
2020-09-30 12:58 ` Andreas Schwab
2020-09-30 13:17 ` Lukasz Majewski
2020-09-30 13:14 ` Adhemerval Zanella
2020-09-30 13:39 ` Lukasz Majewski
2020-09-30 14:06 ` Lukasz Majewski
2020-09-19 13:07 ` [PATCH v2 3/3] y2038: nptl: Convert pthread_rwlock_{clock|timed}{rd|wr}lock to support " Lukasz Majewski
2020-09-29 16:56 ` Lukasz Majewski
2020-09-30 11:59 ` Adhemerval Zanella
2020-09-30 13:12 ` Lukasz Majewski
2020-09-30 13:19 ` Adhemerval Zanella
2020-10-02 12:15 ` Lukasz Majewski
2020-10-02 13:51 ` Adhemerval Zanella
2020-09-29 16:55 ` Lukasz Majewski [this message]
2020-09-29 18:12 ` [PATCH v2 1/3] nptl: futex: Move __NR_futex_time64 alias to beginning of futex-internal.h Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929185522.07a92cbf@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).