From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86]) by sourceware.org (Postfix) with ESMTPS id 4BCE83857C5F for ; Fri, 9 Oct 2020 10:51:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4BCE83857C5F Received: from AM5PR0602CA0018.eurprd06.prod.outlook.com (2603:10a6:203:a3::28) by AM6PR08MB4008.eurprd08.prod.outlook.com (2603:10a6:20b:ae::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Fri, 9 Oct 2020 10:51:06 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::64) by AM5PR0602CA0018.outlook.office365.com (2603:10a6:203:a3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Fri, 9 Oct 2020 10:51:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Fri, 9 Oct 2020 10:51:06 +0000 Received: ("Tessian outbound 7161e0c2a082:v64"); Fri, 09 Oct 2020 10:51:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d35133271525afbc X-CR-MTA-TID: 64aa7808 Received: from bf9bbd683fbd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1AEA8BE3-ABA2-4760-B0AB-EB8C4B766F96.1; Fri, 09 Oct 2020 10:51:00 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf9bbd683fbd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Oct 2020 10:51:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6hosrwfjOFdWc3lD+ZNDcyKouO6SNn8ouhFmlo17C9D6In4QuQbuphP6O7cdjeJOEITEEuJLsfpHqiPq8SbG/7S4nfNpt1OAlcTJO6pKsG0UawL5abU4Pz0KL/j7r/hROoP50KA2EKvWgcnYPxpwaPrlVZZ76c2gTfsyUkoX6MgYY1CtSQ1a7SXVID6XdGxG7vnyIqLxUs0So96gvlOtXk4hOb9RZ0CfICi1Yd5V4cA8qckMSRhgwx+ofFwGHEMPk2QEI6uc1PXItRZRKQYZ+oRj8MjeFiqVKZIh7GAdFLXg5KXfi6XUn6FR7ttYXrI5iwpxbGXoKE7m/t+xotkpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qWD3mLhHmYU+HqV9ick/IpJIAlW/dj40WZwVfg+i+po=; b=jN+iUaq2/2KPmH6H2eMHyBetsmP16E9LFsJNj4LnIM5rGuKFpNEFcrVvbg7xJAz7JCkw/DI0gYI3ZCRqJMF7jHNtNEI+CtMUBLVLYOb1D7KCDDNVWcAm7kQGAkm5+/bFaanM0f1eaiZQOCKcPq6pQOKflbdonyRCGvTp1VRILrSuXkqstoArahEccxiyCa/fVSuMhnbK0bpi8un18/vCIp5QVmVVSZ5x6Yitcl6b/+rUCqIqJbHUiMMBVYnsw6sY3frBVhWfTRWywAFA50/cHMwdScq6pUyfaXc9DyIbVAiJqx8WbNjHhuXvGzbCXCI+1a4s946AL9QOIMJ3NGGRtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) by PR3PR08MB5658.eurprd08.prod.outlook.com (2603:10a6:102:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Fri, 9 Oct 2020 10:50:59 +0000 Received: from PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::957e:c80e:98f4:23d6]) by PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::957e:c80e:98f4:23d6%6]) with mapi id 15.20.3455.023; Fri, 9 Oct 2020 10:50:59 +0000 Date: Fri, 9 Oct 2020 11:50:56 +0100 From: Szabolcs Nagy To: Florian Weimer Cc: Szabolcs Nagy via Libc-alpha Subject: Re: [PATCH 16/28] elf: Add glibc-hwcaps support for LD_LIBRARY_PATH Message-ID: <20201009105056.GR29000@arm.com> References: <47cb6998ed91f70f122de115b2e03ea5e82e5884.1601569371.git.fweimer@redhat.com> <20201008101305.GP29000@arm.com> <87ft6ndavy.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ft6ndavy.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: LO2P265CA0057.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::21) To PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.54) by LO2P265CA0057.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21 via Frontend Transport; Fri, 9 Oct 2020 10:50:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6006c4b7-b670-46a1-3bca-08d86c413938 X-MS-TrafficTypeDiagnostic: PR3PR08MB5658:|AM6PR08MB4008: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: o21KbEKoQjkgzfP8t7YjhAndPT565uKqSwbE5rezRI69g12uY0PFfPyPmPNRzp5R2TniKhPuO5D66Rcs2Nz8AHF9XGXSuXDcNw3H3M8fOHHozXXgXVAEFPM/GwPKkO+yiAPDWOfqK8LFEmXjQzq1r6KFKLNYcb2dJjEKfYxH0NTVfxxTdmbDDcLA+Eas7DufBtwlud6TpJQsiJCTTUYBUPWZXF302NgelVOmKnVAgtRhk4udpO8lmhXrGanDWJy3Y5iibKOX4cLNWZHl2kX5nlde+jEa6Dw/WdJZh/zQ85sIFITvHWIy8M5pSuXMZpSdGP5G70P5DJiiBSn7oFBGPA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5564.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(7696005)(86362001)(55016002)(5660300002)(1076003)(66556008)(6916009)(52116002)(66946007)(66476007)(4326008)(316002)(478600001)(36756003)(2616005)(44832011)(33656002)(956004)(6666004)(2906002)(8676002)(26005)(8936002)(16526019)(186003)(8886007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ifTVUpbvtlzjGmZSbQf2MwDFIgSU8aGEZabOv7oTruYb4/YfTFVJS8lXhQ6fm2Lf14PLwuQZ6r25IPo2dhgxtXvpz7hBIzie8lyZV/kW74DOYdp79AHXxgBp1lHnlA0VoZWCLSZaGY4jJYXun/m5CEx8vkCNtKlx7T1mnlnsUUH+3wDvsZGa5sbEFfEmcRkULgid73kr4j8XpbfgXIbg1rPdcwsF1J3cdqcMLCim3E1Q6f/Hpcz8I8GJoye/gFsbE4UZeV5fck/oYtZpvx3a4TNbkoIxAx3EQDd6MqkdLGC5heziG4GjANqqqY5gzNdH2hS/HsDUfZcZsnDOGHuwewppWzNlg0m7LB76PtAm2JQ4i1WvqfiEZYO1O2hHNZlSXbPVEWeZgc0a7OxsUt+QDsG8PBD03bHgkohowIQ9snHBrtS3otOipwKILiIdvzsAY7v4q9gfPrI/J+V9s7xqpDehRy5W+fGt4v95WIO0JfkD7YYEvOQ/QFXvKZDTz2eXvbUt76jk33ZaAwTMNMPLzuRSl9k0Mx5Ww2z1VFqJe17gLL3w+kJGj/C2aUUEPkrTKvebAgzd9MIsHLNDR0ITfaN2yewhNg0lfVx4OYCJ8GJx/EXWzag2r3a2H5R7202O5YHUVyhkvl6Qd7Hxny4DJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5658 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1923ae78-6174-4f91-8488-08d86c413510 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aLtMjQwAMR0jWQQrcNsIzele5LUZ0bRPSQgjgqg6BzIw7BOwOOgbjbyScEcFS65vMQhO69ZclY7ghlY0tTmIhD7l9ntGpZttlW1sHK5uVWfjzjLFuhUMylGEDgWc2gUm4FSIDTT1a5tfXlgGWlxdtEnhR9d0xjieF3Z2zHc3Of9AM1J/RYjrHzyBNwbanofRafQ34TmNXTwM0/P2mMLx3xbCFco260b0iTatAv8WJUD5gjBEquNUS83aS4DxLBDzH4jvrb2L79rhoTCevmrFMzW+VPDkaTY7B+b2AVbe+9usM/K8QMhiVRoeDaga+GrRDvjVPyLwoY6d7++jSImK38tX1K5GPWOir/EH2neWn6BlT30jn+bsE8Be5oIPGwwMTIKH16xm8x2TizMxDgunMQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966005)(186003)(2616005)(44832011)(8936002)(16526019)(86362001)(33656002)(81166007)(26005)(6862004)(2906002)(956004)(55016002)(356005)(336012)(1076003)(82740400003)(7696005)(8886007)(316002)(8676002)(6666004)(82310400003)(47076004)(4326008)(36756003)(70206006)(70586007)(5660300002)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2020 10:51:06.0496 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6006c4b7-b670-46a1-3bca-08d86c413938 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4008 X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 10:51:10 -0000 The 10/09/2020 11:08, Florian Weimer wrote: > * Szabolcs Nagy via Libc-alpha: > > The 10/01/2020 18:33, Florian Weimer via Libc-alpha wrote: > >> This hacks non-power-set processing into _dl_important_hwcaps. > >> Once the legacy hwcaps handling goes away, the subdirectory > >> handling needs to be reworked, but it is premature to do this > >> while both approaches are still supported. > > ... > >> +/* Returns a bitmap of active subdirectories in _dl_hwcaps_subdirs. > >> + Bit 0 (the LSB) corresponds to the first substring in > >> + _dl_hwcaps_subdirs, bit 1 to the second substring, and so on. > >> + There is no direct correspondence between HWCAP bitmasks and this > >> + bitmask. */ > >> +int32_t _dl_hwcaps_subdirs_active (void) attribute_hidden; > > > > if this returns a bitmask i would use uint32_t > > > > to avoid overflowing shifts and have 32bits available. > > I did this for alignment with _dl_hwcaps_split_masked_init, where it > would convenient to shift in one bits (so that -1 always means “all > ones”). But I guess I can turn this into a typedef and use an unsigned > type. -1 converted to uint32_t is "all ones" so i don't see a problem there. i don't think this should be a typedef (that hides important details about the type where it is used)