From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70044.outbound.protection.outlook.com [40.107.7.44]) by sourceware.org (Postfix) with ESMTPS id CAB153857C5F for ; Wed, 14 Oct 2020 15:10:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CAB153857C5F Received: from AM6P195CA0016.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::29) by VE1PR08MB4943.eurprd08.prod.outlook.com (2603:10a6:803:115::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Wed, 14 Oct 2020 15:10:18 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::67) by AM6P195CA0016.outlook.office365.com (2603:10a6:209:81::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 15:10:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 15:10:18 +0000 Received: ("Tessian outbound c189680f801b:v64"); Wed, 14 Oct 2020 15:10:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0d9783db12f9168a X-CR-MTA-TID: 64aa7808 Received: from ae743e410526.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 395EF49F-D4A0-4A61-B03D-9773C7787D7C.1; Wed, 14 Oct 2020 15:10:02 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ae743e410526.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 14 Oct 2020 15:10:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VUDTHO1Nz+GtRn4Ed1wgU4m2zz1M1UUMfeMy/vOONj1BKeiBD5ULBrJ82d954ad2iPIex2hqFJuhB+FlTFjmHVcy9GDwit+/5kYlt9vMqsUih3RfPlukmsifGfCFfKO55Phzih1Wp7xMv04bSp2eEFMIvhjhhVRdpHTu6MWahsVd/mj7gR8JH+nwNEGXWEdjgtNBdyq7GLFeBspczcYXfxrhQ3T9nN5rHL5yS6c18L3fx/JJL87Ks7DTVNhRIVeExtB6twuqjjzEcsBp+AbujnxCBS95f2rzjR7HRIjNkdXqz+hruj4hWQEr+9yzBwG9ksP20MbYGg3kXYIKMBItEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnxHAF08QrkQ+ohxrfxmhwTeNXWlAGQWZlMh0bk8l8s=; b=OgmpqpiUKB8VZV2EkIl+7mGsvssVjQ5RYHnRdQnI/meOoRVJQeZKO7G/2YeavnznOeqgK3Kt/tQjwWlS5m+wMl7xKRwdF6Syal/LTbNW/eCcgyqBu3Wyz2e0gW9Ry0d7lC45nvKIqH5WjUmO2E26BOXjkH21hVddtX2R9qqM8fkwYCbulEOZcu2dM0CDHUScYJFNPEVmLHPznRwBnfu0VEX5eRaBYEHAVVvVIQiC49eFqja43nE35TasHJrWhNGqs+57vlFNokBvcuB9oHqaNG1AwA9F2IevgM78EfUVMFdQbJIUN1gJxQLT/lpFpYdtE+BG29H55x8q9gL0y085YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) by PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Wed, 14 Oct 2020 15:10:01 +0000 Received: from PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::957e:c80e:98f4:23d6]) by PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::957e:c80e:98f4:23d6%6]) with mapi id 15.20.3477.021; Wed, 14 Oct 2020 15:09:59 +0000 Date: Wed, 14 Oct 2020 16:09:51 +0100 From: Szabolcs Nagy To: Florian Weimer Cc: Adhemerval Zanella , Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 20/28] aarch64: Add glibc-hwcaps support Message-ID: <20201014150951.GG3819@arm.com> References: <90b5f27a-9da8-76b0-b12d-907dcd7f7c0c@linaro.org> <87r1q0oq6j.fsf@oldenburg2.str.redhat.com> <3a7b2533-e6c7-5ded-2d94-b1b5c41de424@linaro.org> <20201014143750.GF3819@arm.com> <87imbcooiw.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87imbcooiw.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: DM6PR08CA0032.namprd08.prod.outlook.com (2603:10b6:5:80::45) To PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.54) by DM6PR08CA0032.namprd08.prod.outlook.com (2603:10b6:5:80::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 15:09:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f91711f0-3476-43cf-cbcd-08d8705342f7 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:|VE1PR08MB4943: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: l1pRLNh1YDNqiGWLxLKzNExgSybcMm3oqahxbbUQcgPPHSfUceVTDi7X7SWFVd0EvtH2sohlDlD2eOf5UM0ZhP+iynGevJlQTpfCdhZnrIh9PVFR+lLjIbRCL0TYLovsyHdsda+Y9WGj296AJfd22mdp3z/m/5xTYx9pLkBkRSAunzC16RKFjkLhZ8WncZBLKW1G0Yd/74+u7/pkMYANuJ7XzIml2A2j7ionwHwryNGwRcnYrdnKJimy5pkswoce+PFIaDMkvw9bi0R2luN4fkUZf0zdNelvrnrbQobidj4MaTztpnYcy3/E2dKIGbg84uwO2MK3sZ8ygG35TpDsZQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5564.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(53546011)(6666004)(8676002)(186003)(956004)(16526019)(8886007)(2616005)(66476007)(6916009)(26005)(66946007)(66556008)(2906002)(33656002)(8936002)(36756003)(316002)(4326008)(5660300002)(83380400001)(7696005)(55016002)(478600001)(44832011)(52116002)(54906003)(86362001)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: t3F6P0lUHmg+ziX7/Wt2C8chKffE24icbt1eMddPzONBwF/M2+19FL6OckMjmLmkGA9Lb0+qTvCjjmOhinobAU5fwcMIAZoRhdpg34Q4qVDajL1DVrqHNN9txpMyX1uzpykF7hfGAhaiTC7PN1ghMLOmee/5g4ZUIuwazncrksgUM69v5XnG13iVkzqZwgKmyQ4imVEcGOaeW4b+LzV+B5CoaS8NKT4WxPfsoj+fBTLpZnwb9xYU+L+Nkr7J+ajeox1Zq6hAxEEFKm9U5A95V02wK5USLQTQ0A7KWPZoW8D1A01gZyMvTFWDlnIwH3/Ro4ftmp1LpC7Hccv6J0pXLPo4PZCogkpt8rsoA1CBGYf+gkFNX15AUGr7F32RQxy+4p+AD2REjVMvWpF/DY2myvheazXoct0mfRzgPE6zTl8YaZZvfZSCRwrx7tvvwfzforhKOeB2H5LtjFVU9gcUBDOg+HbGhyP+JNeuWBj8LHlwhHnQddZbd8zZfG3ux6bPm4AONnU4hynROqWi7YFVCyRXbSSDU7lMDgDNlANf/da/jzHsP+hul0wXE8xio6TtLrVUgoBoe9QSiD3UNhKA05Jp0mpXyE92f2XE+skvmsI3cXQ4ik32I1SBCcZk/AlJAEs0Ampm3Llijfr+5tJf2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5852 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2fc90a41-916a-486d-f2e7-08d8705337cc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yIsSvpP5DBOWdcdBCzFh/z1jp0P/E80O7t28BSNve77q+25PWpsOzMw4XzCftyngltN+wchApOhqmfpu/jND4HfzXU7rjtyNJEHDlVa+O95RnWvIY3qCxvtlfnFi3q4O9S46TikjJZ2rnKueKzUb71jsiZdcXzP84rcTEorYugR7fFR24tvg0QnqFJjOEwQaue/QMkGoCY6rLzqS62iwk5p0wntU2JfXSXv2N/9HnraBhOtjD4C32h22SD0d2ZrxtrgToPpZiEXrnkdFfyPluKEOz/TCNAoIJBDPUZJ46DTjvTIwH2YR9ZQJA83x0qOrBUw/DLg2pBv5qC6+VbDDv+P4H2/O1yHWY3nT4LbbBNsUN95ShMiWKKmA31fOF81kSKUHyeMvjuFF8xuGsuTztQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(39860400002)(136003)(46966005)(44832011)(8676002)(1076003)(82310400003)(54906003)(82740400003)(55016002)(316002)(47076004)(2906002)(5660300002)(36756003)(956004)(8886007)(36906005)(86362001)(70206006)(70586007)(6666004)(2616005)(33656002)(356005)(81166007)(7696005)(8936002)(336012)(83380400001)(4326008)(16526019)(6862004)(53546011)(26005)(186003)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2020 15:10:18.0258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f91711f0-3476-43cf-cbcd-08d8705342f7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4943 X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 15:10:23 -0000 The 10/14/2020 16:44, Florian Weimer wrote: > * Szabolcs Nagy: > > > The 10/14/2020 11:15, Adhemerval Zanella via Libc-alpha wrote: > >> On 14/10/2020 11:08, Florian Weimer wrote: > >> > * Adhemerval Zanella via Libc-alpha: > >> >> On 01/10/2020 13:33, Florian Weimer via Libc-alpha wrote: > >> >>> At this point, only the "atomics" subdirectory is available, > >> >>> for libraries built using LSE atomics. > >> >> > >> >> LGTM, thanks. > >> >> > >> >> Reviewed-by: Adhemerval Zanella > >> > > >> > Thanks. I didn't want to skip AArch64, but it's really more of a stub > >> > implementation: > >> > > >> >>> +const char _dl_hwcaps_subdirs[] = "atomics"; > >> > > >> > Does this still make sense with GCC defaulting to -moutline-atomics for > >> > ARMv8a? That's what I wonder. > >> > > >> > Eventually, we need to define some levels for AArch64, and I'm not sure > >> > to what extent they would align with the official 8.X versions. To me, > >> > they look more like a bouquet you can choose from. > >> > >> I am not sure how ARM maintainers would like to handle it, either by > >> defining based on ARMv8.x revisions, a subsets of HWCAP capabilities, > >> or by not defining anything. > >> > >> For now I think the atomic makes sense because of -moutline-atomics, > >> although it is essentially ARMv8.1. > > > > the atomics path logic was added in glibc 2.28 in > > commit 397c54c1afa531242602fe3ac7bb47eff0e909f9 > > (see the reasoning in the commit message). > > > > since then this is public api that users may rely > > on (although likely there are not many users..) > > > > so i dont want to remove it (and yes it's not > > very helpful now that outline-atomics is the > > default in gcc). > > This patch adds glibc-hwcaps/atomics as a new subdirectory. The whole > series does not remove the legacy directories. > > Based on what you wrote, I should drop this patch, right? ah i missed that legacy is handled independently. in that case, yes please drop this.