From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 5A0C43857C46 for ; Wed, 14 Oct 2020 15:34:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5A0C43857C46 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CBGg71v0Kz1rsXY; Wed, 14 Oct 2020 17:34:27 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CBGg70Ghtz1qvgQ; Wed, 14 Oct 2020 17:34:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id KHOXw3Fo3rDd; Wed, 14 Oct 2020 17:34:25 +0200 (CEST) X-Auth-Info: Tyn3Rcsd6u1MDTp5up+b/QXnv5lDqjq31dnpIiazZ+I= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 14 Oct 2020 17:34:24 +0200 (CEST) Date: Wed, 14 Oct 2020 17:33:47 +0200 From: Lukasz Majewski To: Andreas Schwab Cc: Adhemerval Zanella , Joseph Myers , Paul Eggert , Alistair Francis , Arnd Bergmann , Alistair Francis , GNU C Library , Florian Weimer , Carlos O'Donell , Stepan Golosunov , Zack Weinberg Subject: Re: [PATCH] y2038: Reorder placement of st_ino in struct __stat64_t64 Message-ID: <20201014173347.0ce15e1e@jawa> In-Reply-To: <87sgagsxb0.fsf@igel.home> References: <20201014130051.9960-1-lukma@denx.de> <3bd2f455-a49c-2230-d06b-d67c3c341910@linaro.org> <20201014161428.76862be4@jawa> <87sgagsxb0.fsf@igel.home> Organization: denx.de X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_//Xa43Me/IAB1T7NY.YNxPJm"; protocol="application/pgp-signature" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 15:34:33 -0000 --Sig_//Xa43Me/IAB1T7NY.YNxPJm Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andreas, > On Okt 14 2020, Lukasz Majewski wrote: >=20 > > Hi Adhemerval, > > =20 > >> On 14/10/2020 10:00, Lukasz Majewski wrote: =20 > >> > In the installed struct stat{64} the __ino64_t st_ino member is > >> > placed in the end. This patch moves it to the same position as in > >> > the aforementioned, exported structures as it allows less #ifdefs > >> > for __USE_TIME_BITS64 support use case. =20 > >>=20 > >> Why exactly this is required? Afaik this is glibc defined type not > >> currently only used internally and all member accesses are set > >> directly (no use or memcpy or offsetof). Is this related to the > >> issue you saw on the arm environment? =20 > > > > This is required to make the minimal changes to provide > > -D_TIME_SIZE=3D64 support for {f}stat{at} as in: > > https://github.com/lmajewski/y2038_glibc/commit/26aa2ac07246682a505d85d= ac1c269689964b79b > > =20 >=20 > Why can't you just change the type of st_ino in struct stat? I'm not sure I get your idea. Could you be more specific? >=20 > Andreas. >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_//Xa43Me/IAB1T7NY.YNxPJm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl+HGlsACgkQAR8vZIA0 zr27qggA2pKBtzslbfloAFjsoFV9CJZj23ClQI4zYDdraWFMwbYP9UiYDGElBQb4 SyBLXEcKLkgrCcz0c35Lz5LKVt8n7AUpCeDj365ZhFqQOBBFnbVs1vE5MQrCPqvo W2diIK2vsGVdvp6eaUQOZm3cYC7mMPzOccxnM6Ykp9hxVBIpc0TECFMEj5x0qDM5 7qYuJSYDgCs3QH+5OkhpFk6+gfKNegWWuJB3oJaaKYs8wTX39XZNgjTupHrHomB2 7DxBNe2vsbVDCACUwA6nMncSbYGzjsKgk8i8r0ltQY1ChVtbfphdMuPGlGJby1Gc fKquXtKYqdg0kejmefDyNoebA37I3A== =kxEu -----END PGP SIGNATURE----- --Sig_//Xa43Me/IAB1T7NY.YNxPJm--