* [hurd, commited] bsd unlockpt: unlockpt needs to fail with EINVAL, not ENOTTY
@ 2020-11-08 14:11 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2020-11-08 14:11 UTC (permalink / raw)
To: libc-alpha; +Cc: Samuel Thibault, commit-hurd
The EINVAL error code is mandated by POSIX, while ptsname_r returns
ENOTTY, so we need to translate.
---
sysdeps/unix/bsd/unlockpt.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/bsd/unlockpt.c b/sysdeps/unix/bsd/unlockpt.c
index d8b7f0cae7..e609685c2f 100644
--- a/sysdeps/unix/bsd/unlockpt.c
+++ b/sysdeps/unix/bsd/unlockpt.c
@@ -20,6 +20,7 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
+#include <errno.h>
/* Unlock the slave pseudo terminal associated with the master pseudo
@@ -31,6 +32,10 @@ unlockpt (int fd)
/* BSD doesn't have a lock, but it does have `revoke'. */
if (__ptsname_r (fd, buf, sizeof (buf)))
- return -1;
+ {
+ if (errno == ENOTTY)
+ __set_errno (EINVAL);
+ return -1;
+ }
return __revoke (buf);
}
--
2.28.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-08 14:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-08 14:11 [hurd, commited] bsd unlockpt: unlockpt needs to fail with EINVAL, not ENOTTY Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).