From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] aarch64: Add unwind information to _start (bug 26853)
Date: Mon, 9 Nov 2020 11:58:14 +0000 [thread overview]
Message-ID: <20201109115814.GE17347@arm.com> (raw)
In-Reply-To: <87ft5issb2.fsf@oldenburg2.str.redhat.com>
The 11/09/2020 12:06, Florian Weimer via Libc-alpha wrote:
> This adds CFI directives which communicate that the stack ends
> with this function.
>
> Fixes bug 26853.
this looks good.
thanks.
>
> ---
> sysdeps/aarch64/start.S | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sysdeps/aarch64/start.S b/sysdeps/aarch64/start.S
> index 75393e1c18..108f602721 100644
> --- a/sysdeps/aarch64/start.S
> +++ b/sysdeps/aarch64/start.S
> @@ -43,11 +43,9 @@
> */
>
> .text
> - .globl _start
> - .type _start,#function
> -_start:
> - BTI_C
> +ENTRY(_start)
> /* Create an initial frame with 0 LR and FP */
> + cfi_undefined (x30)
> mov x29, #0
> mov x30, #0
>
> @@ -103,6 +101,7 @@ _start:
> __wrap_main:
> b main
> #endif
> +END(_start)
>
> /* Define a symbol for the first piece of initialized data. */
> .data
>
> --
> Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
>
prev parent reply other threads:[~2020-11-09 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 11:06 Florian Weimer
2020-11-09 11:18 ` Siddhesh Poyarekar
2020-11-09 11:58 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109115814.GE17347@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).