From: "Dan Horák" <dan@danny.cz>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v4 00/11] glibc-hwcaps support
Date: Mon, 9 Nov 2020 22:56:25 +0100 [thread overview]
Message-ID: <20201109225625.656262480e4041b15bdb42c6@danny.cz> (raw)
In-Reply-To: <cover.1604946656.git.fweimer@redhat.com>
On Mon, 09 Nov 2020 19:40:10 +0100
Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> wrote:
> This patch series incorporates Adhemerval's feedback. It picks up the
> suggestion for introducing enum opt_format in ldconfig.
>
> It also fixes a a ldconfig bug (wrong size in xmalloc call) uncovered by
> testing on i686-linux-gnu.
>
> I have dropped the s390x patch until I have located a suitable machine
> on which to test it. We also need to discuss how to achieve GCC
> alignment there.
Florian, what kind of machine do you need?
Dan
> Patch order is different than before because both the x86_64 and
> powerpc64le patches contain tests now, including a test that runs the
> ld.so-based test without special options in the container, to check for
> ld.so.cache support.
>
> The powerpc64le patch aligns the subdirectory selection with GCC.
>
> I feel like this series has a reasonable level of test coverage. It
> does not test all possible permutations (ld.so option combinations and
> ld.so.cache contents), but I hope that's okay.
>
> (Not sure if this actually v4, I sort of lost count.)
>
> Thanks,
> Florian
>
> Florian Weimer (11):
> support: Add support_copy_file
> elf: Introduce enum opt_format in the ldconfig implementation
> elf: Add glibc-hwcaps support for LD_LIBRARY_PATH
> elf: Add endianness markup to ld.so.cache
> elf: Add extension mechanism to ld.so.cache
> elf: Implement a string table for ldconfig, with tail merging
> elf: Implement tail merging of strings in ldconfig
> elf: Process glibc-hwcaps subdirectories in ldconfig
> elf: Add glibc-hwcaps subdirectory support to ld.so cache processing
> x86_64: Add glibc-hwcaps support
> powerpc64le: Add glibc-hwcaps support
>
> elf/Makefile | 90 +++-
> elf/cache.c | 413 +++++++++++++++---
> elf/dl-cache.c | 202 ++++++++-
> elf/dl-hwcaps-subdirs.c | 29 ++
> elf/dl-hwcaps.c | 216 ++++++++-
> elf/dl-hwcaps.h | 124 ++++++
> elf/dl-hwcaps_split.c | 77 ++++
> elf/dl-load.c | 7 +-
> elf/dl-main.h | 11 +-
> elf/dl-support.c | 5 +-
> elf/dl-usage.c | 68 ++-
> elf/ldconfig.c | 164 +++++--
> elf/markermodMARKER-VALUE.c | 29 ++
> elf/rtld.c | 18 +
> elf/stringtable.c | 209 +++++++++
> elf/stringtable.h | 64 +++
> elf/stringtable_free.c | 33 ++
> elf/tst-dl-hwcaps_split.c | 139 ++++++
> elf/tst-glibc-hwcaps-cache.c | 45 ++
> .../etc/ld.so.conf | 2 +
> elf/tst-glibc-hwcaps-cache.root/postclean.req | 0
> elf/tst-glibc-hwcaps-cache.script | 18 +
> elf/tst-glibc-hwcaps-mask.c | 31 ++
> elf/tst-glibc-hwcaps-prepend-cache.c | 133 ++++++
> .../postclean.req | 0
> elf/tst-glibc-hwcaps-prepend.c | 32 ++
> elf/tst-glibc-hwcaps.c | 28 ++
> elf/tst-stringtable.c | 141 ++++++
> support/Makefile | 1 +
> support/support.h | 5 +
> support/support_copy_file.c | 43 ++
> sysdeps/generic/dl-cache.h | 233 +++++++++-
> sysdeps/generic/ldconfig.h | 27 +-
> sysdeps/generic/ldsodefs.h | 20 +-
> sysdeps/powerpc/powerpc64/le/Makefile | 28 ++
> .../powerpc/powerpc64/le/dl-hwcaps-subdirs.c | 46 ++
> .../powerpc/powerpc64/le/tst-glibc-hwcaps.c | 54 +++
> sysdeps/x86_64/Makefile | 39 ++
> sysdeps/x86_64/dl-hwcaps-subdirs.c | 66 +++
> sysdeps/x86_64/tst-glibc-hwcaps.c | 76 ++++
> 40 files changed, 2839 insertions(+), 127 deletions(-)
> create mode 100644 elf/dl-hwcaps-subdirs.c
> create mode 100644 elf/dl-hwcaps_split.c
> create mode 100644 elf/markermodMARKER-VALUE.c
> create mode 100644 elf/stringtable.c
> create mode 100644 elf/stringtable.h
> create mode 100644 elf/stringtable_free.c
> create mode 100644 elf/tst-dl-hwcaps_split.c
> create mode 100644 elf/tst-glibc-hwcaps-cache.c
> create mode 100644 elf/tst-glibc-hwcaps-cache.root/etc/ld.so.conf
> create mode 100644 elf/tst-glibc-hwcaps-cache.root/postclean.req
> create mode 100644 elf/tst-glibc-hwcaps-cache.script
> create mode 100644 elf/tst-glibc-hwcaps-mask.c
> create mode 100644 elf/tst-glibc-hwcaps-prepend-cache.c
> create mode 100644 elf/tst-glibc-hwcaps-prepend-cache.root/postclean.req
> create mode 100644 elf/tst-glibc-hwcaps-prepend.c
> create mode 100644 elf/tst-glibc-hwcaps.c
> create mode 100644 elf/tst-stringtable.c
> create mode 100644 support/support_copy_file.c
> create mode 100644 sysdeps/powerpc/powerpc64/le/dl-hwcaps-subdirs.c
> create mode 100644 sysdeps/powerpc/powerpc64/le/tst-glibc-hwcaps.c
> create mode 100644 sysdeps/x86_64/dl-hwcaps-subdirs.c
> create mode 100644 sysdeps/x86_64/tst-glibc-hwcaps.c
>
> --
> Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
>
next prev parent reply other threads:[~2020-11-09 21:56 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 18:40 Florian Weimer
2020-11-09 18:40 ` [PATCH 01/11] support: Add support_copy_file Florian Weimer
2020-11-26 16:43 ` Adhemerval Zanella
2020-11-26 17:22 ` Florian Weimer
2020-11-09 18:40 ` [PATCH 02/11] elf: Introduce enum opt_format in the ldconfig implementation Florian Weimer
2020-11-26 16:44 ` Adhemerval Zanella
2020-11-26 18:54 ` [PATCH 12/11] s390x: Add Add glibc-hwcaps support Florian Weimer
2020-12-07 8:16 ` Florian Weimer
2020-12-08 15:47 ` Stefan Liebler
2020-12-09 18:52 ` Florian Weimer
2020-12-10 10:22 ` Stefan Liebler
2020-12-10 14:54 ` Florian Weimer
2020-11-09 18:40 ` [PATCH 03/11] elf: Add glibc-hwcaps support for LD_LIBRARY_PATH Florian Weimer
2020-11-26 20:29 ` Adhemerval Zanella
2020-11-27 19:49 ` Florian Weimer
2020-11-30 18:59 ` Adhemerval Zanella
2020-12-04 12:25 ` Matheus Castanho
2020-12-04 12:43 ` Florian Weimer
2020-12-04 12:59 ` Matheus Castanho
2020-11-09 18:40 ` [PATCH 04/11] elf: Add endianness markup to ld.so.cache Florian Weimer
2020-11-27 13:56 ` Adhemerval Zanella
2020-11-27 19:49 ` Florian Weimer
2020-11-30 19:00 ` Adhemerval Zanella
2020-11-09 18:40 ` [PATCH 05/11] elf: Add extension mechanism " Florian Weimer
2020-11-27 18:01 ` Adhemerval Zanella
2020-11-27 18:55 ` Florian Weimer
2020-11-27 18:56 ` Adhemerval Zanella
2020-11-09 18:40 ` [PATCH 06/11] elf: Implement a string table for ldconfig, with tail merging Florian Weimer
2020-11-27 19:29 ` Adhemerval Zanella
2020-11-27 19:49 ` Florian Weimer
2020-11-30 19:01 ` Adhemerval Zanella
2020-11-09 18:41 ` [PATCH 07/11] elf: Implement tail merging of strings in ldconfig Florian Weimer
2020-11-30 18:41 ` Adhemerval Zanella
2020-12-01 10:28 ` Florian Weimer
2020-11-09 18:41 ` [PATCH 08/11] elf: Process glibc-hwcaps subdirectories " Florian Weimer
2020-11-30 19:46 ` Adhemerval Zanella
2020-11-09 18:41 ` [PATCH 09/11] elf: Add glibc-hwcaps subdirectory support to ld.so cache processing Florian Weimer
2020-11-26 17:11 ` Florian Weimer
2020-12-01 17:45 ` Adhemerval Zanella
2020-12-01 20:45 ` Florian Weimer
2020-12-02 12:08 ` Adhemerval Zanella
2020-12-02 12:16 ` Florian Weimer
2020-11-09 18:41 ` [PATCH 10/11] x86_64: Add glibc-hwcaps support Florian Weimer
2020-12-02 12:49 ` Adhemerval Zanella
2020-11-09 18:41 ` [PATCH 11/11] powerpc64le: " Florian Weimer
2020-12-02 13:46 ` Adhemerval Zanella
2020-12-02 13:51 ` Florian Weimer
2020-12-02 14:27 ` Adhemerval Zanella
2020-12-02 14:31 ` Florian Weimer
2020-12-02 15:34 ` Carlos Seo
2020-12-02 20:14 ` Tulio Magno Quites Machado Filho
2020-12-04 8:56 ` Florian Weimer
2020-12-04 12:35 ` Adhemerval Zanella
2020-11-09 21:56 ` Dan Horák [this message]
2020-11-10 10:41 ` [PATCH v4 00/11] " Florian Weimer
2020-11-25 15:46 ` Florian Weimer
2020-11-25 15:58 ` H.J. Lu
2020-11-25 17:20 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109225625.656262480e4041b15bdb42c6@danny.cz \
--to=dan@danny.cz \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).