From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
Siddhesh Poyarekar <siddhesh@redhat.com>,
Andreas Schwab <schwab@suse.de>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [RFC 2/6] y2038: stat: {f}stat{at}64_time64 redirection to be used on Y2038 systems
Date: Mon, 7 Dec 2020 11:28:50 +0100 [thread overview]
Message-ID: <20201207112850.76f227df@jawa> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2012050002030.240600@digraph.polyomino.org.uk>
[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]
Hi Joseph,
> On Sat, 5 Dec 2020, Lukasz Majewski wrote:
>
> > --- a/io/Versions
> > +++ b/io/Versions
> > @@ -148,5 +148,9 @@ libc {
> > __fstat64;
> > __ppoll64;
> > __utime64;
> > + __stat64_time64;
> > + __fstat64_time64;
> > + __lstat64_time64;
> > + __fstatat64_time64;
>
> This is adding to GLIBC_PRIVATE.
This shall be added to GLIBC_2.3X.
>
> > --- a/io/sys/stat.h
> > +++ b/io/sys/stat.h
> > @@ -210,20 +210,45 @@ extern int stat (const char *__restrict
> > __file, extern int fstat (int __fd, struct stat *__buf) __THROW
> > __nonnull ((2)); #else
> > # ifdef __REDIRECT_NTH
> > +# ifdef __USE_TIME_BITS64
> > +extern int __REDIRECT_NTH (stat, (const char *__restrict __file,
> > + struct stat *__restrict __buf),
> > + __stat64_time64) __nonnull ((1, 2));
> > +extern int __REDIRECT_NTH (fstat, (int __fd, struct stat *__buf),
> > + __fstat64_time64) __nonnull ((2));
>
> And this is changing an installed header.
>
> An installed header should never reference a GLIBC_PRIVATE symbol.
A side question:
Is my understanding correct that GLIBC_PRIVATE symbols are only for
cross libraries reference? For example such symbol from glibc could be
referenced in librt?
> The commit that adds a redirection to a new symbol for 64-bit time_t
> must either be the same commit that adds that symbol to a *public*
> symbol version, or a subsequent commit. The commit adding it to a
> public symbol version must be the same commit that updates all
> relevant ABI test baselines so that ABI tests pass after every commit.
>
> The same comments apply to other patches in this series.
>
This commit shall be squashed with the first one - I just defer to do
this as there are still some issues with 'stat{x}'.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-07 10:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 23:35 [RFC 0/6] y2038: Prepare glibc to be Y2038 safe for 32 bit ports Lukasz Majewski
2020-12-04 23:35 ` [RFC 1/6] y2038: Introduce _TIME_BITS flag to support 64 bit time on 32 bit systems Lukasz Majewski
2020-12-05 0:12 ` Joseph Myers
2020-12-07 13:00 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 2/6] y2038: stat: {f}stat{at}64_time64 redirection to be used on Y2038 systems Lukasz Majewski
2020-12-05 0:04 ` Joseph Myers
2020-12-07 10:28 ` Lukasz Majewski [this message]
2020-12-07 18:07 ` Joseph Myers
2020-12-04 23:36 ` [RFC 3/6] y2038: Export struct_stat_time64_helper.h with Y2038 safe stat{64} content Lukasz Majewski
2020-12-29 10:30 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 4/6] y2038: Enhance struct msqid_ds to support 64 bit time Lukasz Majewski
2020-12-29 10:34 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 5/6] msqid: Provide internal copy of struct __msqid64_ds Lukasz Majewski
2020-12-29 10:54 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 6/6] msg: provide glibc local copy of struct msqid_ds Lukasz Majewski
2020-12-05 0:01 ` [RFC 0/6] y2038: Prepare glibc to be Y2038 safe for 32 bit ports Joseph Myers
2020-12-07 10:22 ` Lukasz Majewski
2020-12-07 18:01 ` Joseph Myers
2020-12-08 10:07 ` Lukasz Majewski
2020-12-08 15:25 ` Joseph Myers
2020-12-13 11:49 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207112850.76f227df@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=siddhesh@redhat.com \
--cc=stepan@golosunov.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).