Hi Joseph,

> On Sat, 5 Dec 2020, Lukasz Majewski wrote:
> 
> > --- a/io/Versions
> > +++ b/io/Versions
> > @@ -148,5 +148,9 @@ libc {
> >      __fstat64;
> >      __ppoll64;
> >      __utime64;
> > +    __stat64_time64;
> > +    __fstat64_time64;
> > +    __lstat64_time64;
> > +    __fstatat64_time64;  
> 
> This is adding to GLIBC_PRIVATE.

This shall be added to GLIBC_2.3X.

> 
> > --- a/io/sys/stat.h
> > +++ b/io/sys/stat.h
> > @@ -210,20 +210,45 @@ extern int stat (const char *__restrict
> > __file, extern int fstat (int __fd, struct stat *__buf) __THROW
> > __nonnull ((2)); #else
> >  # ifdef __REDIRECT_NTH
> > +#  ifdef __USE_TIME_BITS64
> > +extern int __REDIRECT_NTH (stat, (const char *__restrict __file,
> > +                                    struct stat *__restrict __buf),
> > +                           __stat64_time64) __nonnull ((1, 2));
> > +extern int __REDIRECT_NTH (fstat, (int __fd, struct stat *__buf),
> > +                           __fstat64_time64) __nonnull ((2));  
> 
> And this is changing an installed header.
> 
> An installed header should never reference a GLIBC_PRIVATE symbol.

A side question:

Is my understanding correct that GLIBC_PRIVATE symbols are only for
cross libraries reference? For example such symbol from glibc could be
referenced in librt?

> The commit that adds a redirection to a new symbol for 64-bit time_t
> must either be the same commit that adds that symbol to a *public*
> symbol version, or a subsequent commit.  The commit adding it to a
> public symbol version must be the same commit that updates all
> relevant ABI test baselines so that ABI tests pass after every commit.
> 
> The same comments apply to other patches in this series.
> 

This commit shall be squashed with the first one - I just defer to do
this as there are still some issues with 'stat{x}'.



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de