From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D19BB3865483 for ; Tue, 15 Dec 2020 11:34:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D19BB3865483 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-Dvdv0BIIPne9tM4bcj5FSg-1; Tue, 15 Dec 2020 06:33:59 -0500 X-MC-Unique: Dvdv0BIIPne9tM4bcj5FSg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AE40A180A095; Tue, 15 Dec 2020 11:33:58 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-11.ams2.redhat.com [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5781B5D9CA; Tue, 15 Dec 2020 11:33:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 0BFBXuud3650128 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Dec 2020 12:33:56 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 0BFBXttw3650127; Tue, 15 Dec 2020 12:33:55 +0100 Date: Tue, 15 Dec 2020 12:33:55 +0100 From: Jakub Jelinek To: Florian Weimer Cc: Siddhesh Poyarekar via Libc-alpha , Siddhesh Poyarekar Subject: Re: [PATCH 2/2] nonstring: _FORTIFY_SOURCE=3 using __builtin_dynamic_object_size Message-ID: <20201215113355.GR3788@tucnak> Reply-To: Jakub Jelinek References: <20201210181327.1577769-1-siddhesh@sourceware.org> <20201210181327.1577769-3-siddhesh@sourceware.org> <87wnxj8g0a.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 In-Reply-To: <87wnxj8g0a.fsf@oldenburg2.str.redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 11:34:02 -0000 On Tue, Dec 15, 2020 at 12:28:53PM +0100, Florian Weimer wrote: > * Siddhesh Poyarekar via Libc-alpha: > > > diff --git a/libio/bits/stdio.h b/libio/bits/stdio.h > > index 6745571ed5..bdaef76811 100644 > > --- a/libio/bits/stdio.h > > +++ b/libio/bits/stdio.h > > @@ -31,7 +31,7 @@ > > > > > > #ifdef __USE_EXTERN_INLINES > > -/* For -D_FORTIFY_SOURCE{,=2} bits/stdio2.h will define a different > > +/* For -D_FORTIFY_SOURCE{,>=2} bits/stdio2.h will define a different > > inline. */ > > # if !(__USE_FORTIFY_LEVEL > 0 && defined __fortify_function) > > Presumably that's _FORTIFY_SOURCE >= 1? (Without -D). Either that, > or -D_FORTIFY_SOURCE{,=2,=3} . I think it should be -D_FORTIFY_SOURCE{,=2,=3} or -D_FORTIFY_SOURCE{,=1,=2,=3} or -D_FORTIFY_SOURCE{,=[123]} The brace expansion syntax certainly doesn't handle >=, so it would mean -D_FORTIFY_SOURCE -D_FORTIFY_SOURCE>=2 Jakub