From: "Vivek Das Mohapatra" <vivek@collabora.com>
To: libc-alpha <libc-alpha@sourceware.org>
Subject: [RFC][PATCH v6 20/20] Restore separate libc loading for the TLS/namespace storage test
Date: Tue, 15 Dec 2020 18:45:00 +0000 [thread overview]
Message-ID: <20201215184500.25915-21-vivek@collabora.com> (raw)
In-Reply-To: <20201215184500.25915-1-vivek@collabora.com>
tst-tls-ie-dlmopen checks to see that new namespaces consume
TLS memory as expected: This does not happen when new namespaces
share the same libc instance (since TLS is allocated only when
a new libc instance insitialises its threading infrastructure).
Adding RTLD_ISOLATE to the dlmopen flags in the test restores
the old behaviour which allows the test to check what it
actually needs to.
---
elf/tst-tls-ie-dlmopen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/elf/tst-tls-ie-dlmopen.c b/elf/tst-tls-ie-dlmopen.c
index c7b5c688e3..8ba24ce54d 100644
--- a/elf/tst-tls-ie-dlmopen.c
+++ b/elf/tst-tls-ie-dlmopen.c
@@ -53,7 +53,7 @@ static void *
load_and_access (Lmid_t lmid, const char *mod, const char *func)
{
/* Load module with TLS. */
- void *p = xdlmopen (lmid, mod, RTLD_NOW);
+ void *p = xdlmopen (lmid, mod, RTLD_NOW|RTLD_ISOLATE);
/* Access the TLS variable to ensure it is allocated. */
void (*f) (void) = (void (*) (void))xdlsym (p, func);
f ();
@@ -95,7 +95,7 @@ do_test (void)
than 1024 bytes are available (exact number depends on TLS optimizations
and the libc TLS use). */
printf ("The next dlmopen should fail...\n");
- void *p = dlmopen (LM_ID_BASE, "tst-tls-ie-mod4.so", RTLD_NOW);
+ void *p = dlmopen (LM_ID_BASE, "tst-tls-ie-mod4.so", RTLD_NOW|RTLD_ISOLATE);
if (p != NULL)
FAIL_EXIT1 ("error: expected dlmopen to fail because there is "
"not enough surplus static TLS.\n");
--
2.20.1
prev parent reply other threads:[~2020-12-15 18:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 18:44 [RFC][PATCH v6 00/20] Implementation of RTLD_SHARED for dlmopen Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 01/20] Declare and describe the dlmopen RTLD_SHARED flag Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 02/20] include/link.h: Update the link_map struct to allow proxies Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 03/20] elf/dl-object.c: Implement a helper function to proxy link_map entries Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 04/20] elf/dl-load.c, elf-dl-open.c: Implement RTLD_SHARED dlmopen proxying Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 05/20] elf/dl-fini.c: Handle proxy link_map entries in the shutdown path Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 06/20] elf/dl-init.c: Skip proxied link map entries in the dl init path Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 07/20] elf/dl-open.c: Don't try libc linit in namespaces with no libc mapping Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 08/20] elf/dl-open.c: when creating a proxy check the libc_map in NS 0 Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 09/20] Define a new dynamic section tag - DT_GNU_FLAGS_1 Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 10/20] Abstract the loaded-DSO search code into a private helper function Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 11/20] Compare loaded DSOs by file ID and check for DF_GNU_1_UNIQUE Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 12/20] Use the new DSO finder helper function since we have it Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 13/20] Use the DSO search helper to check for preloaded DT_GNU_UNIQUE DSOs Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 14/20] When loading DSOs into alternate namespaces check for DT_GNU_UNIQUE Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 15/20] Suppress audit calls when a (new) namespace is empty Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 16/20] Suppress inter-namespace DSO sharing for audit libraries Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 17/20] dlsym, dlvsym should be able to look up symbols via DSO proxies Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 18/20] Add DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE dynamic section+flag to glibc DSOs Vivek Das Mohapatra
2020-12-15 18:56 ` Samuel Thibault
2020-12-15 23:21 ` Vivek Das Mohapatra
2020-12-15 18:44 ` [RFC][PATCH v6 19/20] Add dlmopen / RTLD_SHARED tests Vivek Das Mohapatra
2020-12-15 18:45 ` Vivek Das Mohapatra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215184500.25915-21-vivek@collabora.com \
--to=vivek@collabora.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).