From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Andreas Schwab <schwab@suse.de>, Zack Weinberg <zackw@panix.com>,
Siddhesh Poyarekar <siddhesh@redhat.com>
Subject: Re: [RFC 4/6] y2038: Enhance struct msqid_ds to support 64 bit time
Date: Tue, 29 Dec 2020 11:34:22 +0100 [thread overview]
Message-ID: <20201229113422.0da02b4d@jawa> (raw)
In-Reply-To: <20201204233604.7430-5-lukma@denx.de>
[-- Attachment #1: Type: text/plain, Size: 7813 bytes --]
Dear Community,
> ---
> sysdeps/unix/sysv/linux/bits/types/struct_msqid_ds.h | 8 ++++++++
> .../sysv/linux/hppa/bits/types/struct_msqid_ds.h | 8 ++++++++
> .../sysv/linux/mips/bits/types/struct_msqid_ds.h | 12
> ++++++++++-- .../sysv/linux/powerpc/bits/types/struct_msqid_ds.h |
> 8 ++++++++ .../sysv/linux/sparc/bits/types/struct_msqid_ds.h | 8
> ++++++++ 5 files changed, 42 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/bits/types/struct_msqid_ds.h
> b/sysdeps/unix/sysv/linux/bits/types/struct_msqid_ds.h index
> 43b38175ad..6d8194991f 100644 ---
> a/sysdeps/unix/sysv/linux/bits/types/struct_msqid_ds.h +++
> b/sysdeps/unix/sysv/linux/bits/types/struct_msqid_ds.h @@ -20,18
> +20,26 @@ # error "Never use <bits/msq.h> directly; include
> <sys/msg.h> instead." #endif
>
Gentle request for feedback for this patch set.
> +#include <bits/types/time_t.h>
> +
> /* Structure of record for one message inside the kernel.
> The type `struct msg' is opaque. */
> struct msqid_ds
> {
> struct ipc_perm msg_perm; /* structure describing operation
> permission */ #if __TIMESIZE == 32
> +# if __USE_TIME_BITS64
> + __time64_t msg_stime; /* time of last msgsnd command */
> + __time64_t msg_rtime; /* time of last msgsnd command */
> + __time64_t msg_ctime; /* time of last change */
> +# else
> __time_t msg_stime; /* time of last msgsnd command
> */ unsigned long int __msg_stime_high;
> __time_t msg_rtime; /* time of last msgsnd command
> */ unsigned long int __msg_rtime_high;
> __time_t msg_ctime; /* time of last change */
> unsigned long int __msg_ctime_high;
> +# endif
> #else
> __time_t msg_stime; /* time of last msgsnd command
> */ __time_t msg_rtime; /* time of last msgsnd command
> */ diff --git
> a/sysdeps/unix/sysv/linux/hppa/bits/types/struct_msqid_ds.h
> b/sysdeps/unix/sysv/linux/hppa/bits/types/struct_msqid_ds.h index
> 16eac46941..08c5323f03 100644 ---
> a/sysdeps/unix/sysv/linux/hppa/bits/types/struct_msqid_ds.h +++
> b/sysdeps/unix/sysv/linux/hppa/bits/types/struct_msqid_ds.h @@ -20,18
> +20,26 @@ # error "Never use <bits/msq.h> directly; include
> <sys/msg.h> instead." #endif
> +#include <bits/types/time_t.h>
> +
> /* Structure of record for one message inside the kernel.
> The type `struct msg' is opaque. */
> struct msqid_ds
> {
> struct ipc_perm msg_perm; /* structure describing operation
> permission */ #if __TIMESIZE == 32
> +# if __USE_TIME_BITS64
> + __time64_t msg_stime; /* time of last msgsnd command */
> + __time64_t msg_rtime; /* time of last msgsnd command */
> + __time64_t msg_ctime; /* time of last change */
> +# else
> unsigned long int __msg_stime_high;
> __time_t msg_stime; /* time of last msgsnd command
> */ unsigned long int __msg_rtime_high;
> __time_t msg_rtime; /* time of last msgsnd command
> */ unsigned long int __msg_ctime_high;
> __time_t msg_ctime; /* time of last change */
> +# endif
> #else
> __time_t msg_stime; /* time of last msgsnd command
> */ __time_t msg_rtime; /* time of last msgsnd command
> */ diff --git
> a/sysdeps/unix/sysv/linux/mips/bits/types/struct_msqid_ds.h
> b/sysdeps/unix/sysv/linux/mips/bits/types/struct_msqid_ds.h index
> 513e01a171..ac077bfca8 100644 ---
> a/sysdeps/unix/sysv/linux/mips/bits/types/struct_msqid_ds.h +++
> b/sysdeps/unix/sysv/linux/mips/bits/types/struct_msqid_ds.h @@ -20,26
> +20,34 @@ # error "Never use <bits/msq.h> directly; include
> <sys/msg.h> instead." #endif
> +#include <bits/types/time_t.h>
> +
> /* Structure of record for one message inside the kernel.
> The type `struct msg' is opaque. */
> struct msqid_ds
> {
> struct ipc_perm msg_perm; /* structure describing operation
> permission */ #if __TIMESIZE == 32
> -# ifdef __MIPSEL__
> +# if __USE_TIME_BITS64
> + __time64_t msg_stime; /* time of last msgsnd command */
> + __time64_t msg_rtime; /* time of last msgsnd command */
> + __time64_t msg_ctime; /* time of last change */
> +# else
> +# ifdef __MIPSEL__
> __time_t msg_stime; /* time of last msgsnd command
> */ unsigned long int __msg_stime_high;
> __time_t msg_rtime; /* time of last msgsnd command
> */ unsigned long int __msg_rtime_high;
> __time_t msg_ctime; /* time of last change */
> unsigned long int __msg_ctime_high;
> -# else
> +# else
> unsigned long int __msg_stime_high;
> __time_t msg_stime; /* time of last msgsnd command
> */ unsigned long int __msg_rtime_high;
> __time_t msg_rtime; /* time of last msgsnd command
> */ unsigned long int __msg_ctime_high;
> __time_t msg_ctime; /* time of last change */
> +# endif
> # endif
> #else
> __time_t msg_stime; /* time of last msgsnd command
> */ diff --git
> a/sysdeps/unix/sysv/linux/powerpc/bits/types/struct_msqid_ds.h
> b/sysdeps/unix/sysv/linux/powerpc/bits/types/struct_msqid_ds.h index
> 35cc51f733..bf450c9605 100644 ---
> a/sysdeps/unix/sysv/linux/powerpc/bits/types/struct_msqid_ds.h +++
> b/sysdeps/unix/sysv/linux/powerpc/bits/types/struct_msqid_ds.h @@
> -20,18 +20,26 @@ # error "Never use <bits/msq.h> directly; include
> <sys/msg.h> instead." #endif
> +#include <bits/types/time_t.h>
> +
> /* Structure of record for one message inside the kernel.
> The type `struct msg' is opaque. */
> struct msqid_ds
> {
> struct ipc_perm msg_perm; /* structure describing operation
> permission */ #if __TIMESIZE == 32
> +# if __USE_TIME_BITS64
> + __time64_t msg_stime; /* time of last msgsnd command */
> + __time64_t msg_rtime; /* time of last msgsnd command */
> + __time64_t msg_ctime; /* time of last change */
> +# else
> unsigned long int __msg_stime_high;
> __time_t msg_stime; /* time of last msgsnd command
> */ unsigned long int __msg_rtime_high;
> __time_t msg_rtime; /* time of last msgsnd command
> */ unsigned long int __msg_ctime_high;
> __time_t msg_ctime; /* time of last change */
> +# endif
> #else
> __time_t msg_stime; /* time of last msgsnd command
> */ __time_t msg_rtime; /* time of last msgsnd command
> */ diff --git
> a/sysdeps/unix/sysv/linux/sparc/bits/types/struct_msqid_ds.h
> b/sysdeps/unix/sysv/linux/sparc/bits/types/struct_msqid_ds.h index
> 502c23d91e..a9e309dafc 100644 ---
> a/sysdeps/unix/sysv/linux/sparc/bits/types/struct_msqid_ds.h +++
> b/sysdeps/unix/sysv/linux/sparc/bits/types/struct_msqid_ds.h @@
> -20,18 +20,26 @@ # error "Never use <bits/msq.h> directly; include
> <sys/msg.h> instead." #endif
> +#include <bits/types/time_t.h>
> +
> /* Structure of record for one message inside the kernel.
> The type `struct msg' is opaque. */
> struct msqid_ds
> {
> struct ipc_perm msg_perm; /* structure describing operation
> permission */ #if __TIMESIZE == 32
> +# if __USE_TIME_BITS64
> + __time64_t msg_stime; /* time of last msgsnd command */
> + __time64_t msg_rtime; /* time of last msgsnd command */
> + __time64_t msg_ctime; /* time of last change */
> +# else
> unsigned long int __msg_stime_high;
> __time_t msg_stime; /* time of last msgsnd command
> */ unsigned long int __msg_rtime_high;
> __time_t msg_rtime; /* time of last msgsnd command
> */ unsigned long int __msg_ctime_high;
> __time_t msg_ctime; /* time of last change */
> +# endif
> #else
> __time_t msg_stime; /* time of last msgsnd command
> */ __time_t msg_rtime; /* time of last msgsnd command
> */
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-29 10:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 23:35 [RFC 0/6] y2038: Prepare glibc to be Y2038 safe for 32 bit ports Lukasz Majewski
2020-12-04 23:35 ` [RFC 1/6] y2038: Introduce _TIME_BITS flag to support 64 bit time on 32 bit systems Lukasz Majewski
2020-12-05 0:12 ` Joseph Myers
2020-12-07 13:00 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 2/6] y2038: stat: {f}stat{at}64_time64 redirection to be used on Y2038 systems Lukasz Majewski
2020-12-05 0:04 ` Joseph Myers
2020-12-07 10:28 ` Lukasz Majewski
2020-12-07 18:07 ` Joseph Myers
2020-12-04 23:36 ` [RFC 3/6] y2038: Export struct_stat_time64_helper.h with Y2038 safe stat{64} content Lukasz Majewski
2020-12-29 10:30 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 4/6] y2038: Enhance struct msqid_ds to support 64 bit time Lukasz Majewski
2020-12-29 10:34 ` Lukasz Majewski [this message]
2020-12-04 23:36 ` [RFC 5/6] msqid: Provide internal copy of struct __msqid64_ds Lukasz Majewski
2020-12-29 10:54 ` Lukasz Majewski
2020-12-04 23:36 ` [RFC 6/6] msg: provide glibc local copy of struct msqid_ds Lukasz Majewski
2020-12-05 0:01 ` [RFC 0/6] y2038: Prepare glibc to be Y2038 safe for 32 bit ports Joseph Myers
2020-12-07 10:22 ` Lukasz Majewski
2020-12-07 18:01 ` Joseph Myers
2020-12-08 10:07 ` Lukasz Majewski
2020-12-08 15:25 ` Joseph Myers
2020-12-13 11:49 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229113422.0da02b4d@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=siddhesh@redhat.com \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).