From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by sourceware.org (Postfix) with ESMTPS id 71700385780E for ; Tue, 5 Jan 2021 10:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71700385780E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=wangshuo47@huawei.com Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4D989y13v8z7PwC; Tue, 5 Jan 2021 18:39:02 +0800 (CST) Received: from huawei.com (10.174.176.87) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 5 Jan 2021 18:39:46 +0800 From: Shuo Wang To: , , CC: , Subject: [PATCH] aarch64: fix stack missing after sp is updated Date: Tue, 5 Jan 2021 18:39:35 +0800 Message-ID: <20210105103935.2820-1-wangshuo47@huawei.com> X-Mailer: git-send-email 2.19.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.174.176.87] X-CFilter-Loop: Reflected X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, PP_MIME_FAKE_ASCII_TEXT, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 10:40:08 -0000 Dear Szabolcs, The Signed-off-by in commit cd6274089f has not been removed before being merged, I was wondering if I am supposed to re-submit it？ Best regards, Shuo >please add 'aarch64: ' prefix to the subject. > >i think it's enough to have the before the fix gdb >session in the commit message. > >with those changes this is ok to commit. >(if you don't have commit rights then send >an updated patch and i'll commit it for you) > >> --- >> sysdeps/aarch64/dl-tlsdesc.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sysdeps/aarch64/dl-tlsdesc.S b/sysdeps/aarch64/dl-tlsdesc.S >> index 0046d29f9b..425e45a50f 100644 >> --- a/sysdeps/aarch64/dl-tlsdesc.S >> +++ b/sysdeps/aarch64/dl-tlsdesc.S >> @@ -150,8 +150,8 @@ _dl_tlsdesc_dynamic: >> /* Save just enough registers to support fast path, if we fall >> into slow path we will save additional registers. */ >> stp x1, x2, [sp, #-32]! >> - stp x3, x4, [sp, #16] >> cfi_adjust_cfa_offset (32) >> + stp x3, x4, [sp, #16] >> cfi_rel_offset (x1, 0) >> cfi_rel_offset (x2, 8) >> cfi_rel_offset (x3, 16) >> -- >> 2.23.0 >>