From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130078.outbound.protection.outlook.com [40.107.13.78]) by sourceware.org (Postfix) with ESMTPS id 069E0384B80F for ; Mon, 11 Jan 2021 10:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 069E0384B80F Received: from AM6P195CA0052.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::29) by DB6PR08MB2805.eurprd08.prod.outlook.com (2603:10a6:6:20::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Mon, 11 Jan 2021 10:51:07 +0000 Received: from VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::3f) by AM6P195CA0052.outlook.office365.com (2603:10a6:209:87::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 10:51:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT050.mail.protection.outlook.com (10.152.19.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 10:51:06 +0000 Received: ("Tessian outbound af289585f0f4:v71"); Mon, 11 Jan 2021 10:51:06 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 784bbe45d78454c7 X-CR-MTA-TID: 64aa7808 Received: from 758aae016a6f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C4D62571-5A8B-490D-AAE2-B18FEC3A648F.1; Mon, 11 Jan 2021 10:51:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 758aae016a6f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jan 2021 10:51:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9Ow2+BoTBzs/9fwjsJxP533mh6o4ItgI2QzmJxHuUAIGcDlSflsYIXObpybETMXH9M+XuByWmDSiEX7s4YrHRPUZKTG/g8eM5GCyngeW+bKApfzQ5dktWZRayitw/9LvCZfCU+CO1jVY+9AKkCwXsDS76Pn54UfIzluWbSJEKk+l4RMES09XQSW4LFW0jLTeSdfbHHchr3ZHrhwWjS5w6fH6zOtF1JE6Z+183seRjzEP1ZU132n/Picfm2mnNq6Gdep2E3348wDaCguth3wCQp0+3XbHARog8yjfwJbDm5h3yN+y+zclbISQ09vk7reptaU1vgLvMpX/VnVGOK0zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2lAn7ec7/u10cU5ULSDjueR0+N2PqRWc2iqyp1ReAE=; b=mJoq4mQcFd/OHWXDmEWDw829NMiG1g1ZdFoRNRnKveeeL7s8aJ/stqZig+kR68VPzXXyBPH/HEApzjZcemCMdVc35vwKzozJQBIHyaw83KFf0KHZ4t50ZxCM1RUWPWU3DployBlAn+di8o0pHqhTH1ufm/vyPYkur2VR/oSNts+K91c2ZLJle8M8rbuUszVHnX87vHUf27kAyBi6SRXsQJPKpugct5R+g1PPuT9qBbV+u4NjkdNB47kuDbFMYHx8KwWoGIlSHTKvgM2tI9sUz7iGz1LKCeJ/GohnvIqE9dfJotGZvGpZD4MoV4S9mzOxgA3sJbXtONqazGFOdr5g6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PA4PR08MB6223.eurprd08.prod.outlook.com (2603:10a6:102:e8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Mon, 11 Jan 2021 10:50:59 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::700f:ddbe:a347:ee4f]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::700f:ddbe:a347:ee4f%6]) with mapi id 15.20.3742.012; Mon, 11 Jan 2021 10:50:59 +0000 Date: Mon, 11 Jan 2021 10:50:57 +0000 From: Szabolcs Nagy To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH v2 0/4] fix ifunc with static pie [BZ #27072] Message-ID: <20210111105056.GX2379@arm.com> References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::27) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.52) by LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 10:50:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 01f0c679-30b7-450e-c28d-08d8b61ecc55 X-MS-TrafficTypeDiagnostic: PA4PR08MB6223:|DB6PR08MB2805: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PXwE6iwI5QWL4khPYCnzJ0RmcS4Inn1nTlYd053UARrUD2MR17Zw5L5UHIqQs7dmPX3UUZeTlg0AIqJ6+FAxOfDUpvWEsGDaGfhknoTAUWgEu3pUoMqCU21FPDBRR3j+xc3YTDR+6sUc/oIq2IMo3vkIyOboughsL4icqO3frPvdeub5xdpFFAQfm8vHJ6xIRHPDpKnMY6vTXdwG6wuB5eoY1mlGqWuYmU/WavlHTz404pCSm5IXGImSEnsQ792HbUI+I3TbAkQV8B6wfnGWu+6zYVIAcgz86M2nM0tYg3mDtyY9SeWuC3ussgSr3KpmvzjZhBsOqvFh0FWSMCs2uDrXHsKkFXD1cGyLXqIL2NJj4CGM7jCYFVy7kjS2rZR2ZnvvnosC9M4pbkJiS1deRw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(478600001)(316002)(6916009)(8936002)(86362001)(53546011)(66476007)(1076003)(33656002)(55016002)(8676002)(66556008)(16526019)(8886007)(26005)(186003)(36756003)(66946007)(83380400001)(2616005)(956004)(5660300002)(44832011)(7696005)(2906002)(52116002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eXBMand2N2tuY1hsamRQTHZBZHZQU2paRHRpU1BiazNRL1dNQWZaSTZwMU5l?= =?utf-8?B?THNOOWRjRkUxRGJmMUp5UjluTFEwQ0YvQjJiNE1Cb3hmVzFTTGw0UEpYVXRT?= =?utf-8?B?YW9tYkhiRHN0NFZKanRKS1hjVE5FNFRNV3M0cVBSRGVMYUt6SGFlTTRndDdn?= =?utf-8?B?eWZpcmo4dG5pZ0w4NVVwclRiRmRJbE4rSFJPMC9YTEE3aEdGNExsbllXUXNS?= =?utf-8?B?OTByUU44Vm93Z0RBUHY4eEJQc3RoenZEbjVBbHA1K3hwTFdMcHFJZEtUZUN4?= =?utf-8?B?c2FDTjRXaWRYb0FzT2ZUc3NaYUVraVRwUWQxNUdZMEo2cDRTZlVpUHlSdVR5?= =?utf-8?B?YVdtaHZ2bnMvZlpxZ2RFM04yZWhmYURmQTl3Qk1LblJWRWE0c2NFdzdlTkJq?= =?utf-8?B?NUZRQ2NCSjBTZSsrdHBlQkFXOG95WTRyYTJRdmM0azNSc0orRG1FeFpuZVhi?= =?utf-8?B?aTA4eFlINThSdFlHV3gvcmIxcHhUV2Y5S0ZmSW91WXErZkxRaVFyeExuWjBJ?= =?utf-8?B?OUJDM2NwWW03U1pqSDJpbEJ2cHB1VURvODhPL3ZoR3dTNHNQaFE4SExsTVc3?= =?utf-8?B?NWpUemhDVFQyaXA5WTZ2bjlXb25vWkowQnJPMlFnQWRqVnI5N2pNc283bUZK?= =?utf-8?B?OUc2cENFWXF3NUEvd3ZOWEt2MDZlc2o4T29vdzJMZnpucmxEcTZRNWtPaTlZ?= =?utf-8?B?dmlDM3BwUDNSdVJIZTQwS2VaL0NzMzR2Yk5WZnZGQzY4RXptb3ExSzhsaWtu?= =?utf-8?B?bUJlRG5NK3U0TzU5R2xpRWxMNEZ5TnFNdzBGc3RzTVEvd1Y1MklQdUdHd1F3?= =?utf-8?B?dE9sVTVWeGcxWGZsZE40bCtBTFhlT1VCclNxa0tkOW5GTnY4SjUxZTA1S3R2?= =?utf-8?B?M3d2Y054dFUxMHRMbXBZWjhaVm5kM0pCZEFyZUUwNVh4ZzFzdFJEdjhCYjFn?= =?utf-8?B?R09RdE1ab3dsRFZWZGlEV295aFdURGk2aWl4clhFeFhPVDh3UkU0K3JoYlRV?= =?utf-8?B?NStlN1FBMGRBMVREbDNsSGpwMDRvaTRnczJ3TnpVR0Q0Q2I1bXFYU1lnQ3Rv?= =?utf-8?B?SGtUMkExSzBGZ3k4em9DMHpVMGJRTTBHT1U5UEo2MC9NOFc0VU9maWJlL0ZM?= =?utf-8?B?cTFjUUp1bGxHYTZEYWRuNkoxQUg5ZzNMS3Bldys5M05VYnlZSFYzeVRrblN3?= =?utf-8?B?akphYnpKcmVQaElsMFQvMXdweHNVK1VRUTVBeFJTYkp5eVBmanRVRXpVVUZk?= =?utf-8?B?VGM0RjZCaWwxcjU1TlNpcnJmNUVtblFLYWhEY3VHb2tva0Y0RVBXVm9QTGc1?= =?utf-8?Q?G1ScoxMZmyy9mPD7pdFMnrn1VBCUopZs4S?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6223 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 38d4f309-d36a-4a3f-63c5-08d8b61ec805 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8ZsZXyLf6U/4ztYj3Fvvbmm2W6Zsa50ucEMtJk+6S5LV81wujQGEgg0QxRWR9qKrrKKIRpdUqwgTSIQfupTxarPDW55oiJ5QmnzJDJ7eCz4VR2DIEpZgbBP6VWJ3V7MqYTsl1IFnSiYVhBgoBY7zN15S/5xjwfKa5pxpVZRLpB1thep80GMC8pFY8H/06BlzylwnIioq4O8o6G7vW1Wg+e+xxvdfzkfCv2PQm7Vl+QHYhWz9IvfGq+LQyTACgUGXRPFPT4nrrvpIobR03XJFqtXet4qmASJhL98h5ssww4Mk2E33ch+jGTCTCw326QIoeSAzdolC57WN17rEtjPQpc0Ul/8Tey38iBTNZ+uBp3u2aqzcm9gdLCqK8Isg3iiif8PkTsE+P37goLJWiCYUWDHrhwhchNV5MWB0F+2a6/hs/4sX0jUFtoKNrrn44r2t1yMzoCd9PJ8Dv1t/Ghe36PCxIx4T0BcgVUDKiXuEWxlsmdLvj1tTHF7dsoOLa9ko X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(39860400002)(136003)(46966006)(2906002)(53546011)(316002)(16526019)(186003)(26005)(8886007)(8676002)(4326008)(6862004)(34020700004)(55016002)(82310400003)(82740400003)(36756003)(81166007)(86362001)(33656002)(956004)(2616005)(5660300002)(83380400001)(356005)(7696005)(478600001)(336012)(1076003)(70586007)(70206006)(8936002)(44832011)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2021 10:51:06.5082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01f0c679-30b7-450e-c28d-08d8b61ecc55 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2805 X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 10:51:12 -0000 The 01/08/2021 09:04, H.J. Lu wrote: > On Fri, Jan 8, 2021 at 8:22 AM Szabolcs Nagy via Libc-alpha > wrote: > > > > v2: > > - check PI_STATIC_AND_HIDDEN for --enable-static-pie > > - change string buffer sizes in the tunables > > - fix env_alias == NULL logic in __tunables_init > > - move __ehdr_start processing after self relocation > > > > I think this is in a reasonable shape now, but there are still > > some issues: > > - tunables try to allocate memory (tunable_strdup) even if > > that's not necessary: only setuid binaries need this (in > > case there is a TUNABLE_SECLEVEL_SXID_ERASE tunable). > > this adds a lot of complexity and a failure path to the early > > init code. i think that if there is any such tunable then the > > entire GLIBC_TUNABLE= should just be dropped. > > - tunable strings could be stored more compactly (and without > > arbitrary size limits) as an optimization. (can be done once > > there are too many tunables.) > > - all symbols are forced hidden in libc.a, but i think lib*.a > > should do the same. (other than lib*_nonshared.a) > > > > Szabolcs Nagy (4): > > configure: Require PI_STATIC_AND_HIDDEN for static pie > > Make libc symbols hidden in static PIE > > elf: Avoid RELATIVE relocs in __tunables_init > > csu: Move static pie self relocation later [BZ #27072] > > > > Can you push your patches into a branch? I'd like to add an x86 test > on top of your patches. i rebased and pushed them into nsz/bug27072