* [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper
@ 2021-01-16 14:56 Alejandro Colomar
2021-01-17 20:34 ` Michael Kerrisk (man-pages)
0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Colomar @ 2021-01-16 14:56 UTC (permalink / raw)
To: mtk.manpages
Cc: Alejandro Colomar, linux-man, Vineet Gupta, linux-snps-arc,
Heinrich Schuchardt, Guo Ren, linux-csky, Thomas Bogendoerfer,
linux-mips, Nick Hu, Greentime Hu, Vincent Chen, libc-alpha,
Dave Martin, Martin Sebor
Glibc uses 'void *' instead of 'char *'.
And the prototype is declared in <sys/cacheflush.h>.
......
$ syscall='cacheflush';
$ ret='int';
$ find glibc/ -type f -name '*.h' \
|xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27:
extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35:
extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30:
extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW;
glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30:
extern int cacheflush (void *__addr, const int __nbytes,
const int __op) __THROW;
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
man2/cacheflush.2 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/man2/cacheflush.2 b/man2/cacheflush.2
index 2cf624f3a..0496879ca 100644
--- a/man2/cacheflush.2
+++ b/man2/cacheflush.2
@@ -27,9 +27,9 @@
cacheflush \- flush contents of instruction and/or data cache
.SH SYNOPSIS
.nf
-.B #include <asm/cachectl.h>
+.B #inlcude <sys/cacheflush.h>
.PP
-.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache );
+.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache );
.fi
.PP
.IR Note :
--
2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper
2021-01-16 14:56 [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper Alejandro Colomar
@ 2021-01-17 20:34 ` Michael Kerrisk (man-pages)
2021-01-17 20:43 ` Alejandro Colomar (man-pages)
0 siblings, 1 reply; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-01-17 20:34 UTC (permalink / raw)
To: Alejandro Colomar
Cc: mtk.manpages, linux-man, Vineet Gupta, linux-snps-arc,
Heinrich Schuchardt, Guo Ren, linux-csky, Thomas Bogendoerfer,
linux-mips, Nick Hu, Greentime Hu, Vincent Chen, libc-alpha,
Dave Martin, Martin Sebor
Hi Alex,
On 1/16/21 3:56 PM, Alejandro Colomar wrote:
> Glibc uses 'void *' instead of 'char *'.
> And the prototype is declared in <sys/cacheflush.h>.
>
> ......
>
> $ syscall='cacheflush';
> $ ret='int';
> $ find glibc/ -type f -name '*.h' \
> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
> glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27:
> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
> glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35:
> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
> glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30:
> extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW;
> glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30:
> extern int cacheflush (void *__addr, const int __nbytes,
> const int __op) __THROW;
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Thanks. Patch applied.
Cheers,
Michael
> ---
> man2/cacheflush.2 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/man2/cacheflush.2 b/man2/cacheflush.2
> index 2cf624f3a..0496879ca 100644
> --- a/man2/cacheflush.2
> +++ b/man2/cacheflush.2
> @@ -27,9 +27,9 @@
> cacheflush \- flush contents of instruction and/or data cache
> .SH SYNOPSIS
> .nf
> -.B #include <asm/cachectl.h>
> +.B #inlcude <sys/cacheflush.h>
> .PP
> -.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache );
> +.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache );
> .fi
> .PP
> .IR Note :
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper
2021-01-17 20:34 ` Michael Kerrisk (man-pages)
@ 2021-01-17 20:43 ` Alejandro Colomar (man-pages)
2021-01-17 20:55 ` Michael Kerrisk (man-pages)
0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Colomar (man-pages) @ 2021-01-17 20:43 UTC (permalink / raw)
To: Michael Kerrisk (man-pages)
Cc: linux-man, Vineet Gupta, linux-snps-arc, Heinrich Schuchardt,
Guo Ren, linux-csky, Thomas Bogendoerfer, linux-mips, Nick Hu,
Greentime Hu, Vincent Chen, libc-alpha, Dave Martin,
Martin Sebor
Hi Michael,
On 1/17/21 9:34 PM, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
>
> On 1/16/21 3:56 PM, Alejandro Colomar wrote:
>> Glibc uses 'void *' instead of 'char *'.
>> And the prototype is declared in <sys/cacheflush.h>.
D'oh!
>>
>> ......
>>
>> $ syscall='cacheflush';
>> $ ret='int';
>> $ find glibc/ -type f -name '*.h' \
>> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
>> glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27:
It is defined in <sys/cachectl.h>
Please fix that.
Thanks,
Alex
>> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
>> glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35:
>> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
>> glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30:
>> extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW;
>> glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30:
>> extern int cacheflush (void *__addr, const int __nbytes,
>> const int __op) __THROW;
>>
>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>
> Thanks. Patch applied.
>
> Cheers,
>
> Michael
>
>> ---
>> man2/cacheflush.2 | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/man2/cacheflush.2 b/man2/cacheflush.2
>> index 2cf624f3a..0496879ca 100644
>> --- a/man2/cacheflush.2
>> +++ b/man2/cacheflush.2
>> @@ -27,9 +27,9 @@
>> cacheflush \- flush contents of instruction and/or data cache
>> .SH SYNOPSIS
>> .nf
>> -.B #include <asm/cachectl.h>
>> +.B #inlcude <sys/cacheflush.h>
s/cacheflush.h/cachectl.h/
>> .PP
>> -.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache );
>> +.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache );
>> .fi
>> .PP
>> .IR Note :
>>
>
>
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper
2021-01-17 20:43 ` Alejandro Colomar (man-pages)
@ 2021-01-17 20:55 ` Michael Kerrisk (man-pages)
0 siblings, 0 replies; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-01-17 20:55 UTC (permalink / raw)
To: Alejandro Colomar (man-pages)
Cc: mtk.manpages, linux-man, Vineet Gupta, linux-snps-arc,
Heinrich Schuchardt, Guo Ren, linux-csky, Thomas Bogendoerfer,
linux-mips, Nick Hu, Greentime Hu, Vincent Chen, libc-alpha,
Dave Martin, Martin Sebor
On 1/17/21 9:43 PM, Alejandro Colomar (man-pages) wrote:
> Hi Michael,
>
> On 1/17/21 9:34 PM, Michael Kerrisk (man-pages) wrote:
>> Hi Alex,
>>
>> On 1/16/21 3:56 PM, Alejandro Colomar wrote:
>>> Glibc uses 'void *' instead of 'char *'.
>>> And the prototype is declared in <sys/cacheflush.h>.
>
> D'oh!
>
>>>
>>> ......
>>>
>>> $ syscall='cacheflush';
>>> $ ret='int';
>>> $ find glibc/ -type f -name '*.h' \
>>> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
>>> glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27:
>
> It is defined in <sys/cachectl.h>
>
> Please fix that.
Fixed! (Everything pushed now.)
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-17 20:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-16 14:56 [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper Alejandro Colomar
2021-01-17 20:34 ` Michael Kerrisk (man-pages)
2021-01-17 20:43 ` Alejandro Colomar (man-pages)
2021-01-17 20:55 ` Michael Kerrisk (man-pages)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).