From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fw@deneb.enyo.de>,
Zack Weinberg <zackw@panix.com>, Lukasz Majewski <lukma@denx.de>
Subject: [PATCH] tst: Provide Y2038 tests for mktime (tst-mktime4.c)
Date: Mon, 25 Jan 2021 14:03:08 +0100 [thread overview]
Message-ID: <20210125130308.32242-1-lukma@denx.de> (raw)
This change adds new test to assess mktime's functionality.
To be more specific - following use cases are checked:
- Pass struct tm as epoch time
- Pass struct tm as value just before Y2038 threshold (returned
value shall be 0x7FFFFFFF)
- Pass struct tm as the first value after Y2038 threshold
(expected value - 0x80000000)
---
time/Makefile | 2 +-
time/tst-mktime4.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 83 insertions(+), 1 deletion(-)
create mode 100644 time/tst-mktime4.c
diff --git a/time/Makefile b/time/Makefile
index 7de2ce0196..f214d001f5 100644
--- a/time/Makefile
+++ b/time/Makefile
@@ -51,7 +51,7 @@ tests := test_time clocktest tst-posixtz tst-strptime tst_wcsftime \
tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \
tst-adjtime tst-clock-y2038 tst-clock2-y2038 \
tst-cpuclock1-y2038 tst-clock_nanosleep-y2038 tst-clock_settime \
- tst-clock_adjtime tst-ctime tst-difftime
+ tst-clock_adjtime tst-ctime tst-difftime tst-mktime4
include ../Rules
diff --git a/time/tst-mktime4.c b/time/tst-mktime4.c
new file mode 100644
index 0000000000..468ca24174
--- /dev/null
+++ b/time/tst-mktime4.c
@@ -0,0 +1,82 @@
+/* Test for mktime
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <stdlib.h>
+#include <support/check.h>
+
+struct tm tm0 = {
+ .tm_year = 70,
+ .tm_mon = 0,
+ .tm_mday = 1,
+ .tm_hour = 0,
+ .tm_min = 0,
+ .tm_sec = 0,
+ .tm_wday = 4,
+ .tm_yday = 0
+};
+
+struct tm tmY2038 = {
+ .tm_year = 138,
+ .tm_mon = 0,
+ .tm_mday = 19,
+ .tm_hour = 3,
+ .tm_min = 14,
+ .tm_sec = 7,
+ .tm_wday = 2,
+ .tm_yday = 18
+};
+
+static
+void test_mktime_helper (struct tm *tm, time_t exp_val)
+{
+ time_t result = mktime (tm);
+ if (result == -1)
+ FAIL_EXIT1 ("*** mktime failed: %m");
+
+ if (result != exp_val)
+ FAIL_EXIT1 ("*** mktime returned %ld (expected %ld)\n", result, exp_val);
+}
+
+static int
+do_test (void)
+{
+ /* Set time zone for the test. */
+ TEST_VERIFY_EXIT (setenv ("TZ", "Europe/Warsaw", 1) == 0);
+ tzset ();
+
+ /* Check that mktime(1970-01-01 00:00:00) returns 0. */
+ test_mktime_helper (&tm0, 0);
+
+ /* Check that mktime(2038-01-19 03:14:07) returns 0x7FFFFFFF. */
+ test_mktime_helper (&tmY2038, 0x7fffffff);
+
+ /* Check that mktime(2038-01-19 03:14:08) returns 0x80000000
+ (time_t overflow). */
+ if (sizeof (time_t) > 4)
+ {
+ tmY2038.tm_sec++;
+ test_mktime_helper (&tmY2038, 0x80000000);
+ }
+ else
+ FAIL_UNSUPPORTED ("32-bit time_t");
+
+ return 0;
+}
+
+#include <support/test-driver.c>
--
2.20.1
next reply other threads:[~2021-01-25 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 13:03 Lukasz Majewski [this message]
2021-01-25 13:37 ` Andreas Schwab
2021-01-25 15:35 ` Lukasz Majewski
2021-01-25 15:48 ` Andreas Schwab
2021-01-25 18:13 ` Joseph Myers
2021-01-25 21:31 ` Lukasz Majewski
2021-01-25 22:26 ` Joseph Myers
2021-01-25 22:51 ` Lukasz Majewski
2021-01-25 19:22 ` Paul Eggert
2021-01-25 20:01 ` Florian Weimer
2021-01-25 22:28 ` Lukasz Majewski
2021-01-25 23:41 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125130308.32242-1-lukma@denx.de \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).