From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Subject: [PATCH] x86_64: Update THREAD_SETMEM/THREAD_SETMEM_NC for IMM64
Date: Tue, 2 Feb 2021 11:12:09 -0800 [thread overview]
Message-ID: <20210202191209.4036619-1-hjl.tools@gmail.com> (raw)
Since there is only "movq imm32s, mem64" and no "movq imm64, mem64", use
"movq reg64, mem64" to store 64-bit constant in TCB.
---
sysdeps/x86_64/nptl/tls.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/sysdeps/x86_64/nptl/tls.h b/sysdeps/x86_64/nptl/tls.h
index 20f0958780..9ec8703e45 100644
--- a/sysdeps/x86_64/nptl/tls.h
+++ b/sysdeps/x86_64/nptl/tls.h
@@ -269,6 +269,11 @@ _Static_assert (offsetof (tcbhead_t, __glibc_unused2) == 0x80,
asm volatile ("movl %0,%%fs:%P1" : \
: IMM_MODE (value), \
"i" (offsetof (struct pthread, member))); \
+ else if (__builtin_constant_p (value) \
+ && (int64_t) (int32_t) (uintptr_t) value != (uintptr_t) value) \
+ asm volatile ("movq %0,%%fs:%P1" : \
+ : "r" (value), \
+ "i" (offsetof (struct pthread, member))); \
else /* 8 */ \
{ \
asm volatile ("movq %q0,%%fs:%P1" : \
@@ -294,6 +299,12 @@ _Static_assert (offsetof (tcbhead_t, __glibc_unused2) == 0x80,
: IMM_MODE (value), \
"i" (offsetof (struct pthread, member[0])), \
"r" (idx)); \
+ else if (__builtin_constant_p (value) \
+ && (int64_t) (int32_t) (uintptr_t) value != (uintptr_t) value) \
+ asm volatile ("movq %0,%%fs:%P1(,%q2,8)" : \
+ : "r" (value), \
+ "i" (offsetof (struct pthread, member[0])), \
+ "r" (idx)); \
else /* 8 */ \
{ \
asm volatile ("movq %q0,%%fs:%P1(,%q2,8)" : \
--
2.29.2
next reply other threads:[~2021-02-02 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 19:12 H.J. Lu [this message]
2021-03-01 13:30 ` Carlos O'Donell
2021-03-02 14:21 ` [PATCH v2] " H.J. Lu
2021-03-08 22:28 ` Carlos O'Donell
2021-03-09 0:09 ` [PATCH v3] " H.J. Lu
2021-03-15 12:49 ` Carlos O'Donell
2021-03-15 13:29 ` [PATCH v4] " H.J. Lu
2021-03-16 3:01 ` Carlos O'Donell
2021-03-16 9:04 ` Andreas Schwab
2021-03-16 15:45 ` [PATCH v5] x86_64: Update THREAD_SETMEM/THREAD_SETMEM_NC for IMM64 [BZ #27591] H.J. Lu
2021-03-16 16:02 ` Andreas Schwab
2021-03-16 16:10 ` Florian Weimer
2021-03-16 16:34 ` Carlos O'Donell
2021-03-16 16:50 ` [PATCH v6] x86_64: Correct THREAD_SETMEM/THREAD_SETMEM_NC for movq " H.J. Lu
2021-03-16 16:52 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202191209.4036619-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).