From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fw@deneb.enyo.de>,
Zack Weinberg <zackw@panix.com>
Subject: Re: [PATCH 1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered
Date: Wed, 3 Feb 2021 15:17:36 +0100 [thread overview]
Message-ID: <20210203151736.263e561e@jawa> (raw)
In-Reply-To: <20210118160336.2553-1-lukma@denx.de>
[-- Attachment #1: Type: text/plain, Size: 2778 bytes --]
Dear Community,
> This code adds new flag - '--allow-time-setting' to cross-test-ssh.sh
> script to indicate if it is allowed to alter the date on the system
> on which tests are executed. This change is supposed to be used with
> test systems, which use virtual machines for testing.
>
> The GLIBC_TEST_ALLOW_TIME_SETTING env variable is exported to the
> remote environment on which the eligible test is run and brings no
> functional change when it is not.
Gentle ping on this patch. It provides support for setting time in the
VM target on which glibc tests are executed (for example armv7a).
> ---
> scripts/cross-test-ssh.sh | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/cross-test-ssh.sh b/scripts/cross-test-ssh.sh
> index 6d8fbcdfd2..1d49978197 100755
> --- a/scripts/cross-test-ssh.sh
> +++ b/scripts/cross-test-ssh.sh
> @@ -22,7 +22,7 @@
>
> progname="$(basename $0)"
>
> -usage="usage: ${progname} [--ssh SSH] HOST COMMAND ..."
> +usage="usage: ${progname} [--ssh SSH][--allow-time-setting] HOST
> COMMAND ..." help="Run a glibc test COMMAND on the remote machine
> HOST, via ssh, preserving the current working directory, and
> respecting quoting.
> @@ -32,6 +32,11 @@ instead of ordinary 'ssh'.
> If the '--timeoutfactor FACTOR' flag is present, set TIMEOUTFACTOR on
> the remote machine to the specified FACTOR.
>
> +If the '--allow-time-setting' flag is present, set
> +GLIBC_TEST_ALLOW_TIME_SETTING on the remote machine to inform that
> +time can be safely adjusted when e.g. tests are run in a virtual
> +machine.
> +
> To use this to run glibc tests, invoke the tests as follows:
>
> $ make test-wrapper='ABSPATH/cross-test-ssh.sh HOST' tests
> @@ -81,6 +86,10 @@ while [ $# -gt 0 ]; do
> timeoutfactor="$1"
> ;;
>
> + "--allow-time-setting")
> + settimeallowed="1"
> + ;;
> +
> "--help")
> echo "$usage"
> echo "$help"
> @@ -127,6 +136,12 @@ if [ "$timeoutfactor" ]; then
> ${command}"
> fi
>
> +# Add command to set the info that time on target can be adjusted,
> +# if required.
> +if [ "$settimeallowed" ]; then
> + command="export GLIBC_TEST_ALLOW_TIME_SETTING=1 ${command}"
> +fi
> +
> # HOST's sshd simply concatenates its arguments with spaces and
> # passes them to some shell. We want to force the use of /bin/sh,
> # so we need to re-quote the whole command to ensure it appears as
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-03 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 16:03 Lukasz Majewski
2021-01-18 16:03 ` [PATCH 2/3] support: Provide xclock_settime test helper function Lukasz Majewski
2021-02-03 14:18 ` Lukasz Majewski
2021-01-18 16:03 ` [PATCH 3/3] tst: Add test for clock_settime Lukasz Majewski
2021-02-03 14:19 ` Lukasz Majewski
2021-01-25 9:16 ` [PATCH 1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered Lukasz Majewski
2021-02-03 14:17 ` Lukasz Majewski [this message]
2021-02-03 19:32 ` Joseph Myers
2021-02-04 13:16 ` Lukasz Majewski
2021-02-04 20:40 ` Joseph Myers
2021-02-04 23:02 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203151736.263e561e@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).