public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	Florian Weimer <fweimer@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>,
	Florian Weimer <fw@deneb.enyo.de>,
	Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH 1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered
Date: Thu, 4 Feb 2021 14:16:05 +0100	[thread overview]
Message-ID: <20210204141605.0c545970@jawa> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2102031930390.1455277@digraph.polyomino.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

Hi Joseph,

> Should there be some way to serialize all tests that might change the 
> target date, so that no such test runs in parallel with any other
> test, to avoid such a test causing another time-related test to fail
> if they run in parallel?  Or is the intent that such tests only be
> run in serial testing?
> 

It would be best to have those tests serialized. In that way the date
would be changed properly.

This feature is only provided to work with cross-test-ssh.sh script, so
it seems like the serialization is done by this script execution.

The idea is to set time (and restore it) only in do_test() function.

> I think this sort of thing, regarding how to run the tests involving 
> changing the target date, should be documented in install.texi.
> 

Ok, I will add proper entry into install.texi.



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-02-04 13:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 16:03 Lukasz Majewski
2021-01-18 16:03 ` [PATCH 2/3] support: Provide xclock_settime test helper function Lukasz Majewski
2021-02-03 14:18   ` Lukasz Majewski
2021-01-18 16:03 ` [PATCH 3/3] tst: Add test for clock_settime Lukasz Majewski
2021-02-03 14:19   ` Lukasz Majewski
2021-01-25  9:16 ` [PATCH 1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered Lukasz Majewski
2021-02-03 14:17 ` Lukasz Majewski
2021-02-03 19:32   ` Joseph Myers
2021-02-04 13:16     ` Lukasz Majewski [this message]
2021-02-04 20:40       ` Joseph Myers
2021-02-04 23:02         ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204141605.0c545970@jawa \
    --to=lukma@denx.de \
    --cc=adhemerval.zanella@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=fw@deneb.enyo.de \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).