From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id C21253890415 for ; Mon, 8 Feb 2021 14:45:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C21253890415 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DZ82w2Vxwz1rxXl; Mon, 8 Feb 2021 15:45:44 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DZ82v6bfqz1t5jv; Mon, 8 Feb 2021 15:45:43 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NTI03lcBHzLG; Mon, 8 Feb 2021 15:45:42 +0100 (CET) X-Auth-Info: lFn62+1tXgQd+EeedOmV1tF1bTdGIBpGuqhKvUuv4gM= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 8 Feb 2021 15:45:42 +0100 (CET) Date: Mon, 8 Feb 2021 15:45:41 +0100 From: Lukasz Majewski To: Andreas Schwab Cc: Joseph Myers , Adhemerval Zanella , Florian Weimer , GNU C Library , Florian Weimer , Alistair Francis Subject: Re: [PATCH v2] tst: Provide test for sched_rr_get_interval Message-ID: <20210208154541.778b3587@jawa> In-Reply-To: <87im72amro.fsf@igel.home> References: <20210208094252.17086-1-lukma@denx.de> <87im72amro.fsf@igel.home> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/5=wsu=KZyqsO0H/AOT.AdoJ"; protocol="application/pgp-signature" X-Spam-Status: No, score=-15.0 required=5.0 tests=BAYES_00, BIGNUM_EMAILS, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 14:45:47 -0000 --Sig_/5=wsu=KZyqsO0H/AOT.AdoJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andreas, > On Feb 08 2021, Lukasz Majewski wrote: >=20 > > diff --git a/posix/tst-sched_rr_get_interval.c > > b/posix/tst-sched_rr_get_interval.c new file mode 100644 > > index 0000000000..d632e03655 > > --- /dev/null > > +++ b/posix/tst-sched_rr_get_interval.c > > @@ -0,0 +1,45 @@ > > +/* Test for sched_rr_get_interval > > + Copyright (C) 2021 Free Software Foundation, Inc. > > + This file is part of the GNU C Library. > > + > > + The GNU C Library is free software; you can redistribute it > > and/or > > + modify it under the terms of the GNU Lesser General Public > > + License as published by the Free Software Foundation; either > > + version 2.1 of the License, or (at your option) any later > > version. + > > + The GNU C Library is distributed in the hope that it will be > > useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > GNU > > + Lesser General Public License for more details. > > + > > + You should have received a copy of the GNU Lesser General Public > > + License along with the GNU C Library; if not, see > > + . */ > > + > > +#include > > +#include > > +#include > > + > > +static int > > +do_test (void) > > +{ > > + struct timespec ts[2] =3D { { -1, -1 }, { -1, -1 } }; > > + const struct sched_param param =3D { > > + .sched_priority =3D sched_get_priority_max (SCHED_RR) - 10, > > + }; > > + int result =3D sched_setscheduler (0, SCHED_RR, ¶m); > > + > > + if (result !=3D 0) > > + FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n"); > > + > > + TEST_COMPARE (sched_rr_get_internal (0, ts), 0); > > + > > + /* Check if returned time values are correct. */ > > + TEST_VERIFY_EXIT (ts[0].tv_sec < 0); > > + TEST_VERIFY_EXIT (ts[0].tv_nsec < 0 || ts[0].tv_nsec >=3D > > 1000000000); > > + TEST_VERIFY_EXIT (ts[1].tv_sec !=3D -1 || ts[1].tv_nsec !=3D -1); =20 >=20 > There should be no need to exit immediately on failure. Could you elaborate this? When the second allocated on stack struct timespec's fields are not equal to -1, it means that wrong ABI was used and some values were overwritten. >=20 > Andreas. >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/5=wsu=KZyqsO0H/AOT.AdoJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmAhTpUACgkQAR8vZIA0 zr0CtggAq9L66g4J8iK7JhR0Xz6ZrbBCngE+uOLCKye+kCux4CCElxuJfPDp9ZeN i+yDPeMkv2P+qs9KDiG1/l3LQ9zCOySXPyZdk6PpUxKmHQOkz1zn3B1h9oJyvBt4 2I0rRRCm/Bd3dn7NuCSGd3QLnw6x8CL/8LR2Q+aIxRiIwJ4Tw4qeJRC/4RCTZWAY GA/goKo7Yml058Z/A3pJe1dOBsVJN1UaB07BGpwrmOYpA+xx5FIo+yY8Van4WCWf ZJtkx81xy51GcpjWH+uIXfmXy+6XI3Ht48BlMCruzS5kbx2WDtRgdO58dqrBMJFd 1T7KYOLY4ZJ68llN3+dsFYxJ9T763g== =HCDr -----END PGP SIGNATURE----- --Sig_/5=wsu=KZyqsO0H/AOT.AdoJ--