Re: [PATCH v3] tst: Provide test for ppoll

[Lukasz Majewski <lukma@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

Hi Siddhesh,

> On 2/5/21 4:57 PM, Lukasz Majewski wrote:
> > This change adds new test to assess ppoll()'s timeout related
> > functionality (the struct pollfd does not provide valid fd to wait
> > for - just wait for timeout).
> > 
> > To be more specific - two use cases are checked:
> > - if ppoll() times out immediately when passed struct timespec has
> > zero values of tv_nsec and tv_sec.
> > - if ppoll() times out after timeout specified in passed argument
> > 
> > ---
> > Changes for v2:
> > - Remove _GNU_SOURCE definition if not already defined
> > - Replace clock_gettime with xclock_gettime
> > - Use FAIL_EXIT1 instead of plain ret value returning from the test
> > 
> > Changes for v3:
> > - Use smaller timeout - 0.5s (TIMEOUT* defines can be removed)
> > - Use TEST_TIMESPEC_NOW_OR_AFTER () to check if test has properly
> > timed out  
> 
> Lukasz, looks like this got pushed to master without a review.

With this particular version (v3) - I've followed detailed hints
provided by Adhemerval:
https://patchwork.sourceware.org/project/glibc/patch/20210114163239.16505-1-lukma@denx.de/

> Perhaps it happened by accident when pushing the timerfd patch?

I though that this patch is OK, after adding changes proposed by
Adhemerval (Adhemerval in detailed way - with working code - wrote what
he want's to see).

(Maybe I shouldn't post v3 to ML?)

> 
> Siddhesh


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]