From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 88C073857C7B for ; Wed, 10 Feb 2021 09:09:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 88C073857C7B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DbDVB0l0Mz1ryp0; Wed, 10 Feb 2021 10:09:37 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DbDV95ckfz1t6px; Wed, 10 Feb 2021 10:09:37 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id f6JrvDkRchCQ; Wed, 10 Feb 2021 10:09:36 +0100 (CET) X-Auth-Info: XULi10IzHIIeVmDKmyoGpaoy523eSCKpmb/vN92kt/U= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 10 Feb 2021 10:09:36 +0100 (CET) Date: Wed, 10 Feb 2021 10:09:29 +0100 From: Lukasz Majewski To: Joseph Myers Cc: Adhemerval Zanella , Florian Weimer , GNU C Library , Florian Weimer , Alistair Francis Subject: Re: [PATCH v2 1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered Message-ID: <20210210100929.16ec3e75@jawa> In-Reply-To: References: <20210206175709.4691-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/+sp2Pt=uBmL8FW6Mr/dMd.f"; protocol="application/pgp-signature" X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00, BIGNUM_EMAILS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 09:09:42 -0000 --Sig_/+sp2Pt=uBmL8FW6Mr/dMd.f Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Joseph, > On Sat, 6 Feb 2021, Lukasz Majewski wrote: >=20 > > This code adds new flag - '--allow-time-setting' to > > cross-test-ssh.sh script to indicate if it is allowed to alter the > > date on the system on which tests are executed. This change is > > supposed to be used with test systems, which use virtual machines > > for testing. > >=20 > > The GLIBC_TEST_ALLOW_TIME_SETTING env variable is exported to the > > remote environment on which the eligible test is run and brings no > > functional change when it is not. =20 >=20 > I think there are two separate features here, both of which should be=20 > documented. The ability to run tests that set the time should not be=20 > limited to when cross-test-ssh.sh is used; someone might want to > write their own test wrapper supporting that feature (there's no > requirement to use the provided test wrapper, writing your own is > fully supported), or might want to run tests with setting time > enabled for native testing (for example, if they have a build and > test environment that creates a virtual machine to run "make check" > natively on it and then destroys that virtual machine afterwards). >=20 Thanks for the description. > So at least two things should be documented: >=20 > * If you set GLIBC_TEST_ALLOW_TIME_SETTING in the environment in > which tests are run *and* run the tests with appropriate privileges > to be able to use clock_settime, then such tests will be run, but > this will not by itself provide any locking against conflicting tests > running in parallel so you should also either test in series or use a > test wrapper that provides such locking. >=20 > * In the case of using cross-test-ssh.sh, you can pass the=20 > --allow-time-setting option to automate both setting=20 > GLIBC_TEST_ALLOW_TIME_SETTING and doing the locking. >=20 I will include information from above text to the install.texi. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/+sp2Pt=uBmL8FW6Mr/dMd.f Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmAjoskACgkQAR8vZIA0 zr0vGQgA5x5KOlB+HDqkouwa9njbt/DqYKY3UE9u2Fq4E3oZarlMCw/m0YanB1XI griKQZyoNNSdYZlbO+OHxfUvL83LxEAM7l/Aqam5quJ43zQRAZmJG3rMs+5f2/lo 3Y1cii7IM42LTCWEB9sbz+6Xco9rhCtfb2OaVPAwEawdM0fuD4Nd86gVpYiKSEHy ruzX96jPfUvVE49PROV+zAnNnA5SsTrORoFQqx3lJeaDYpE1tUZI7LtT0qoFG9HC mUMi+x+n+0AF9PZJQZwaSTn9si/e/UoIWeEwXewBZiuXuX40+laJDrBfJQz7H0f5 5EaZVf8sSt6vL5ujffUCed+fjJuyDg== =9ER0 -----END PGP SIGNATURE----- --Sig_/+sp2Pt=uBmL8FW6Mr/dMd.f--