From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 3B21D38930F1 for ; Mon, 15 Feb 2021 09:45:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B21D38930F1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DfK2q2v8tz1rwZq; Mon, 15 Feb 2021 10:45:07 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DfK2q1Qy9z1qr73; Mon, 15 Feb 2021 10:45:07 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id K5kFytpDzlzu; Mon, 15 Feb 2021 10:45:05 +0100 (CET) X-Auth-Info: xsoUim/rSCWG6q4w1/4Bue7KEH7hNCQovb23LwRNvR8= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 15 Feb 2021 10:45:05 +0100 (CET) Date: Mon, 15 Feb 2021 10:44:58 +0100 From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella , Florian Weimer Cc: Paul Eggert , Alistair Francis , Arnd Bergmann , Alistair Francis , GNU C Library , Carlos O'Donell , Florian Weimer , Zack Weinberg Subject: Re: [PATCH v3] tst: Provide test for sched_rr_get_interval Message-ID: <20210215104458.56347a4b@jawa> In-Reply-To: <20210210124229.32367-1-lukma@denx.de> References: <20210210124229.32367-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/yvqg7g/mWF_bUXwWXrW2gYo"; protocol="application/pgp-signature" X-Spam-Status: No, score=-14.9 required=5.0 tests=BAYES_00, BIGNUM_EMAILS, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 09:45:13 -0000 --Sig_/yvqg7g/mWF_bUXwWXrW2gYo Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Community, > This change adds new test to assess sched_rr_get_interval's > functionality. >=20 > To be more specific - following use cases are checked: > - If the read interval is correct > - If the proper ABI is used - to check if adjacent data is not > overwritten >=20 > --- > Changes for v2: > - Move test execution from tests to xtests > - Use TEST_VERIFY_EXIT () macro instead of if () clause with > FAIL_EXIT1 () >=20 > Changes for v3: > - Replace TEST_VERIFY_EXIT () with TEST_VERIFY () to allow executing > all tests (do not quit early after error) Are there any more comments regarding this test? Is it eligible for pulling? > --- > posix/Makefile | 2 +- > posix/tst-sched_rr_get_interval.c | 45 > +++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 > deletion(-) create mode 100644 posix/tst-sched_rr_get_interval.c >=20 > diff --git a/posix/Makefile b/posix/Makefile > index f54015b9a8..239fbb340a 100644 > --- a/posix/Makefile > +++ b/posix/Makefile > @@ -108,7 +108,7 @@ tests-internal :=3D bug-regex5 bug-regex20 > bug-regex33 \ tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \ > tst-glob_lstat_compat tst-spawn4-compat > tests-container :=3D bug-ga2 > -xtests :=3D tst-getaddrinfo4 tst-getaddrinfo5 > +xtests :=3D tst-getaddrinfo4 tst-getaddrinfo5 > tst-sched_rr_get_interval ifeq (yes,$(build-shared)) > test-srcs :=3D globtest > tests +=3D wordexp-test tst-exec tst-spawn tst-spawn2 > tst-spawn3 diff --git a/posix/tst-sched_rr_get_interval.c > b/posix/tst-sched_rr_get_interval.c new file mode 100644 > index 0000000000..e5ebe4d004 > --- /dev/null > +++ b/posix/tst-sched_rr_get_interval.c > @@ -0,0 +1,45 @@ > +/* Test for sched_rr_get_interval > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > + > +static int > +do_test (void) > +{ > + struct timespec ts[2] =3D { { -1, -1 }, { -1, -1 } }; > + const struct sched_param param =3D { > + .sched_priority =3D sched_get_priority_max (SCHED_RR) - 10, > + }; > + int result =3D sched_setscheduler (0, SCHED_RR, ¶m); > + > + if (result !=3D 0) > + FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n"); > + > + TEST_COMPARE (sched_rr_get_interval (0, ts), 0); > + > + /* Check if returned time values are correct. */ > + TEST_VERIFY (ts[0].tv_sec >=3D 0); > + TEST_VERIFY (ts[0].tv_nsec >=3D 0 && ts[0].tv_nsec < 1000000000); > + TEST_VERIFY (ts[1].tv_sec =3D=3D -1 && ts[1].tv_nsec =3D=3D -1); > + > + return 0; > +} > + > +#include Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/yvqg7g/mWF_bUXwWXrW2gYo Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmAqQpoACgkQAR8vZIA0 zr0C9Af+O49kk52u9VFy0nhn/fZP236QoG6I+tXCmrtRAk+FN3TP+m5RE4PWW+bB wLOIsYwZ1wX7eL48FaeU2c8Hd1tCo2ZCgHYhHdBwB67wLGVno0IY+mxTFPm/uALs AtuT4xwoVu//GXNiPY1SvKPIbYmLmwWKPAX/IW4NBMLUSugcBMlicMscgREchBDa zfVT87Id7jAGyUU4jDEfQZ6PTPCILYEyR1/IrLdjALYnlr4EyIWTYtsI6ES8HOTp yUs+qDwuOj4BZycoyySKB2fnmdnfQIQz+qvtgrJyuiIhKos71zJExWGLcgbdeoHK KGQ7zkJZlUiEqTudoLgA89JJ1d9sOg== =qxd/ -----END PGP SIGNATURE----- --Sig_/yvqg7g/mWF_bUXwWXrW2gYo--