* [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
@ 2021-02-16 12:00 Naohiro Tamura
2021-02-16 13:04 ` Andreas Schwab
2021-02-17 1:20 ` [PATCH v2 " Naohiro Tamura
0 siblings, 2 replies; 6+ messages in thread
From: Naohiro Tamura @ 2021-02-16 12:00 UTC (permalink / raw)
To: libc-alpha
This patch replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE.
It has been confirmed that GNU 'autoconf' 2.69 doesn't change the
'configure' file and suppressed obsolete warning.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index d8ccb6c119..b7f6f8f008 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1579,7 +1579,7 @@ if test "$with_gd" != "no"; then
LDFLAGS="$LDFLAGS $libgd_ldflags"
old_LIBS="$LIBS"
LIBS="$LIBS -lgd -lpng -lz -lm"
- AC_TRY_LINK([#include <gd.h>], [gdImagePng (0, 0)], LIBGD=yes, LIBGD=no)
+ AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <gd.h>]], [[gdImagePng (0, 0)]])],[LIBGD=yes],[LIBGD=no])
CFLAGS="$old_CFLAGS"
LDFLAGS="$old_LDFLAGS"
LIBS="$old_LIBS"
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
2021-02-16 12:00 [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE Naohiro Tamura
@ 2021-02-16 13:04 ` Andreas Schwab
2021-02-17 1:08 ` naohirot
2021-02-17 1:20 ` [PATCH v2 " Naohiro Tamura
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2021-02-16 13:04 UTC (permalink / raw)
To: Naohiro Tamura; +Cc: libc-alpha
On Feb 16 2021, Naohiro Tamura wrote:
> diff --git a/configure.ac b/configure.ac
> index d8ccb6c119..b7f6f8f008 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1579,7 +1579,7 @@ if test "$with_gd" != "no"; then
> LDFLAGS="$LDFLAGS $libgd_ldflags"
> old_LIBS="$LIBS"
> LIBS="$LIBS -lgd -lpng -lz -lm"
> - AC_TRY_LINK([#include <gd.h>], [gdImagePng (0, 0)], LIBGD=yes, LIBGD=no)
> + AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <gd.h>]], [[gdImagePng (0, 0)]])],[LIBGD=yes],[LIBGD=no])
Please fold to avoid long lines.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
2021-02-16 13:04 ` Andreas Schwab
@ 2021-02-17 1:08 ` naohirot
0 siblings, 0 replies; 6+ messages in thread
From: naohirot @ 2021-02-17 1:08 UTC (permalink / raw)
To: 'Andreas Schwab'; +Cc: libc-alpha
Andreas-san,
Thank you for the review.
> -----Original Message-----
> From: Andreas Schwab <schwab@linux-m68k.org>
> Sent: Tuesday, February 16, 2021 10:05 PM
> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>
> Cc: libc-alpha@sourceware.org
> Subject: Re: [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
>
> On Feb 16 2021, Naohiro Tamura wrote:
>
> > diff --git a/configure.ac b/configure.ac index d8ccb6c119..b7f6f8f008
> > 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -1579,7 +1579,7 @@ if test "$with_gd" != "no"; then
> > LDFLAGS="$LDFLAGS $libgd_ldflags"
> > old_LIBS="$LIBS"
> > LIBS="$LIBS -lgd -lpng -lz -lm"
> > - AC_TRY_LINK([#include <gd.h>], [gdImagePng (0, 0)], LIBGD=yes,
> > LIBGD=no)
> > + AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <gd.h>]],
> [[gdImagePng
> > + (0, 0)]])],[LIBGD=yes],[LIBGD=no])
>
> Please fold to avoid long lines.
>
I'll fix that.
Thanks.
Naohiro
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
2021-02-16 12:00 [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE Naohiro Tamura
2021-02-16 13:04 ` Andreas Schwab
@ 2021-02-17 1:20 ` Naohiro Tamura
2021-02-21 23:40 ` Mike Frysinger
1 sibling, 1 reply; 6+ messages in thread
From: Naohiro Tamura @ 2021-02-17 1:20 UTC (permalink / raw)
To: libc-alpha
This patch replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE.
It has been confirmed that GNU 'autoconf' 2.69 doesn't change the
'configure' file and suppressed obsolete warning.
---
configure.ac | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index d8ccb6c119..14e85a221f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1579,7 +1579,8 @@ if test "$with_gd" != "no"; then
LDFLAGS="$LDFLAGS $libgd_ldflags"
old_LIBS="$LIBS"
LIBS="$LIBS -lgd -lpng -lz -lm"
- AC_TRY_LINK([#include <gd.h>], [gdImagePng (0, 0)], LIBGD=yes, LIBGD=no)
+ AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <gd.h>]], [[gdImagePng (0, 0)]])],
+ [LIBGD=yes],[LIBGD=no])
CFLAGS="$old_CFLAGS"
LDFLAGS="$old_LDFLAGS"
LIBS="$old_LIBS"
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
2021-02-17 1:20 ` [PATCH v2 " Naohiro Tamura
@ 2021-02-21 23:40 ` Mike Frysinger
2021-02-22 1:50 ` naohirot
0 siblings, 1 reply; 6+ messages in thread
From: Mike Frysinger @ 2021-02-21 23:40 UTC (permalink / raw)
To: Naohiro Tamura; +Cc: libc-alpha
On 17 Feb 2021 01:20, Naohiro Tamura wrote:
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1579,7 +1579,8 @@ if test "$with_gd" != "no"; then
> LDFLAGS="$LDFLAGS $libgd_ldflags"
> old_LIBS="$LIBS"
> LIBS="$LIBS -lgd -lpng -lz -lm"
> - AC_TRY_LINK([#include <gd.h>], [gdImagePng (0, 0)], LIBGD=yes, LIBGD=no)
> + AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <gd.h>]], [[gdImagePng (0, 0)]])],
> + [LIBGD=yes],[LIBGD=no])
i fixed the indentation & pushed the result.
- AC_TRY_LINK([#include <gd.h>], [gdImagePng (0, 0)], LIBGD=yes, LIBGD=no)
+ AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <gd.h>]], [[gdImagePng (0, 0)]])],
+ [LIBGD=yes], [LIBGD=no])
-mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE
2021-02-21 23:40 ` Mike Frysinger
@ 2021-02-22 1:50 ` naohirot
0 siblings, 0 replies; 6+ messages in thread
From: naohirot @ 2021-02-22 1:50 UTC (permalink / raw)
To: Mike Frysinger; +Cc: libc-alpha
Mike-san,
>i fixed the indentation & pushed the result.
Thanks for fixing the indentation kindly and merging it!
Naohiro
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-22 1:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 12:00 [PATCH 2/3] Replaced obsolete AC_TRY_LINK to AC_LINK_IFELSE Naohiro Tamura
2021-02-16 13:04 ` Andreas Schwab
2021-02-17 1:08 ` naohirot
2021-02-17 1:20 ` [PATCH v2 " Naohiro Tamura
2021-02-21 23:40 ` Mike Frysinger
2021-02-22 1:50 ` naohirot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).