From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 753733938C0A for ; Wed, 24 Feb 2021 09:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 753733938C0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Dlr8z2H0Jz1s00C; Wed, 24 Feb 2021 10:24:35 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Dlr8z14cYz1r13Y; Wed, 24 Feb 2021 10:24:35 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id EHsWAA5aq0Us; Wed, 24 Feb 2021 10:24:32 +0100 (CET) X-Auth-Info: TNF2YPhrD6SaNWQpYJyTRX++Uw3Otzb1DwAPKZLmgy0= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 24 Feb 2021 10:24:32 +0100 (CET) Date: Wed, 24 Feb 2021 10:24:31 +0100 From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella , Florian Weimer , DJ Delorie Cc: Paul Eggert , Alistair Francis , Arnd Bergmann , Alistair Francis , GNU C Library , Carlos O'Donell , Florian Weimer , Zack Weinberg Subject: Re: [PATCH v2] tst: Add test for clock_adjtime Message-ID: <20210224102431.5fecc57f@jawa> In-Reply-To: <20210217232435.24045-1-lukma@denx.de> References: <20210217232435.24045-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/oo=aDsSotCqlIFUHy+_5KCM"; protocol="application/pgp-signature" X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, BIGNUM_EMAILS, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2021 09:24:39 -0000 --Sig_/oo=aDsSotCqlIFUHy+_5KCM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Community, > This code brings test to check if time on target machine is properly > adjusted. > The time is altered only when cross-test-ssh.sh is executed with > --allow-time-setting flag > As the delta added to CLOCK_REALTIME is only 1ms the original time is > not restored and further tests are executed with this bias. >=20 Gentle ping on this patchset. > --- > Changes for v2: > - Use timespec_sub and support_timespec_check_in_range to check if > time has been adjusted properly > --- > time/Makefile | 2 +- > time/tst-clock_adjtime.c | 59 > ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 > insertions(+), 1 deletion(-) create mode 100644 > time/tst-clock_adjtime.c >=20 > diff --git a/time/Makefile b/time/Makefile > index b6f0969f3d..fc6415bf8a 100644 > --- a/time/Makefile > +++ b/time/Makefile > @@ -51,7 +51,7 @@ tests :=3D test_time clocktest tst-posixtz > tst-strptime tst_wcsftime \ tst-clock tst-clock2 tst-clock_nanosleep > tst-cpuclock1 \ tst-adjtime tst-ctime tst-difftime tst-mktime4 > tst-clock-y2038 \ tst-clock2-y2038 tst-cpuclock1-y2038 > tst-clock_nanosleep-y2038 \ > - tst-clock_settime > + tst-clock_settime tst-clock_adjtime > =20 > include ../Rules > =20 > diff --git a/time/tst-clock_adjtime.c b/time/tst-clock_adjtime.c > new file mode 100644 > index 0000000000..f31a4058ec > --- /dev/null > +++ b/time/tst-clock_adjtime.c > @@ -0,0 +1,59 @@ > +/* Test for clock_adjtime > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +static int > +do_test (void) > +{ > + struct timespec tv_then, tv_now; > + struct timex delta; > + > + /* Check if altering target time is allowed. */ > + if (getenv (SETTIME_ENV_NAME) =3D=3D NULL) > + FAIL_UNSUPPORTED ("clock_adjtime is executed only when "\ > + SETTIME_ENV_NAME" is set\n"); > + > + tv_then =3D xclock_now (CLOCK_REALTIME); > + > + /* Setup time value to adjust - 1 ms. */ > + delta.time.tv_sec =3D 0; > + delta.time.tv_usec =3D 1000; > + delta.modes =3D ADJ_SETOFFSET; > + > + int ret =3D clock_adjtime (CLOCK_REALTIME, &delta); > + if (ret =3D=3D -1) > + FAIL_EXIT1 ("clock_adjtime failed: %m\n"); > + > + tv_now =3D xclock_now (CLOCK_REALTIME); > + > + /* Check if clock_adjtime adjusted the system time. */ > + struct timespec r =3D timespec_sub (tv_now, tv_then); > + TEST_COMPARE (support_timespec_check_in_range > + ((struct timespec) { 0, 1000000 }, r, 0.0009, > 0.0011), 0); + > + > + return 0; > +} > + > +#include Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/oo=aDsSotCqlIFUHy+_5KCM Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmA2G08ACgkQAR8vZIA0 zr2+mQf+Kzgl+C+K7WMTjDQdaaykBb1PpC5tfuA43ySTTCjx1yfMICpeWKFZmvQE wCueN9ys6aLXiffFUhuNJTPNrYRPAXndWpO17Xyzb49fssn0fQ0BrG6euAR+iPRf RNXXzY6cYXc4ga/8FbF3VRGr9lpKDw70u08uE85lZ+LvBPbTupwXdF+VJ8UdvE2D RTljWrusjX4K6CKahsacqokbsDeF7GIWXiSoWpBxJDXyxhdVGO/a2W7ilaXVzOw3 9BeuIiYPz6m5FJqk0va5/x1B7u3cDLJ6I0laPdQIIzlpiCQlbh4R+az57PxoIHpH 5DKh2gfMRnnLWxWE2DAgVT1lECk6lA== =qwxY -----END PGP SIGNATURE----- --Sig_/oo=aDsSotCqlIFUHy+_5KCM--