From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E658E3987C3A for ; Fri, 26 Feb 2021 17:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E658E3987C3A Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11QHEuHr021918; Fri, 26 Feb 2021 12:19:26 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 36y578r46j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 12:19:25 -0500 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 11QHEueu021901; Fri, 26 Feb 2021 12:19:25 -0500 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 36y578r462-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 12:19:25 -0500 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11QH87He021097; Fri, 26 Feb 2021 17:19:24 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma03wdc.us.ibm.com with ESMTP id 36tt29rcg7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 17:19:24 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11QHJNHF38011388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Feb 2021 17:19:23 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E8B6BE053; Fri, 26 Feb 2021 17:19:23 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C50A8BE051; Fri, 26 Feb 2021 17:19:21 +0000 (GMT) Received: from work-tp (unknown [9.65.223.199]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Fri, 26 Feb 2021 17:19:21 +0000 (GMT) Date: Fri, 26 Feb 2021 14:19:18 -0300 From: Raoni Fassina Firmino To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Florian Weimer , Tulio Magno Quites Machado Filho Subject: Re: [PATCH] powerpc: Remove backtrace implementation Message-ID: <20210226171918.dctybyw7b7igyytr@work-tp> Mail-Followup-To: Adhemerval Zanella , libc-alpha@sourceware.org, Florian Weimer , Tulio Magno Quites Machado Filho References: <20210212170941.1786380-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210212170941.1786380-1-adhemerval.zanella@linaro.org> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-02-26_05:2021-02-26, 2021-02-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=765 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1011 spamscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102260126 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 17:19:31 -0000 On Fri, Feb 12, 2021 at 02:09:41PM -0300, Adhemerval Zanella wrote: > The powerpc optimization to provide a fast stacktrace requires some > ad-hoc code to handle Linux signal frames and the change is fragile > once the kernel decides to slight change its execution sequence [1]. > > The generic implementation work as-is and it should be future proof > since the kernel provides the expected CFI directives in vDSO shared > page. > > Checked on powerpc-linux-gnu, powerpc64le-linux-gnu, and > powerpc64-linux-gnu. > FWIW I also checked on: - powerpc-linux-gnu (with 64bits 5.10 kernel) - powerpc64le-linux-gnu (with new 5.11 kernel) - powerpc64-linux-gnu (with new 5.11 kernel) With and without Florian's unwind patch series and it seems to be ok in both cases. o/ Raoni