From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id D0F5E383E806 for ; Tue, 2 Mar 2021 13:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D0F5E383E806 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Dqd9X61Jhz1qskL; Tue, 2 Mar 2021 14:23:12 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Dqd9X5lqJz1sP7L; Tue, 2 Mar 2021 14:23:12 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 1yLH1Lak3Vfy; Tue, 2 Mar 2021 14:23:11 +0100 (CET) X-Auth-Info: wtwyKoCzIYMgoUjpM/1eGYO/hwp7UCNs2BupEV2/+jM= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 2 Mar 2021 14:23:11 +0100 (CET) Date: Tue, 2 Mar 2021 14:23:05 +0100 From: Lukasz Majewski To: Adhemerval Zanella Cc: GNU C Library Subject: Re: [PATCH 1/3] tst: Modify tst-clock_adjtime to allow reuse of its code Message-ID: <20210302142305.047515bd@jawa> In-Reply-To: References: <20210228223938.8304-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/g2aq38cA2XAScG6Rumb70=v"; protocol="application/pgp-signature" X-Spam-Status: No, score=-15.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2021 13:23:15 -0000 --Sig_/g2aq38cA2XAScG6Rumb70=v Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > On 28/02/2021 19:39, Lukasz Majewski wrote: > > The tst-clock_adjtime can be adjusted to be reused for also testing > > adjtimex. =20 >=20 > LGTM, although below there is a suggestion than simplifies the code a > bit. >=20 > Reviewed-by: Adhemerval Zanella >=20 > > --- > > sysdeps/unix/sysv/linux/tst-clock_adjtime.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > >=20 > > diff --git a/sysdeps/unix/sysv/linux/tst-clock_adjtime.c > > b/sysdeps/unix/sysv/linux/tst-clock_adjtime.c index > > 6b9bb9940c..84a3f19504 100644 --- > > a/sysdeps/unix/sysv/linux/tst-clock_adjtime.c +++ > > b/sysdeps/unix/sysv/linux/tst-clock_adjtime.c @@ -22,6 +22,11 @@ > > #include > > #include > > =20 > > +#ifndef TST_ADJTIME_SYSCALL > > +#define TST_ADJTIME_SYSCALL clock_adjtime > > +#define TST_ADJTIME_ARGS (CLOCK_REALTIME, &delta) > > +#endif > > + =20 >=20 > It would be simpler to just do: >=20 > #ifndef ADJTIME_CALL > # define ADJTIME_CALL(__clock, __timex) clock_adjtime (__clock, > __timex) #endif >=20 > and then for adjtimex test define: >=20 > #define ADJTIME_CALL(__clock, __timex) adjtimex (__timex) >=20 Yes, this approach is far more clear. I will use it. > > static int > > do_test (void) > > { > > @@ -40,7 +45,7 @@ do_test (void) > > delta.time.tv_usec =3D 0; > > delta.modes =3D ADJ_SETOFFSET; > > =20 > > - int ret =3D clock_adjtime (CLOCK_REALTIME, &delta); > > + int ret =3D TST_ADJTIME_SYSCALL TST_ADJTIME_ARGS; > > if (ret =3D=3D -1) > > FAIL_EXIT1 ("clock_adjtime failed: %m\n"); > > =20 > > =20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/g2aq38cA2XAScG6Rumb70=v Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmA+PDkACgkQAR8vZIA0 zr0vkQgAwmaDxOy6eFe0hjG65WlbFx2X6XUBPcgo+zFr8n/X7Fvv9595Bv+WhnpQ uvnQXD4uHp/++xfqcokIf64gJ9ok9JtszSWWnUpKPWSuyWwk76KzA9LbhwJnh2RJ WpgQ35oCC28KoHAlRNwhVGevghLcxi4h/eHgDJNXX/vpMeHjLkBFhc4zX9wTerJ4 pcSVNE4VNna7PTLzrSBuTKWHnAWAGPtHyLmBvZUWSDQJ9b5ObOBKPgUkgHezk017 EwoRtrDhXRFklPA3J59kN8e3OYPpZy0AxdSu0HN4yHIPYW4u0/cxVBjgtbrBcIuN jBcyB8lDhZGpcSUSehELEcMd9QLcVg== =QB3H -----END PGP SIGNATURE----- --Sig_/g2aq38cA2XAScG6Rumb70=v--