public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 09/52] io: Add basic tests for utimensat
Date: Fri,  5 Mar 2021 17:14:35 -0300	[thread overview]
Message-ID: <20210305201518.798584-10-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20210305201518.798584-1-adhemerval.zanella@linaro.org>

Checked on x86_64-linux-gnu and i686-linux-gnu
---
 io/Makefile        |   2 +-
 io/tst-utimensat.c | 115 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 116 insertions(+), 1 deletion(-)
 create mode 100644 io/tst-utimensat.c

diff --git a/io/Makefile b/io/Makefile
index b7bebe923f..59d36e8782 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -68,7 +68,7 @@ tests		:= test-utime test-stat test-stat2 test-lfs tst-getcwd \
 		   tst-fts tst-fts-lfs tst-open-tmpfile \
 		   tst-copy_file_range tst-getcwd-abspath tst-lockf \
 		   tst-ftw-lnk tst-file_change_detection tst-lchmod \
-		   tst-ftw-bz26353
+		   tst-ftw-bz26353 tst-utimensat
 
 # Likewise for statx, but we do not need static linking here.
 tests-internal += tst-statx
diff --git a/io/tst-utimensat.c b/io/tst-utimensat.c
new file mode 100644
index 0000000000..b62e409e07
--- /dev/null
+++ b/io/tst-utimensat.c
@@ -0,0 +1,115 @@
+/* utimensat basic tests.
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <time.h>
+#include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+#include <support/check.h>
+#include <support/support.h>
+#include <support/temp_file.h>
+#include <support/xunistd.h>
+
+#ifndef struct_stat
+# define struct_stat struct stat64
+#endif
+
+static int temp_fd = -1;
+static char *testfile;
+static char *testlink;
+
+/* struct timeval array with Y2038 threshold minus 2 and 1 seconds.  */
+const static struct timespec t1[2] = { { 0x7FFFFFFE, 0 },
+				       { 0x7FFFFFFF, 0 } };
+
+/* struct timeval array with Y2038 threshold plus 1 and 2 seconds.  */
+const static struct timespec t2[2] = { { 0x80000001ULL, 0 },
+				       { 0x80000002ULL, 0 } };
+
+/* struct timeval array around Y2038 threshold.  */
+const static struct timespec t3[2] = { { 0x7FFFFFFE, 0 },
+				       { 0x80000002ULL, 0 } };
+
+static void
+do_prepare (int argc, char *argv[])
+{
+  temp_fd = create_temp_file ("tst-utimensat", &testfile);
+  TEST_VERIFY_EXIT (temp_fd > 0);
+
+  testlink = xasprintf ("%s-symlink", testfile);
+  xsymlink (testfile, testlink);
+  add_temp_file (testlink);
+}
+#define PREPARE do_prepare
+
+static void
+test_utimensat_helper (const struct timespec ts[2])
+{
+  /* Check if we run on port with 32 bit time_t size */
+  {
+    time_t t;
+    if (__builtin_add_overflow (ts->tv_sec, 0, &t))
+      return;
+  }
+
+  {
+    TEST_VERIFY_EXIT (utimensat (temp_fd, testfile, ts, 0) == 0);
+
+    struct_stat st;
+    xfstat (temp_fd, &st);
+
+    /* Check if seconds for atime match */
+    TEST_COMPARE (st.st_atime, ts[0].tv_sec);
+
+    /* Check if seconds for mtime match */
+    TEST_COMPARE (st.st_mtime, ts[1].tv_sec);
+  }
+
+  {
+    struct_stat stfile_orig;
+    xlstat (testfile, &stfile_orig);
+
+    TEST_VERIFY_EXIT (utimensat (0 /* ignored  */, testlink, ts,
+				 AT_SYMLINK_NOFOLLOW)
+		       == 0);
+    struct_stat stlink;
+    xlstat (testlink, &stlink);
+
+    TEST_COMPARE (stlink.st_atime, ts[0].tv_sec);
+    TEST_COMPARE (stlink.st_mtime, ts[1].tv_sec);
+
+    /* Check if the timestamp from original file is not changed.  */
+    struct_stat stfile;
+    xlstat (testfile, &stfile);
+
+    TEST_COMPARE (stfile_orig.st_atime, stfile.st_atime);
+    TEST_COMPARE (stfile_orig.st_mtime, stfile.st_mtime);
+  }
+}
+
+static int
+do_test (void)
+{
+  test_utimensat_helper (t1);
+  test_utimensat_helper (t2);
+  test_utimensat_helper (t3);
+
+  return 0;
+}
+
+#include <support/test-driver.c>
-- 
2.25.1


  parent reply	other threads:[~2021-03-05 20:15 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 20:14 [PATCH 00/52] Add 64 bit time support on legacy ABIs Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 01/52] io: Use temporary directory and file for ftwtest-sh Adhemerval Zanella
2021-03-05 20:56   ` Andreas Schwab
2021-03-05 23:53   ` Joseph Myers
2021-03-08 13:00     ` Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 02/52] linux: Add futimes test Adhemerval Zanella
2021-03-05 20:30   ` Florian Weimer
2021-03-08 13:01     ` Adhemerval Zanella
2021-03-08 13:08       ` Florian Weimer
2021-03-08 13:26         ` Adhemerval Zanella
2021-03-08 13:30           ` Florian Weimer
2021-03-05 20:33   ` Florian Weimer
2021-03-08 13:02     ` Adhemerval Zanella
2021-03-08 13:23       ` Adhemerval Zanella
2021-03-06  0:02   ` Joseph Myers
2021-03-06  3:52     ` Paul Zimmermann
2021-03-08 13:03     ` Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 03/52] linux: Add lutimes test Adhemerval Zanella
2021-03-05 20:31   ` Florian Weimer
2021-03-06  0:02   ` Joseph Myers
2021-03-05 20:14 ` [PATCH 04/52] time: Add getitimer and setitimer basic tests Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 05/52] time: Add gmtime/gmtime_r tests Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 06/52] time: Add timegm/timelocal basic tests Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 07/52] time: Add basic timespec_get tests Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 08/52] time: Add 64 bit tests for getdate / getdate_r Adhemerval Zanella
2021-03-05 20:14 ` Adhemerval Zanella [this message]
2021-03-05 20:14 ` [PATCH 10/52] posix: Add wait3 tests Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 11/52] linux: mips: Split libpthread.abilist in n32 and n64 Adhemerval Zanella
2021-03-05 20:39   ` Florian Weimer
2021-03-08 13:05     ` Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 12/52] linux: mips: Split librt.abilist " Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 13/52] linux: mips: Split libanl.abilist " Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 14/52] linux: s390: Add libanl.abilist in s390 and s390x Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 15/52] login: Consolidate utmp and utmpx headers Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 16/52] login: Move gnu utmpx to default implementation Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 17/52] Consolidate and simplify internal utmp definitions Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 18/52] support: Add 'touch' command Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 19/52] Add tests-container-internal rules Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 20/52] login: Add 64-bit time support to utmp/utmpx Adhemerval Zanella
2021-04-27 12:30   ` Florian Weimer
2021-04-27 13:58     ` Andreas Schwab
2021-04-27 14:18       ` Florian Weimer
2021-04-27 14:51         ` Andreas Schwab
2021-04-27 18:03     ` Joseph Myers
2021-04-30 10:03       ` Florian Weimer
2021-04-30 12:17         ` Andreas Schwab
2021-04-30 12:22           ` Florian Weimer
2021-04-30 14:11             ` Andreas Schwab
2021-03-05 20:14 ` [PATCH 21/52] linux: Add pwrite64_nocancel Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 22/52] login: Use 64-bit time on struct lastlog [BZ #25844] Adhemerval Zanella
2021-03-06  0:07   ` Joseph Myers
2021-03-08 13:05     ` Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 23/52] Remove __WORDSIZE_TIME64_COMPAT32 Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 24/52] linux: Add fallback for 64-bit time_t SO_{RCV, SND}TIMEO Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 25/52] linux: Add fallback for 64-bit time_t SO_TIMESTAMP{NS} Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 26/52] linux: Add recvvmsg " Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 27/52] y2038: Add __USE_TIME_BITS64 support for time_t Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 28/52] y2038: Add __USE_TIME_BITS64 support for struct timeval Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 29/52] y2038: Add __USE_TIME_BITS64 support for struct timespec Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 30/52] y2038: Add __USE_TIME_BITS64 support for struct utimbuf Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 31/52] y2038: linux: Add __USE_TIME_BITS64 support for struct timex Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 32/52] y2038: Use a common definition for stat Adhemerval Zanella
2021-03-05 20:14 ` [PATCH 33/52] y2038: Use a common definition for msqid_ds Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 34/52] y2038: Use a common definition for semid_ds Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 35/52] y2038: Use a common definition for shmid_ds Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 36/52] y2038: Add __USE_TIME_BITS64 support for socket-constants.h Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 37/52] time: Add 64 bit time support for getdate Adhemerval Zanella
2021-03-08 21:27   ` Lukasz Majewski
2021-03-05 20:15 ` [PATCH 38/52] y2038: Add support for 64 bit time on legacy ABIs Adhemerval Zanella
2021-03-08 21:27   ` Lukasz Majewski
2021-03-05 20:15 ` [PATCH 39/52] posix: Add glob64 with 64 bit time_t support Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 40/52] io: Add fts64 " Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 41/52] io: Add ftw64 " Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 42/52] libsupport: Add 64 bit time_t support for time functions Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 43/52] libsupport: Add 64 bit time_t support for stat functions Adhemerval Zanella
2021-03-05 20:42   ` Florian Weimer
2021-03-08 13:06     ` Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 44/52] y2038: Add test coverage Adhemerval Zanella
2021-03-06  0:13   ` Joseph Myers
2021-03-08 13:12     ` Adhemerval Zanella
2021-03-08 21:28   ` Lukasz Majewski
2021-03-05 20:15 ` [PATCH 45/52] Use 64 bit time_t stat internally Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 46/52] debug: build pcprofiledump with LFS and 64 bit time support Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 47/52] elf: Use LFS and 64 bit time_t for installed programs Adhemerval Zanella
2021-03-05 20:43   ` Florian Weimer
2021-03-08 13:14     ` Adhemerval Zanella
2021-03-08 15:26       ` Florian Weimer
2021-03-05 20:15 ` [PATCH 48/52] iconv: " Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 49/52] locale: " Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 50/52] nss: " Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 51/52] posix: " Adhemerval Zanella
2021-03-05 20:15 ` [PATCH 52/52] timezone: " Adhemerval Zanella
2021-03-05 23:57 ` [PATCH 00/52] Add 64 bit time support on legacy ABIs Joseph Myers
2021-03-08 13:18   ` Adhemerval Zanella
2021-03-07 10:42 ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305201518.798584-10-adhemerval.zanella@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).