From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 2/3] Disable stack protector for ifunc resolvers in tests
Date: Tue, 9 Mar 2021 23:42:58 +0530 [thread overview]
Message-ID: <20210309181259.2603144-3-siddhesh@sourceware.org> (raw)
In-Reply-To: <20210309181259.2603144-1-siddhesh@sourceware.org>
IFUNC resolvers get called too early for stack protector to be useful,
so fix the elf tests to disable stack protector for the resolver
functions. This fixes test failures in the static tests on x86_64.
---
elf/ifuncmain9.c | 1 +
sysdeps/x86/tst-ifunc-isa.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index 2c4e95a051..e775c5cfa9 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -43,6 +43,7 @@ implementation (void)
}
static __typeof__ (implementation) *
+inhibit_stack_protector
resolver (void)
{
++resolver_called;
diff --git a/sysdeps/x86/tst-ifunc-isa.h b/sysdeps/x86/tst-ifunc-isa.h
index 60aa1cea6a..6d906966a7 100644
--- a/sysdeps/x86/tst-ifunc-isa.h
+++ b/sysdeps/x86/tst-ifunc-isa.h
@@ -29,6 +29,7 @@ enum isa
};
enum isa
+__attribute__ ((__optimize__ ("-fno-stack-protector")))
get_isa (void)
{
if (CPU_FEATURE_USABLE (AVX512F))
@@ -83,6 +84,7 @@ isa_none (void)
int foo (void) __attribute__ ((ifunc ("foo_ifunc")));
void *
+__attribute__ ((__optimize__ ("-fno-stack-protector")))
foo_ifunc (void)
{
switch (get_isa ())
--
2.29.2
next prev parent reply other threads:[~2021-03-09 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 18:12 [PATCH 0/3] Clean up stack-protector-all build Siddhesh Poyarekar
2021-03-09 18:12 ` [PATCH 1/3] Build get-cpuid-feature-leaf.c without stack-protector Siddhesh Poyarekar
2021-03-10 7:58 ` Florian Weimer
2021-03-09 18:12 ` Siddhesh Poyarekar [this message]
2021-03-10 7:59 ` [PATCH 2/3] Disable stack protector for ifunc resolvers in tests Florian Weimer
2021-03-10 9:38 ` Siddhesh Poyarekar
2021-03-10 9:39 ` Florian Weimer
2021-03-10 9:57 ` Siddhesh Poyarekar
2021-03-09 18:12 ` [PATCH 3/3] Build libc-start with stack protector for SHARED Siddhesh Poyarekar
2021-03-10 8:00 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309181259.2603144-3-siddhesh@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).