From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>, DJ Delorie <dj@redhat.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fw@deneb.enyo.de>,
Zack Weinberg <zackw@panix.com>, Lukasz Majewski <lukma@denx.de>
Subject: [PATCH v2 1/2] tst: Add test for ntp_gettime
Date: Wed, 10 Mar 2021 14:00:55 +0100 [thread overview]
Message-ID: <20210310130056.23926-1-lukma@denx.de> (raw)
This code provides test to check if time on target machine is properly
read via ntp_gettime syscall.
---
Changes for v2:
- Check time before and after calling ntp_gettime{x} to avoid situation
when seconds rollover between call to ntp_gettime and wrapper providing
current time.
---
sysdeps/unix/sysv/linux/Makefile | 2 +-
sysdeps/unix/sysv/linux/tst-ntp_gettime.c | 56 +++++++++++++++++++++++
2 files changed, 57 insertions(+), 1 deletion(-)
create mode 100644 sysdeps/unix/sysv/linux/tst-ntp_gettime.c
diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
index b8c1caa505..8a07870cb4 100644
--- a/sysdeps/unix/sysv/linux/Makefile
+++ b/sysdeps/unix/sysv/linux/Makefile
@@ -113,7 +113,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \
tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \
tst-timerfd tst-ppoll tst-futimens tst-utime tst-utimes \
tst-clock_adjtime tst-adjtimex tst-ntp_adjtime tst-futimes \
- tst-lutimes
+ tst-lutimes tst-ntp_gettime
tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc
tests-time64 += \
tst-futimes-time64\
diff --git a/sysdeps/unix/sysv/linux/tst-ntp_gettime.c b/sysdeps/unix/sysv/linux/tst-ntp_gettime.c
new file mode 100644
index 0000000000..6cd3a0ec2c
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/tst-ntp_gettime.c
@@ -0,0 +1,56 @@
+/* Test for ntp_gettime
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <stdlib.h>
+#include <sys/timex.h>
+#include <support/check.h>
+#include <support/xtime.h>
+
+#ifndef NTP_GETTIME_SYSCALL
+# define NTP_GETTIME_SYSCALL ntp_gettime
+#endif
+
+#define STR(__s) #__s
+
+static int
+do_test (void)
+{
+ struct timespec tv_before_ntp, tv_after_ntp;
+ struct ntptimeval ntv;
+
+ /* To prevent seconds rollover (which is very unlikely though),
+ loop until we do match seconds values before and after
+ call to ntp_gettime. */
+ do {
+ tv_before_ntp = xclock_now (CLOCK_REALTIME);
+
+ int ret = NTP_GETTIME_SYSCALL (&ntv);
+ if (ret == -1)
+ FAIL_EXIT1 (STR(NTP_GETTIME_SYSCALL)" failed: %m\n");
+
+ tv_after_ntp = xclock_now (CLOCK_REALTIME);
+ } while (tv_after_ntp.tv_sec != tv_before_ntp.tv_sec);
+
+ if (tv_after_ntp.tv_sec != ntv.time.tv_sec)
+ FAIL_EXIT1 (STR(NTP_GETTIME_SYSCALL)" provided wrong time!\n");
+
+ return 0;
+}
+
+#include <support/test-driver.c>
--
2.20.1
next reply other threads:[~2021-03-10 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 13:00 Lukasz Majewski [this message]
2021-03-10 13:00 ` [PATCH v2 2/2] tst: Add test for ntp_gettimex Lukasz Majewski
2021-03-22 20:23 ` Adhemerval Zanella
2021-03-17 12:23 ` [PATCH v2 1/2] tst: Add test for ntp_gettime Lukasz Majewski
2021-03-22 20:22 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310130056.23926-1-lukma@denx.de \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).