From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id AC40A3858D33 for ; Mon, 15 Mar 2021 13:56:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AC40A3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DzdHj4tLDz1qsbS; Mon, 15 Mar 2021 14:56:17 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DzdHj4Cf2z1qqkW; Mon, 15 Mar 2021 14:56:17 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id d8MQvIjHXc3j; Mon, 15 Mar 2021 14:56:16 +0100 (CET) X-Auth-Info: SfuUHq6KpiuowMI6yhHy0TARh30GRHKlG0I5USqP0yw= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 15 Mar 2021 14:56:16 +0100 (CET) Date: Mon, 15 Mar 2021 14:56:09 +0100 From: Lukasz Majewski To: Andreas Schwab Cc: Joseph Myers , Adhemerval Zanella , Florian Weimer , GNU C Library Subject: Re: [PATCH] tst: Provide test for getrusage Message-ID: <20210315145609.443f55ec@jawa> In-Reply-To: <87wnu83cun.fsf@igel.home> References: <20210315104223.32542-1-lukma@denx.de> <87wnu83cun.fsf@igel.home> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/xo9g76uWSrpEi98Voe1.ZMS"; protocol="application/pgp-signature" X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 13:56:20 -0000 --Sig_/xo9g76uWSrpEi98Voe1.ZMS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Andreas, > On M=C3=A4r 15 2021, Lukasz Majewski wrote: >=20 > > diff --git a/sysdeps/unix/sysv/linux/tst-getrusage.c > > b/sysdeps/unix/sysv/linux/tst-getrusage.c new file mode 100644 > > index 0000000000..068becdadb > > --- /dev/null > > +++ b/sysdeps/unix/sysv/linux/tst-getrusage.c > > @@ -0,0 +1,55 @@ > > +/* Test for getrusage > > + Copyright (C) 2021 Free Software Foundation, Inc. > > + This file is part of the GNU C Library. > > + > > + The GNU C Library is free software; you can redistribute it > > and/or > > + modify it under the terms of the GNU Lesser General Public > > + License as published by the Free Software Foundation; either > > + version 2.1 of the License, or (at your option) any later > > version. + > > + The GNU C Library is distributed in the hope that it will be > > useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > GNU > > + Lesser General Public License for more details. > > + > > + You should have received a copy of the GNU Lesser General Public > > + License along with the GNU C Library; if not, see > > + . */ > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#define TST_GETRUSAGE_TIMEOUT 1 > > + > > +static int > > +do_test (void) > > +{ > > + struct timespec tv_then, tv_now, gru_u, gru_s, s, r; > > + struct rusage ru; > > + int ret; > > + > > + tv_then =3D xclock_now (CLOCK_REALTIME); > > + /* Busy wait for 1 second. */ > > + do > > + { > > + tv_now =3D xclock_now (CLOCK_REALTIME); > > + r =3D timespec_sub (tv_now, tv_then); > > + } while ( r.tv_sec !=3D TST_GETRUSAGE_TIMEOUT ); =20 >=20 > What happens if the process stalls for a second? I think that the glibc's test infrastructure will kill it - the default timeout is 2 seconds. As a result the test will fail. >=20 > Andreas. >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/xo9g76uWSrpEi98Voe1.ZMS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmBPZ3kACgkQAR8vZIA0 zr0M4ggA5PdoQ/xxox21rbhAz1Q8Yba+8HjFWJOYt6P0l+vqPy2u44dMS/AYtCxL c/QntZr3rFDuczLuZ0oDn4VY0E+PBCMvdO734KB6zDLCgo/mo68JD58IxCBQBNEH CY/GnxBYKSFOuQV4OdGlM13NPuy+9lNZrjE9tmXrP9cnbtYEy4e0xfFtosZPM36R BTsekl2Ukz6aTFIjF44Jw5IK775T8A12GA2rMeqCIQJNhvLYdeoBHCQtSe8tCADC qysMo/fU+VQm7kz8GpF9W55Su3kjOOx22TJSYwGca9CJ2/r/o+WaOql2k8lzbQiX jNalxGcpsRVpqSI3jOcwyl+FvnJxEw== =Jtdo -----END PGP SIGNATURE----- --Sig_/xo9g76uWSrpEi98Voe1.ZMS--