From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 7A5E73858004 for ; Tue, 16 Mar 2021 09:06:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A5E73858004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F06pz3SPgz1sQrt; Tue, 16 Mar 2021 10:06:35 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F06pz0w2rz1qqkL; Tue, 16 Mar 2021 10:06:35 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Xp-S4GWWxTgU; Tue, 16 Mar 2021 10:06:33 +0100 (CET) X-Auth-Info: os5g2WVBRaAxfw8pZfbP7AByq/vWl6KnXRCSRb/5Hj4= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 16 Mar 2021 10:06:33 +0100 (CET) Date: Tue, 16 Mar 2021 10:06:25 +0100 From: Lukasz Majewski To: Florian Weimer , Adhemerval Zanella Cc: Joseph Myers , GNU C Library Subject: Re: [PATCH] support: arm: Add libc_do_syscall function to libsupport routines Message-ID: <20210316100625.76b8fc70@jawa> In-Reply-To: <87k0q7smyt.fsf@oldenburg.str.redhat.com> References: <20210315154723.11687-1-lukma@denx.de> <87eeggtnqx.fsf@oldenburg.str.redhat.com> <20210315231445.2e24b412@jawa> <87k0q7smyt.fsf@oldenburg.str.redhat.com> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/iBk_772GdLPQ=FFXZH=0TA5"; protocol="application/pgp-signature" X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 09:06:37 -0000 --Sig_/iBk_772GdLPQ=FFXZH=0TA5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Florian, > * Lukasz Majewski: >=20 > > Hi Florian, > > =20 > >> * Lukasz Majewski: > >> =20 > >> > It fixes the following error on ARM 32 bit port: > >> > > >> > y2038-glibc/support/support_path_support_time64.c:34: undefined > >> > reference to `__libc_do_syscall' > >> > collect2: error: ld returned 1 exit status =20 > >>=20 > >> Should libsupport use syscall for direct system calls? =20 > > > > I'm not sure what is the correct approach here. > > > > In my case - armv7, 32 bit - in > > support/support_path_support_time64.c the utimensat_time64 syscall > > is called, which is wrapped to INLINE_SYSCALL_CALL(), which calls > > __libc_do_syscall ASM ARM function. > > > > This function is only defined for i386 and 32 bit ARM (in e.g. > > sysdeps/unix/sysv/linux/{arm|i386}/libc-do-syscall.S) =20 >=20 > Yes, and using the syscall function would avoid this issue. >=20 > So the question is, why INLINE_SYSCALL_CALL? Good question - I guess that Adhemerval would know why it was necessary. >=20 > Thanks, > Florian >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/iBk_772GdLPQ=FFXZH=0TA5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmBQdREACgkQAR8vZIA0 zr0ClwgA117p7c6AGSDR/VxgRDeo6PockJtbV8/u8Sd1ZfmpsKTLQR15X+fCePDB TGbJ8Rz0jkeiTQWtqsls+QMRaMo+n7vL+etWZmFXUeBV0A3sExK8U4t4URRdAIsg NzxDUVVUnscFQFBwNMkhhHGwi6BJQ3OO5KYMW/pqMWS0RGEh/BL7ykXjAqKBllfb xKR3siEq1VgQLbWWggjrrEjr7pwwwTiKK93dt7VXn4Tw3QdEHDL8jgiorfnIR1Ma Ydyds8JtUC27O4lgw108M8NCLxNo8YKChPJlW1OI8csPQO8bgve7RGUaHnfSxOWJ IboTMF7rNRkbJcCeHvzhFc2xazz/oA== =mMHY -----END PGP SIGNATURE----- --Sig_/iBk_772GdLPQ=FFXZH=0TA5--