From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 77663385041B for ; Tue, 16 Mar 2021 14:17:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 77663385041B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F0FkG2ZLsz1rx88; Tue, 16 Mar 2021 15:17:58 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F0FkG0kxLz1qqlD; Tue, 16 Mar 2021 15:17:58 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 7rWQ9NaAN9fh; Tue, 16 Mar 2021 15:17:57 +0100 (CET) X-Auth-Info: l5l4rEHPINrXjFU+16w/uaqSavH9PL/GNyqYJcvAEaE= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 16 Mar 2021 15:17:57 +0100 (CET) Date: Tue, 16 Mar 2021 15:17:50 +0100 From: Lukasz Majewski To: Adhemerval Zanella Cc: Florian Weimer , Joseph Myers , GNU C Library Subject: Re: [PATCH] support: arm: Add libc_do_syscall function to libsupport routines Message-ID: <20210316151750.54fd949e@jawa> In-Reply-To: References: <20210315154723.11687-1-lukma@denx.de> <87eeggtnqx.fsf@oldenburg.str.redhat.com> <20210315231445.2e24b412@jawa> <87k0q7smyt.fsf@oldenburg.str.redhat.com> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/Iqn8Eab4Zzdt6lh272HLeJR"; protocol="application/pgp-signature" X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 14:18:02 -0000 --Sig_/Iqn8Eab4Zzdt6lh272HLeJR Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > On 16/03/2021 02:10, Florian Weimer wrote: > > * Lukasz Majewski: > > =20 > >> Hi Florian, > >> =20 > >>> * Lukasz Majewski: > >>> =20 > >>>> It fixes the following error on ARM 32 bit port: > >>>> > >>>> y2038-glibc/support/support_path_support_time64.c:34: undefined > >>>> reference to `__libc_do_syscall' > >>>> collect2: error: ld returned 1 exit status =20 > >>> > >>> Should libsupport use syscall for direct system calls? =20 > >> > >> I'm not sure what is the correct approach here. > >> > >> In my case - armv7, 32 bit - in > >> support/support_path_support_time64.c the utimensat_time64 syscall > >> is called, which is wrapped to INLINE_SYSCALL_CALL(), which calls > >> __libc_do_syscall ASM ARM function. > >> > >> This function is only defined for i386 and 32 bit ARM (in e.g. > >> sysdeps/unix/sysv/linux/{arm|i386}/libc-do-syscall.S) =20 > >=20 > > Yes, and using the syscall function would avoid this issue. > >=20 > > So the question is, why INLINE_SYSCALL_CALL? =20 >=20 > The __libc_do_syscall is in fact only used thumb mode used as default, > and the direct syscall is used because there is no direct support > for using 64 bit types on ABI with default 32 bit time. We might=20 > eventually remove the INLINE_SYSCALL_CALL once 64 bit time support is=20 > implemented (so we build the file with _TIME_SIZE=3D64). >=20 > The patch itself looks ok. Thanks for review. I will apply it if Florian don't mind. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/Iqn8Eab4Zzdt6lh272HLeJR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmBQvg4ACgkQAR8vZIA0 zr2UbAgA3GW2Rfn7tAreHL+Ohsg2VxbX2axRXjnL4W6+s7fnw3eKC+KL7iQCd3dD FBY6vKxj4pEsH0AsfJzro+Oc4CoHZAhCQJ5piHG718xd6uNecwDpXH/9cYH8RkhS LIalPdS99kEpTm3i14CqrIb/CoTdR2+k/hCv7tz+RIFLKmwtR+2B35AkVAUJGaHd ue9kf6RxW1IT6lQ1N3Yyp3ZhziqZdhD7wHQQU+0xxjrptY2+erYB6nFFKHuqHIxx b52oH4mDQW49tPWHf5iJsJh5GCopHSXIXzzSyuXOQW0PLQXfmMl5vm7B59vHlNMK 2MdFWHi3u94Z/kHsWfLWMFoMGHSsIA== =0IK6 -----END PGP SIGNATURE----- --Sig_/Iqn8Eab4Zzdt6lh272HLeJR--