From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 33CB03858004 for ; Mon, 22 Mar 2021 11:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33CB03858004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F3sf328V4z1ryX5; Mon, 22 Mar 2021 12:26:51 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F3sf313jqz1qv9w; Mon, 22 Mar 2021 12:26:51 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id zeDM48mdoAiD; Mon, 22 Mar 2021 12:26:48 +0100 (CET) X-Auth-Info: L5iq/dNREVjRD2eMKz660y3EucZeWQTj1YMCD5soTw4= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 22 Mar 2021 12:26:48 +0100 (CET) Date: Mon, 22 Mar 2021 12:26:42 +0100 From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella Cc: Paul Eggert , Arnd Bergmann , GNU C Library , Florian Weimer , Carlos O'Donell Subject: Re: [PATCH] tst: Add test for sigtimedwait Message-ID: <20210322122642.25605fe3@jawa> In-Reply-To: <20210315114239.9070-1-lukma@denx.de> References: <20210315114239.9070-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/4z6/N2F3COtOBm+Blolpbb0"; protocol="application/pgp-signature" X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 11:26:56 -0000 --Sig_/4z6/N2F3COtOBm+Blolpbb0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Dear Community, > This change adds new test to assess sigtimedwait's timeout related > functionality - the sigset_t is configured for SIGUSR1, which will > not be triggered, so sigtimedwait just waits for timeout. >=20 > To be more specific - two use cases are checked: > - if sigtimedwait times out immediately when passed struct timespec > has zero values of tv_nsec and tv_sec. > - if sigtimedwait times out after timeout specified in passed argument Gentle ping on this test. > --- > sysdeps/unix/sysv/linux/Makefile | 5 +- > sysdeps/unix/sysv/linux/tst-sigtimedwait.c | 61 > ++++++++++++++++++++++ 2 files changed, 64 insertions(+), 2 > deletions(-) create mode 100644 > sysdeps/unix/sysv/linux/tst-sigtimedwait.c >=20 > diff --git a/sysdeps/unix/sysv/linux/Makefile > b/sysdeps/unix/sysv/linux/Makefile index 41798feb35..a3eba0db01 100644 > --- a/sysdeps/unix/sysv/linux/Makefile > +++ b/sysdeps/unix/sysv/linux/Makefile > @@ -113,8 +113,9 @@ tests +=3D tst-clone tst-clone2 tst-clone3 > tst-fanotify tst-personality \ tst-tgkill tst-sysvsem-linux > tst-sysvmsg-linux tst-sysvshm-linux \ tst-timerfd tst-ppoll > tst-futimens tst-utime tst-utimes \ tst-clock_adjtime tst-adjtimex > tst-ntp_adjtime tst-futimes \ > - tst-lutimes tst-ntp_gettime tst-ntp_gettimex tst-getrusage > - > + tst-lutimes tst-ntp_gettime tst-ntp_gettimex tst-getrusage \ > + tst-sigtimedwait > +=09 > # Test for the symbol version of fcntl that was replaced in glibc > 2.28. ifeq ($(have-GLIBC_2.27)$(build-shared),yesyes) > tests +=3D tst-ofdlocks-compat > diff --git a/sysdeps/unix/sysv/linux/tst-sigtimedwait.c > b/sysdeps/unix/sysv/linux/tst-sigtimedwait.c new file mode 100644 > index 0000000000..95a1b59592 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/tst-sigtimedwait.c > @@ -0,0 +1,61 @@ > +/* Test for sigtimedwait timeout > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static int test_sigtimedwait_timeout (bool zero_tmo) > +{ > + /* We wait for half a second. */ > + struct timespec ts; > + xclock_gettime (CLOCK_REALTIME, &ts); > + struct timespec timeout =3D make_timespec (0, zero_tmo ? 0 : > TIMESPEC_HZ/2); > + ts =3D timespec_add (ts, timeout); > + > + /* Set sigset to just wait for timeout. */ > + sigset_t ss_usr1; > + sigemptyset (&ss_usr1); > + sigaddset (&ss_usr1, SIGUSR1); > + > + int ret =3D sigtimedwait (&ss_usr1, NULL, &timeout); > + if (ret !=3D -1) > + FAIL_EXIT1 ("sigtimedwait failed: %m\n"); > + > + TEST_TIMESPEC_NOW_OR_AFTER (CLOCK_REALTIME, ts); > + > + return 0; > +} > + > +static int > +do_test (void) > +{ > + /* Check if sigtimedwait exits immediately. */ > + test_sigtimedwait_timeout (true); > + > + /* Check if sigtimedwait exits after specified timeout. */ > + test_sigtimedwait_timeout (false); > + > + return 0; > +} > + > +#include Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/4z6/N2F3COtOBm+Blolpbb0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmBYfvIACgkQAR8vZIA0 zr0FGQgA55u3GRqlycBAw6oTm4fVoexlHqrSTK16/BRBPQG+49zU1++7BEhDKuAo Wg3tPFFOz3N3HhTjuhokdyJNOiUr1/OyvF0fcSHXCiZ68FpHGa2yW0SSilyv8Lww 7ql4BDWwcDVseEMQq0QP2FXGf3AavdtRG93GH/CzzzT/o2jA8e+jwKtCbC4MqnK6 9Gf1U7eSQVvoMl4Lz9u095JhV/vvBM2C5NdiCmvXBo+IePaSBEzq+f0HRhlaex5a NtETpqbLQsvOP5nH8qjmi/mLP1ygKu3UwUlv+UNICYl08/MMeRJHlZZx7W5ffHk5 5R+idRnTKk7qXiI/jqd4wXKsOKS+IA== =SAzQ -----END PGP SIGNATURE----- --Sig_/4z6/N2F3COtOBm+Blolpbb0--