From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 1675E3851C24 for ; Wed, 24 Mar 2021 12:31:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1675E3851C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@ens-lyon.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E2817140; Wed, 24 Mar 2021 13:31:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pxqfd-3lXZG1; Wed, 24 Mar 2021 13:31:41 +0100 (CET) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 3D47DB5; Wed, 24 Mar 2021 13:31:37 +0100 (CET) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1lP2fg-002YWH-9P; Wed, 24 Mar 2021 13:31:36 +0100 Date: Wed, 24 Mar 2021 13:31:36 +0100 From: Samuel Thibault To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [hurd,commited] htl: Add missing fork.h Message-ID: <20210324123136.x5ab7fkrcm557enm@begin> References: <20210324002015.338244-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: E2817140 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_TWO(0.00)[2]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 12:31:50 -0000 Adhemerval Zanella, le mer. 24 mars 2021 09:29:44 -0300, a ecrit: > On 23/03/2021 21:20, Samuel Thibault wrote: > > 2b47727c68b6 ("posix: Consolidate register-atfork") introduced a fork.h > > header to declare the atfork unregister hook, but was missing adding it > > for htl. > > > > This fixes tst-atfork2. > > Both lowlevellock.h and register-atfork.h are common headers, > I think it would be better to just add them to generic fork.h header. Ok but perhaps there was a reason why you didn't do it in your commit? Samuel