From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id B57193857C50 for ; Wed, 24 Mar 2021 13:00:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B57193857C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@ens-lyon.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 86A0263F; Wed, 24 Mar 2021 14:00:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id di8FbwXVMic0; Wed, 24 Mar 2021 14:00:41 +0100 (CET) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D3010140; Wed, 24 Mar 2021 14:00:40 +0100 (CET) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1lP37n-002Zjq-HH; Wed, 24 Mar 2021 14:00:39 +0100 Date: Wed, 24 Mar 2021 14:00:39 +0100 From: Samuel Thibault To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [hurd,commited] htl: Add missing fork.h Message-ID: <20210324130039.stnuexy2tw7wnkuf@begin> References: <20210324002015.338244-1-samuel.thibault@ens-lyon.org> <20210324123136.x5ab7fkrcm557enm@begin> <6aa8826c-b8ab-d999-4b99-e61c27282587@linaro.org> <20210324124532.sp6nkal764gwyatj@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: 86A0263F X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_TWO(0.00)[2]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 13:00:44 -0000 Adhemerval Zanella, le mer. 24 mars 2021 09:56:47 -0300, a ecrit: > On 24/03/2021 09:45, Samuel Thibault wrote: > > Adhemerval Zanella, le mer. 24 mars 2021 09:40:36 -0300, a ecrit: > > > Why exactly tst-atfork2 fails without this includes? > > > > It misses the atfork unregister hook called at module unload. > > Ok, but *why* exactly? The sysdeps/htl/pt-atfork.c already > includes register-atfork.h after the fork.h inclusion. It's not pt-atfork.c which needs UNREGISTER_ATFORK, but stdlib/cxa_finalize, which gets it from fork.h Samuel