From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id CEA4F3851C24 for ; Wed, 24 Mar 2021 20:59:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CEA4F3851C24 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 0B891952; Wed, 24 Mar 2021 21:59:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9CluDNeG3Dom; Wed, 24 Mar 2021 21:59:04 +0100 (CET) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0F96A237; Wed, 24 Mar 2021 21:59:03 +0100 (CET) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1lPAak-004B0w-LO; Wed, 24 Mar 2021 21:59:02 +0100 Date: Wed, 24 Mar 2021 21:59:02 +0100 From: Samuel Thibault To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, commit-hurd@gnu.org Subject: Re: [PATCH] stdlib: Fix BZ #26241 testcase on GNU/Hurd Message-ID: <20210324205902.stb2a6olgo3tppq3@begin> References: <20210324003822.341322-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- X-Rspamd-Server: hera X-Rspamd-Queue-Id: 0B891952 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 20:59:08 -0000 Adhemerval Zanella, le mer. 24 mars 2021 10:04:51 -0300, a ecrit: > > > On 23/03/2021 21:38, Samuel Thibault wrote: > > GNU/Hurd's readlink system call is partly implemented in userspace, which > > also allocates a buffer on the stack for the result, and thus needs one > > more path. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella > > > --- > > stdlib/tst-canon-bz26341.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/stdlib/tst-canon-bz26341.c b/stdlib/tst-canon-bz26341.c > > index 6d054596b5..0ddd9aed15 100644 > > --- a/stdlib/tst-canon-bz26341.c > > +++ b/stdlib/tst-canon-bz26341.c > > @@ -72,10 +72,11 @@ do_realpath (void *arg) > > If realpath uses more than 2 * PATH_MAX plus some slack it will trigger > > a stackoverflow. */ > > + const size_t syscall_usage = 1 * PATH_MAX + 1024; > > Could you also add a comment from where this come from on the description > above? Ok, and commited. Thanks, Samuel