From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 03D5D3858028 for ; Fri, 26 Mar 2021 09:43:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03D5D3858028 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6H9P6KL2z1qt3s; Fri, 26 Mar 2021 10:43:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6H9P65kKz1t6pr; Fri, 26 Mar 2021 10:43:53 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id pZb2ZIxQlsSJ; Fri, 26 Mar 2021 10:43:53 +0100 (CET) X-Auth-Info: vRg52YGKQ3IcOWegvKYsSL/FeWiIKGHUe5hkwA2HquY= Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Mar 2021 10:43:53 +0100 (CET) Date: Fri, 26 Mar 2021 10:43:46 +0100 From: Lukasz Majewski To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH] misc: Fix tst-select timeout handling (BZ#27648) Message-ID: <20210326104346.05155e6b@jawa> In-Reply-To: <20210325200007.3571113-1-adhemerval.zanella@linaro.org> References: <20210325200007.3571113-1-adhemerval.zanella@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/._vf.SaQm5YTDWmGC8onfaJ"; protocol="application/pgp-signature" X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2021 09:43:56 -0000 --Sig_/._vf.SaQm5YTDWmGC8onfaJ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > Instead of polling the stderr, create two pipes and fork to check > if child timeout as expected similar to tst-pselect.c. Also lower > the timeout value. I'm just wondering why this approach (with pipes) is more safe than polling stderr? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/._vf.SaQm5YTDWmGC8onfaJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmBdrNIACgkQAR8vZIA0 zr0EHQf/RnhcP17TBLvdStVkMW44eStCHVgW/MQ8rxcWLT/UPlWPx6TZVW+Q1gl2 ADuZTdQ82q2uxILfZnlyIETOpHRi/UmepXNII+UCzCAx0RMmNg7oMQBgO3WK5fHh 1hdtK6oF/tF3HtBmE28NdCY0ajA2hg75bray9gAq+v1e+nx3iiMj137eeQ2sYdRp Q1bQoxclxmcXurke6Hy69hegnXZDluJVXBbi7phDQFA/D74AomT9FMWGxuA0RnjZ 4kZy+kDiSlDHNkdgrDHV6MhQivfLeTIdTacxXCgwJncmFoKDQ6oSv9waWqQqaSCv vX2gbbN/gM/IirACyTIDjvbIUfTq3Q== =c9fa -----END PGP SIGNATURE----- --Sig_/._vf.SaQm5YTDWmGC8onfaJ--