public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Subject: [PATCH] Check that strnlen won't go beyond the maximum length
Date: Sat, 27 Mar 2021 09:24:49 -0700	[thread overview]
Message-ID: <20210327162449.3215538-1-hjl.tools@gmail.com> (raw)

Run strnlen tests on strings without the null byte around the page
boundary.
---
 string/test-strnlen.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/string/test-strnlen.c b/string/test-strnlen.c
index 61eb521dc1..a49d93afa2 100644
--- a/string/test-strnlen.c
+++ b/string/test-strnlen.c
@@ -196,6 +196,31 @@ do_page_tests (void)
     }
 }
 
+/* Tests meant to unveil fail on implementation that does not access bytes
+   without the null character around the page boundary accordingly.  */
+static void
+do_page_2_tests (void)
+{
+  size_t i, exp_len, offset;
+  size_t last_offset = page_size / sizeof (CHAR);
+
+  CHAR *s = (CHAR *) buf2;
+  memset (s, 65, page_size);
+
+  /* Place short strings ending at page boundary.  */
+  offset = last_offset;
+  for (i = 0; i < 128; i++)
+    {
+      /* Decrease offset to stress several sizes and alignments.  */
+      offset--;
+      exp_len = last_offset - offset;
+      FOR_EACH_IMPL (impl, 0)
+        {
+          do_one_test (impl, (CHAR *) (s + offset), exp_len, exp_len);
+        }
+    }
+}
+
 int
 test_main (void)
 {
@@ -242,6 +267,7 @@ test_main (void)
 
   do_random_tests ();
   do_page_tests ();
+  do_page_2_tests ();
   return ret;
 }
 
-- 
2.30.2


             reply	other threads:[~2021-03-27 16:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 16:24 H.J. Lu [this message]
2021-03-27 17:51 ` Florian Weimer
2021-03-27 18:09   ` [PATCH v2] test-strnlen.c: " H.J. Lu
2021-03-27 18:34     ` Florian Weimer
2022-01-27 17:09       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210327162449.3215538-1-hjl.tools@gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).